linux.git/fs/jbd2, branch for-next

jbd2: flush filesystem device before updating tail sequence

2024-12-04T11:00:05+00:00

When committing transaction in jbd2_journal_commit_transaction(), the
disk caches for the filesystem device should be flushed before updating
the journal tail sequence. However, this step is missed if the journal
is not located on the filesystem device. As a result, the filesystem may
become inconsistent following a power failure or system crash. Fix it by
ensuring that the filesystem device is flushed appropriately.

Fixes: 3339578f0578 ("jbd2: cleanup journal tail after transaction commit")
Signed-off-by: Zhang Yi 
Link: https://lore.kernel.org/r/20241203014407.805916-3-yi.zhang@huaweicloud.com
Reviewed-by: Jan Kara 
Signed-off-by: Christian Brauner

jbd2: increase IO priority for writing revoke records

2024-12-04T11:00:05+00:00

Commit '6a3afb6ac6df ("jbd2: increase the journal IO's priority")'
increases the priority of journal I/O by marking I/O with the
JBD2_JOURNAL_REQ_FLAGS. However, that commit missed the revoke buffers,
so also addresses that kind of I/Os.

Fixes: 6a3afb6ac6df ("jbd2: increase the journal IO's priority")
Signed-off-by: Zhang Yi 
Link: https://lore.kernel.org/r/20241203014407.805916-2-yi.zhang@huaweicloud.com
Reviewed-by: Kemeng Shi 
Reviewed-by: Jan Kara 
Signed-off-by: Christian Brauner

jbd2: Fix comment describing journal_init_common()

2024-11-13T17:56:48+00:00

The code indicates that journal_init_common() fills the journal_t object
it returns while the comment incorrectly states that only a few fields are
initialised.  Also, the comment claims that journal structures could be
created from scratch which isn't possible as journal_init_common() calls
journal_load_superblock() which loads and checks journal superblock from
disk.

Signed-off-by: Daniel Martín Gómez 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20241107144538.3544-1-dalme@riseup.net
Signed-off-by: Theodore Ts'o

jbd2: make b_frozen_data allocation always succeed

2024-11-13T04:54:15+00:00

The b_frozen_data allocation should not be failed during journal
committing process, otherwise jbd2 will abort.
Since commit 490c1b444ce653d("jbd2: do not fail journal because of
frozen_buffer allocation failure") already added '__GFP_NOFAIL' flag
in do_get_write_access(), just add '__GFP_NOFAIL' flag for all allocations
in jbd2_journal_write_metadata_buffer(), like 'new_bh' allocation does.
Besides, remove all error handling branches for do_get_write_access().

Signed-off-by: Zhihao Cheng 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20241012085530.2147846-1-chengzhihao@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: remove the 'success' parameter from the jbd2_do_replay() function

2024-11-13T04:54:14+00:00

Keep 'success' internally to track if any error happened and then
return it at the end in do_one_pass(). If jbd2_do_replay() return
-ENOMEM then stop replay journal.

Signed-off-by: Ye Bin 
Reviewed-by: Zhang Yi 
Reviewed-by: Jan Kara 
Link: https://patch.msgid.link/20240930005942.626942-7-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: remove useless 'block_error' variable

2024-11-13T04:54:14+00:00

The judgement 'if (block_error && success == 0)' is never valid. Just
remove useless 'block_error' variable.

Signed-off-by: Ye Bin 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20240930005942.626942-6-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: factor out jbd2_do_replay()

2024-11-13T04:54:14+00:00

Factor out jbd2_do_replay() no funtional change.

Signed-off-by: Ye Bin 
Reviewed-by: Zhang Yi 
Reviewed-by: Jan Kara 
Link: https://patch.msgid.link/20240930005942.626942-5-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: refactor JBD2_COMMIT_BLOCK process in do_one_pass()

2024-11-13T04:54:14+00:00

To make JBD2_COMMIT_BLOCK process more clean, no functional change.

Signed-off-by: Ye Bin 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20240930005942.626942-4-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: unified release of buffer_head in do_one_pass()

2024-11-13T04:54:14+00:00

Now buffer_head free is very fragmented in do_one_pass(), unified release
of buffer_head in do_one_pass()

Signed-off-by: Ye Bin 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20240930005942.626942-3-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o

jbd2: remove redundant judgments for check v1 checksum

2024-11-13T04:54:14+00:00

'need_check_commit_time' is only used by v2/v3 checksum, so there isn't
need to add 'need_check_commit_time' judegement for v1 checksum logic.

Signed-off-by: Ye Bin 
Reviewed-by: Jan Kara 
Reviewed-by: Zhang Yi 
Link: https://patch.msgid.link/20240930005942.626942-2-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o