linux.git/fs/ioctl.c, branch v2.6.28

Fix a race condition in FASYNC handling

2008-12-05T23:35:10+00:00

Changeset a238b790d5f99c7832f9b73ac8847025815b85f7 (Call fasync()
functions without the BKL) introduced a race which could leave
file->f_flags in a state inconsistent with what the underlying
driver/filesystem believes.  Revert that change, and also fix the same
races in ioctl_fioasync() and ioctl_fionbio().

This is a minimal, short-term fix; the real fix will not involve the
BKL.

Reported-by: Oleg Nesterov 
Cc: Andi Kleen 
Cc: Al Viro 
Cc: stable@kernel.org
Signed-off-by: Jonathan Corbet 
Signed-off-by: Linus Torvalds

provide generic_block_fiemap() only with BLOCK=y

2008-10-12T18:44:37+00:00

This fixes the following compile error with CONFIG_BLOCK=n caused by
commit 68c9d702bb72f367f3b148963ec6cf5e07ff7f65 ("generic block based
fiemap implementation"):

    CC      fs/ioctl.o
  fs/ioctl.c: In function 'generic_block_fiemap':
  fs/ioctl.c:249: error: storage size of 'tmp' isn't known
  fs/ioctl.c:272: error: invalid application of 'sizeof' to incomplete type 'struct buffer_head'
  fs/ioctl.c:280: error: implicit declaration of function 'buffer_mapped'
  fs/ioctl.c:249: warning: unused variable 'tmp'
  make[2]: *** [fs/ioctl.o] Error 1

Signed-off-by: Adrian Bunk 
Acked-by: Josef Bacik 
Signed-off-by: Linus Torvalds

generic block based fiemap implementation

2008-10-03T21:32:43+00:00

Any block based fs (this patch includes ext3) just has to declare its own
fiemap() function and then call this generic function with its own
get_block_t. This works well for block based filesystems that will map
multiple contiguous blocks at one time, but will work for filesystems that
only map one block at a time, you will just end up with an "extent" for each
block. One gotcha is this will not play nicely where there is hole+data
after the EOF. This function will assume its hit the end of the data as soon
as it hits a hole after the EOF, so if there is any data past that it will
not pick that up. AFAIK no block based fs does this anyway, but its in the
comments of the function anyway just in case.

Signed-off-by: Josef Bacik 
Signed-off-by: Mark Fasheh 
Signed-off-by: "Theodore Ts'o" 
Cc: linux-fsdevel@vger.kernel.org

vfs: vfs-level fiemap interface

2008-10-08T23:44:18+00:00

Basic vfs-level fiemap infrastructure, which sets up a new ->fiemap
inode operation.

Userspace can get extent information on a file via fiemap ioctl. As input,
the fiemap ioctl takes a struct fiemap which includes an array of struct
fiemap_extent (fm_extents). Size of the extent array is passed as
fm_extent_count and number of extents returned will be written into
fm_mapped_extents. Offset and length fields on the fiemap structure
(fm_start, fm_length) describe a logical range which will be searched for
extents. All extents returned will at least partially contain this range.
The actual extent offsets and ranges returned will be unmodified from their
offset and range on-disk.

The fiemap ioctl returns '0' on success. On error, -1 is returned and errno
is set. If errno is equal to EBADR, then fm_flags will contain those flags
which were passed in which the kernel did not understand. On all other
errors, the contents of fm_extents is undefined.

As fiemap evolved, there have been many authors of the vfs patch. As far as
I can tell, the list includes:
Kalpak Shah 
Andreas Dilger 
Eric Sandeen 
Mark Fasheh 

Signed-off-by: Mark Fasheh 
Signed-off-by: "Theodore Ts'o" 
Cc: Michael Kerrisk 
Cc: linux-api@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org

make vfs_ioctl() static

2008-04-29T15:06:00+00:00

Make the needlessly global vfs_ioctl() static.

Signed-off-by: Adrian Bunk 
Acked-by: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fix up kerneldoc in fs/ioctl.c a little bit

2008-02-09T19:08:33+00:00

 - remove non-standard in/out markers
 - use tabs for formatting

Signed-off-by: Christoph Hellwig 
Cc: "Randy.Dunlap" 
Cc: Erez Zadok 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

2008-02-07T16:42:16+00:00

Factor out file-specific ioctl code into smaller helper functions, away from
file_ioctl().  This helps code readability and also reduces indentation inside
case statements.

Signed-off-by: Erez Zadok 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

VFS: swap do_ioctl and vfs_ioctl names

2008-02-07T16:42:16+00:00

Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name.  The new do_ioctl
is exported in fs.h but not to modules.

Rename the old do_ioctl to vfs_ioctl because the names vfs_XXX should
preferably be reserved to callable VFS functions which modules may call, as
many other vfs_XXX functions already do.  Export the new vfs_ioctl to GPL
modules so others can use it (including Unionfs and eCryptfs).  Add DocBook
for new vfs_ioctl.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Erez Zadok 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

VFS: apply coding standards to fs/ioctl.c

2008-02-07T16:42:16+00:00

Signed-off-by: Erez Zadok 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drop obsolete sys_ioctl export

2007-07-16T16:05:48+00:00

sys_ioctl() was only exported for our first version of compat ioctl
handling.  Now that the whole compat ioctl handling mess is more or less
sorted out there are no more modular users left and we can kill it.

There's one exception and that's sparc64's solaris compat module, but
sparc64 has it's own export predating the generic one by years for that
which this patch leaves untouched.

Signed-off-by: Christoph Hellwig 
Acked-by: David S. Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds