linux.git/fs/hfsplus/dir.c, branch v3.17

hfsplus: emit proper file type from readdir

2014-06-06T23:08:09+00:00

hfsplus_readdir() incorrectly returned DT_REG for symbolic links and
special files.  Return DT_REG, DT_LNK, DT_FIFO, DT_CHR, DT_BLK, DT_SOCK,
or DT_UNKNOWN according to mode field in catalog record.  Programs
relying on information from readdir will now work correctly with HFS+.

Signed-off-by: Sergei Antonov 
Cc: Anton Altaparmakov 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Vyacheslav Dubeyko 
Cc: Hin-Tak Leung 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: fix worst-case unicode to char conversion of file names and attributes

2014-06-06T23:08:09+00:00

This is a series of 3 patches which corrects issues in HFS+ concerning
the use of non-english file names and attributes.  Names and attributes
are stored internally as UTF-16 units up to a fixed maximum size, and
convert to and from user-representation by NLS.  The code incorrectly
assume that NLS string lengths are equal to unicode lengths, which is
only true for English ascii usage.

This patch (of 3):

The HFS Plus Volume Format specification (TN1150) states that file names
are stored internally as a maximum of 255 unicode characters, as defined
by The Unicode Standard, Version 2.0 [Unicode, Inc.  ISBN
0-201-48345-9].  File names are converted by the NLS system on Linux
before presented to the user.

255 CJK characters converts to UTF-8 with 1 unicode character to up to 3
bytes, and to GB18030 with 1 unicode character to up to 4 bytes.  Thus,
trying in a UTF-8 locale to list files with names of more than 85 CJK
characters results in:

    $ ls /mnt
    ls: reading directory /mnt: File name too long

The receiving buffer to hfsplus_uni2asc() needs to be 255 x
NLS_MAX_CHARSET_SIZE bytes, not 255 bytes as the code has always been.

Similar consideration applies to attributes, which are stored internally
as a maximum of 127 UTF-16BE units.  See XNU source for an up-to-date
reference on attributes.

Strictly speaking, the maximum value of NLS_MAX_CHARSET_SIZE = 6 is not
attainable in the case of conversion to UTF-8, as going beyond 3 bytes
requires the use of surrogate pairs, i.e.  consuming two input units.

Thanks Anton Altaparmakov for reviewing an earlier version of this
change.

This patch fixes all callers of hfsplus_uni2asc(), and also enables the
use of long non-English file names in HFS+.  The getting and setting,
and general usage of long non-English attributes requires further
forthcoming work, in the following patches of this series.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Hin-Tak Leung 
Reviewed-by: Anton Altaparmakov 
Cc: Vyacheslav Dubeyko 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Sougata Santra 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: use xattr handlers for removexattr

2014-01-31T19:44:39+00:00

hfsplus was already using the handlers for get and set operations,
and with the removal of can_set_xattr we've now allow operations that
wouldn't otherwise be allowed.

With this we can also centralize the special-casing of the osx.
attrs that don't have prefixes on disk in the osx xattr handlers.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

hfsplus: use generic posix ACL infrastructure

2014-01-26T04:58:20+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Vyacheslav Dubeyko 
Signed-off-by: Al Viro

hfsplus: integrate POSIX ACLs support into driver

2013-09-11T22:59:01+00:00

Integrate implemented POSIX ACLs support into hfsplus driver.

Signed-off-by: Vyacheslav Dubeyko 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Hin-Tak Leung 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[readdir] convert hfsplus

2013-06-29T08:56:56+00:00

Signed-off-by: Al Viro

hfs/hfsplus: convert printks to pr_

2013-05-01T00:04:05+00:00

Use a more current logging style.

Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
hfsplus now uses "hfsplus: " for all messages.
Coalesce formats.
Prefix debugging messages too.

Signed-off-by: Joe Perches 
Cc: Vyacheslav Dubeyko 
Cc: Hin-Tak Leung 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: add support of manipulation by attributes file

2013-02-28T03:10:10+00:00

Add support of manipulation by attributes file.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

new helper: file_inode(file)

2013-02-23T04:31:31+00:00

Signed-off-by: Al Viro

hfsplus: get rid of write_super

2012-07-22T19:58:04+00:00

This patch makes hfsplus stop using the VFS '->write_super()' method along with
the 's_dirt' superblock flag, because they are on their way out.

The whole "superblock write-out" VFS infrastructure is served by the
'sync_supers()' kernel thread, which wakes up every 5 (by default) seconds and
writes out all dirty superblocks using the '->write_super()' call-back.  But the
problem with this thread is that it wastes power by waking up the system every
5 seconds, even if there are no diry superblocks, or there are no client
file-systems which would need this (e.g., btrfs does not use
'->write_super()'). So we want to kill it completely and thus, we need to make
file-systems to stop using the '->write_super()' VFS service, and then remove
it together with the kernel thread.

Tested using fsstress from the LTP project.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: Al Viro