linux.git/fs/fuse/inode.c, branch v4.0

fs: remove mapping->backing_dev_info

2015-01-20T21:03:05+00:00

Now that we never use the backing_dev_info pointer in struct address_space
we can simply remove it and save 4 to 8 bytes in every inode.

Signed-off-by: Christoph Hellwig 
Acked-by: Ryusuke Konishi 
Reviewed-by: Tejun Heo 
Reviewed-by: Jan Kara 
Signed-off-by: Jens Axboe

fuse: add memory barrier to INIT

2015-01-06T09:45:35+00:00

Theoretically we need to order setting of various fields in fc with
fc->initialized.

No known bug reports related to this yet.

Signed-off-by: Miklos Szeredi

fuse: fix LOOKUP vs INIT compat handling

2015-01-06T09:45:35+00:00

Analysis from Marc:

 "Commit 7078187a795f ("fuse: introduce fuse_simple_request() helper")
  from the above pull request triggers some EIO errors for me in some tests
  that rely on fuse

  Looking at the code changes and a bit of debugging info I think there's a
  general problem here that fuse_get_req checks and possibly waits for
  fc->initialized, and this was always called first.  But this commit
  changes the ordering and in many places fc->minor is now possibly used
  before fuse_get_req, and we can't be sure that fc has been initialized.
  In my case fuse_lookup_init sets req->out.args[0].size to the wrong size
  because fc->minor at that point is still 0, leading to the EIO error."

Fix by moving the compat adjustments into fuse_simple_request() to after
fuse_get_req().

This is also more readable than the original, since now compatibility is
handled in a single function instead of cluttering each operation.

Reported-by: Marc Dionne 
Tested-by: Marc Dionne 
Signed-off-by: Miklos Szeredi 
Fixes: 7078187a795f ("fuse: introduce fuse_simple_request() helper")

fuse: introduce fuse_simple_request() helper

2014-12-12T08:49:05+00:00

The following pattern is repeated many times:

	req = fuse_get_req_nopages(fc);
	/* Initialize req->(in|out).args */
	fuse_request_send(fc, req);
	err = req->out.h.error;
	fuse_put_request(req);

Create a new replacement helper:

	/* Initialize args */
	err = fuse_simple_request(fc, &args);

In addition to reducing the code size, this will ease moving from the
complex arg-based to a simpler page-based I/O on the fuse device.

Signed-off-by: Miklos Szeredi

fuse: flush requests on umount

2014-12-12T08:49:04+00:00

Use fuse_abort_conn() instead of fuse_conn_kill() in fuse_put_super().
This flushes and aborts requests still on any queues.  But since we've
already reset fc->connected, those requests would not be useful anyway and
would be flushed when the fuse device is closed.

Next patches will rely on requests being flushed before the superblock is
destroyed.

Use fuse_abort_conn() in cuse_process_init_reply() too, since it makes no
difference there, and we can get rid of fuse_conn_kill().

Signed-off-by: Miklos Szeredi

fuse: don't wake up reserved req in fuse_conn_kill()

2014-12-12T08:49:04+00:00

Waking up reserved_req_waitq from fuse_conn_kill() doesn't make sense since
we aren't chaging ff->reserved_req here, which is what this waitqueue
signals.

Signed-off-by: Miklos Szeredi

fuse: add FUSE_NO_OPEN_SUPPORT flag to INIT

2014-07-22T14:37:43+00:00

Here some additional changes to set a capability flag so that clients can
detect when it's appropriate to return -ENOSYS from open.

This amends the following commit introduced in 3.14:

  7678ac50615d  fuse: support clients that don't implement 'open'

However we can only add the flag to 3.15 and later since there was no
protocol version update in 3.14.

Signed-off-by: Miklos Szeredi 
Cc:  # v3.15+

fuse: s_time_gran fix

2014-07-22T14:37:42+00:00

Default s_time_gran is 1, don't overwrite that if userspace didn't
explicitly specify one.

Signed-off-by: Miklos Szeredi 
Cc:  # v3.15+

fuse: handle large user and group ID

2014-07-07T13:28:51+00:00

If the number in "user_id=N" or "group_id=N" mount options was larger than
INT_MAX then fuse returned EINVAL.

Fix this to handle all valid uid/gid values.

Signed-off-by: Miklos Szeredi 
Cc: stable@vger.kernel.org

fuse: inode: drop cast

2014-07-07T13:28:51+00:00

This patch removes the cast on data of type void * as it is not needed.
The following Coccinelle semantic patch was used for making the change:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: Miklos Szeredi