linux.git/fs/fuse/dir.c, branch v5.1

fuse: Protect fi->nlookup with fi->lock

2019-02-13T12:15:14+00:00

This continues previous patch and introduces the same protection for
nlookup field.

Signed-off-by: Kirill Tkhai 
Signed-off-by: Miklos Szeredi

fuse: Introduce fi->lock to protect write related fields

2019-02-13T12:15:14+00:00

To minimize contention of fc->lock, this patch introduces a new spinlock
for protection fuse_inode metadata:

fuse_inode:
	writectr
	writepages
	write_files
	queued_writes
	attr_version

inode:
	i_size
	i_nlink
	i_mtime
	i_ctime

Also, it protects the fields changed in fuse_change_attributes_common()
(too many to list).

Signed-off-by: Kirill Tkhai 
Signed-off-by: Miklos Szeredi

fuse: Convert fc->attr_version into atomic64_t

2019-02-13T12:15:13+00:00

This patch makes fc->attr_version of atomic64_t type, so fc->lock won't be
needed to read or modify it anymore.

Signed-off-by: Kirill Tkhai 
Signed-off-by: Miklos Szeredi

fuse: Add fuse_inode argument to fuse_prepare_release()

2019-02-13T12:15:13+00:00

Here is preparation for next patches, which introduce new fi->lock for
protection of ff->write_entry linked into fi->write_files.

This patch just passes new argument to the function.

Signed-off-by: Kirill Tkhai 
Signed-off-by: Miklos Szeredi

fuse: continue to send FUSE_RELEASEDIR when FUSE_OPEN returns ENOSYS

2018-12-11T20:47:28+00:00

When FUSE_OPEN returns ENOSYS, the no_open bit is set on the connection.

Because the FUSE_RELEASE and FUSE_RELEASEDIR paths share code, this
incorrectly caused the FUSE_RELEASEDIR request to be dropped and never sent
to userspace.

Pass an isdir bool to distinguish between FUSE_RELEASE and FUSE_RELEASEDIR
inside of fuse_file_put.

Fixes: 7678ac50615d ("fuse: support clients that don't implement 'open'")
Cc:  # v3.14
Signed-off-by: Chad Austin 
Signed-off-by: Miklos Szeredi

fuse: fix revalidation of attributes for permission check

2018-12-03T09:14:43+00:00

fuse_invalidate_attr() now sets fi->inval_mask instead of fi->i_time, hence
we need to check the inval mask in fuse_permission() as well.

Signed-off-by: Miklos Szeredi 
Fixes: 2f1e81965fd0 ("fuse: allow fine grained attr cache invaldation")

fuse: fix fsync on directory

2018-12-03T09:14:43+00:00

Commit ab2257e9941b ("fuse: reduce size of struct fuse_inode") moved parts
of fields related to writeback on regular file and to directory caching
into a union.  However fuse_fsync_common() called from fuse_dir_fsync()
touches some writeback related fields, resulting in a crash.

Move writeback related parts from fuse_fsync_common() to fuse_fysnc().

Reported-by: Brett Girton 
Tested-by: Brett Girton 
Fixes: ab2257e9941b ("fuse: reduce size of struct fuse_inode")
Signed-off-by: Miklos Szeredi

fuse: enable caching of symlinks

2018-10-15T13:43:07+00:00

FUSE file reads are cached in the page cache, but symlink reads are
not. This patch enables FUSE READLINK operations to be cached which
can improve performance of some FUSE workloads.

In particular, I'm working on a FUSE filesystem for access to source
code and discovered that about a 10% improvement to build times is
achieved with this patch (there are a lot of symlinks in the source
tree).

Signed-off-by: Miklos Szeredi

fuse: don't need GETATTR after every READ

2018-10-15T13:43:06+00:00

If 'auto_inval_data' mode is active, then fuse_file_read_iter() will call
fuse_update_attributes(), which will check the attribute validity and send
a GETATTR request if some of the attributes are no longer valid.  The page
cache is then invalidated if the size or mtime have changed.

Then, if a READ request was sent and reply received (which is the case if
the data wasn't cached yet, or if the file is opened for O_DIRECT), the
atime attribute is invalidated.

This will result in the next read() also triggering a GETATTR, ...

This can be fixed by only sending GETATTR if the mode or size are invalid,
we don't need to do a refresh if only atime is invalid.

More generally, none of the callers of fuse_update_attributes() need an
up-to-date atime value, so for now just remove STATX_ATIME from the request
mask when attributes are updated for internal use.

Signed-off-by: Miklos Szeredi

fuse: allow fine grained attr cache invaldation

2018-10-15T13:43:06+00:00

This patch adds the infrastructure for more fine grained attribute
invalidation.  Currently only 'atime' is invalidated separately.

The use of this infrastructure is extended to the statx(2) interface, which
for now means that if only 'atime' is invalid and STATX_ATIME is not
specified in the mask argument, then no GETATTR request will be generated.

Signed-off-by: Miklos Szeredi