linux.git/fs/f2fs, branch v3.8-rc2

f2fs: Don't assign e_id in f2fs_acl_from_disk

2012-12-26T04:05:15+00:00

With user namespaces enabled building f2fs fails with:

 CC      fs/f2fs/acl.o
fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
make[2]: *** [fs/f2fs/acl.o] Error 1
make[2]: Target `__build' not remade because of errors.

e_id is a backwards compatibility field only used for file systems
that haven't been converted to use kuids and kgids.  When the posix
acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
unnecessary.  Remove the assignment so f2fs will build with user
namespaces enabled.

Cc: Namjae Jeon 
Cc: Amit Sahrawat 
Acked-by: Jaegeuk Kim 
Signed-off-by: "Eric W. Biederman"

f2fs: fix tracking parent inode number

2012-12-11T04:43:45+00:00

Previously, f2fs didn't track the parent inode number correctly which is stored
in each f2fs_inode. In the case of the following scenario, a bug can be occured.

Let's suppose there are one directory, "/b", and two files, "/a" and "/b/a".
 - pino of "/a" is ROOT_INO.
 - pino of "/b/a" is DIR_B_INO.

Then,
 # sync
  : The inode pages of "/a" and "/b/a" contain the parent inode numbers as
    ROOT_INO and DIR_B_INO respectively.
 # mv /a /b/a
  : The parent inode number of "/a" should be changed to DIR_B_INO, but f2fs
    didn't do that. Ref. f2fs_set_link().

In order to fix this clearly, I added i_pino in f2fs_inode_info, and whenever
it needs to be changed like in f2fs_add_link() and f2fs_set_link(), it is
updated temporarily in f2fs_inode_info.

And later, f2fs_write_inode() stores the latest information to the inode pages.
For power-off-recovery, f2fs_sync_file() triggers simply f2fs_write_inode().

Signed-off-by: Jaegeuk Kim

f2fs: cleanup the f2fs_bio_alloc routine

2012-12-11T04:43:45+00:00

Do cleanup more for better code readability.

- Change the parameter set of f2fs_bio_alloc()
  This function should allocate a bio only since it is not something like
  f2fs_bio_init(). Instead, the caller should initialize the allocated bio.

- Introduce SECTOR_FROM_BLOCK
  This macro translates a block address to its sector address.

Signed-off-by: Jaegeuk Kim 
Reviewed-by: Namjae Jeon

f2fs: introduce accessor to retrieve number of dentry slots

2012-12-11T04:43:45+00:00

Simplify code by providing the accessor macro to retrieve the
number of dentry slots for a given filename length.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat

f2fs: remove redundant call to f2fs_put_page in delete entry

2012-12-11T04:43:44+00:00

Since, we anyway need to put the page after deleting entry. So, there is no
need to make same call under different conditions.
Move out the f2fs_put_page from the two conditions and call at once.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat

f2fs: make use of GFP_F2FS_ZERO for setting gfp_mask

2012-12-11T04:43:44+00:00

Since, GFP_NOFS and __GFP_ZERO is being used to set gfp_mask.
We can instead make use of already predefined macro GFP_F2FS_ZERO.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat

f2fs: rewrite f2fs_bio_alloc to make it simpler

2012-12-11T04:43:44+00:00

Since, GFP_NOFS(__GFP_WAIT) is used for allocation requests of bio in f2fs.
So, there is no chance of returning NULL from the BIO allocation.

Making the bio allocation routine for f2fs simpler.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat

f2fs: remove unused variable

2012-12-11T04:43:44+00:00

The variables node_page and page_offset are initialized but never used
otherwise, so remove those unused variables.

Signed-off-by: Wei Yongjun

f2fs: move error condition for mkdir at proper place

2012-12-11T04:43:44+00:00

In function f2fs_mkdir, err is being initialized without even checking
if there was any error in new inode creation. So, instead check the
inode error and make use of error/return condition.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat

f2fs: remove unneeded initialization

2012-12-11T04:43:44+00:00

No need to initialize  "struct f2fs_gc_kthread *gc_th = NULL",
as gc_th = NULL, will be taken care by the return values of kmalloc().
And fix codes in other places.

Signed-off-by: Namjae Jeon 
Signed-off-by: Amit Sahrawat