linux.git/fs/f2fs/segment.c, branch v6.4

f2fs: allocate node blocks for atomic write block replacement

2023-04-24T18:03:10+00:00

When a node block is missing for atomic write block replacement, we need
to allocate it in advance of the replacement.

Signed-off-by: Daeho Jeong 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove power-of-two limitation of zoned device

2023-04-24T18:03:10+00:00

In f2fs, there's no reason to force po2.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add has_enough_free_secs()

2023-04-18T16:05:54+00:00

Replace !has_not_enough_free_secs w/ has_enough_free_secs.
BTW avoid nested 'if' statements in f2fs_balance_fs().

Signed-off-by: Yangtao Li 
Signed-off-by: Jaegeuk Kim

f2fs: fix to check return value of inc_valid_block_count()

2023-04-13T23:37:57+00:00

In __replace_atomic_write_block(), we missed to check return value
of inc_valid_block_count(), for extreme testcase that f2fs image is
run out of space, it may cause inconsistent status in between SIT
table and total valid block count.

Cc: Daeho Jeong 
Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix passing relative address when discard zones

2023-04-13T23:37:57+00:00

We should not pass relative address in a zone to
__f2fs_issue_discard_zone().

Signed-off-by: Daeho Jeong 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove struct victim_selection default_v_ops

2023-04-10T17:58:44+00:00

There is only single instance of these ops, and Jaegeuk point out that:

    Originally this was intended to give a chance to provide other
    allocation option. Anyway, it seems quit hard to do it anymore.

So remove the indirection and call f2fs_get_victim() directly.

Signed-off-by: Yangtao Li 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix null pointer panic in tracepoint in __replace_atomic_write_block

2023-04-04T20:57:30+00:00

We got a kernel panic if old_addr is NULL.

https://bugzilla.kernel.org/show_bug.cgi?id=217266

BUG: kernel NULL pointer dereference, address: 0000000000000000
 Call Trace:
  
  f2fs_commit_atomic_write+0x619/0x990 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
  __f2fs_ioctl+0xd8e/0x4080 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
  ? vfs_write+0x2ae/0x3f0
  ? vfs_write+0x2ae/0x3f0
  __x64_sys_ioctl+0x91/0xd0
  do_syscall_64+0x5c/0x90
  entry_SYSCALL_64_after_hwframe+0x72/0xdc
 RIP: 0033:0x7f69095fe53f

Fixes: 2f3a9ae990a7 ("f2fs: introduce trace_f2fs_replace_atomic_write_block")
Cc: 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix align check for npo2

2023-04-04T20:57:30+00:00

Fix alignment check to be correct in npo2 as well

Signed-off-by: Yohan Joung 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: apply zone capacity to all zone type

2023-03-29T22:17:39+00:00

If we manage the zone capacity per zone type, it'll break the GC assumption.
And, the current logic complains valid block count mismatch.
Let's apply zone capacity to all zone type, if specified.

Fixes: de881df97768 ("f2fs: support zone capacity less than zone size")
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Fix discard bug on zoned block devices with 2MiB zone size

2023-03-29T22:17:38+00:00

When using f2fs on a zoned block device with 2MiB zone size, IO errors
occurs because f2fs tries to write data to a zone that has not been reset.

The cause is that f2fs tries to discard multiple zones at once. This is
caused by a condition in f2fs_clear_prefree_segments that does not check
for zoned block devices when setting the discard range. This leads to
invalid reset commands and write pointer mismatches.

This patch fixes the zoned block device with 2MiB zone size to reset one
zone at a time.

Signed-off-by: Yonggil Song 
Signed-off-by: Jaegeuk Kim