linux.git/fs/f2fs/segment.c, branch v6.3

f2fs: Revert "f2fs: truncate blocks in batch in __complete_revoke_list()"

2023-02-15T17:48:28+00:00

We should not truncate replaced blocks, and were supposed to truncate the first
part as well.

This reverts commit 78a99fe6254cad4be310cd84af39f6c46b668c72.

Cc: stable@vger.kernel.org
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: synchronize atomic write aborts

2023-02-14T18:08:59+00:00

To fix a race condition between atomic write aborts, I use the inode
lock and make COW inode to be re-usable thoroughout the whole
atomic file inode lifetime.

Reported-by: syzbot+823000d23b3400619f7c@syzkaller.appspotmail.com
Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
Signed-off-by: Daeho Jeong 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix typos in comments

2023-02-07T18:39:28+00:00

This patch is to fix typos in f2fs files.

Signed-off-by: Jinyoung Choi 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: reduce stack memory cost by using bitfield in struct f2fs_io_info

2023-02-02T21:37:16+00:00

This patch tries to use bitfield in struct f2fs_io_info to improve
memory usage.

struct f2fs_io_info {
...
	unsigned int need_lock:8;	/* indicate we need to lock cp_rwsem */
	unsigned int version:8;		/* version of the node */
	unsigned int submitted:1;	/* indicate IO submission */
	unsigned int in_list:1;		/* indicate fio is in io_list */
	unsigned int is_por:1;		/* indicate IO is from recovery or not */
	unsigned int retry:1;		/* need to reallocate block address */
	unsigned int encrypted:1;	/* indicate file is encrypted */
	unsigned int post_read:1;	/* require post read */
...
};

After this patch, size of struct f2fs_io_info reduces from 136 to 120.

[Nathan: fix a compile warning (single-bit-bitfield-constant-conversion)]
Signed-off-by: Nathan Chancellor 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove __has_curseg_space

2023-02-02T21:37:16+00:00

Just open code the logic in the only caller, where it is more
obvious.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: refactor next blk selection

2023-02-02T21:37:16+00:00

Remove __refresh_next_blkoff by opencoding the SSR vs LFS segment check
in the only caller, and then add helpers for SSR block selection and
blkoff randomization instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove __allocate_new_section

2023-02-02T21:37:16+00:00

Just fold this trivial wrapper into the only caller.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: refactor __allocate_new_segment

2023-02-02T21:37:16+00:00

Simplify the check whether to allocate a new segment or reuse an open
one.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add a f2fs_curseg_valid_blocks helper

2023-02-02T21:37:15+00:00

Add a helper to return the valid blocks on log and SSR segments, and
replace the last two uses of curseg_blkoff with it.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove __add_sum_entry

2023-01-31T18:49:30+00:00

This function just assigns a summary entry.  This can be done entirely
typesafe with an open code struct assignment that relies on array
indexing.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim