linux.git/fs/f2fs/segment.c, branch v3.17

f2fs: remove rewrite_node_page

2014-08-21T20:57:02+00:00

I think we need to let the dirty node pages remain in the page cache instead
of rewriting them in their places.
So, after done with successful recovery, write_checkpoint will flush all of them
through the normal write path.
Through this, we can avoid potential error cases in terms of block allocation.

Signed-off-by: Jaegeuk Kim

f2fs: fix typo

2014-08-19T17:01:33+00:00

Fix typo and some grammatical errors.

The words "filesystem" and "readahead" are being used without the space treewide.

Signed-off-by: Park Ju Hyung 
Signed-off-by: Jaegeuk Kim

f2fs: use for_each_set_bit to simplify the code

2014-08-04T20:20:53+00:00

This patch uses for_each_set_bit to simplify some codes in f2fs.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove redundant lines in allocate_data_block

2014-07-30T22:38:59+00:00

There are redundant lines in allocate_data_block.

In this function, we call refresh_sit_entry with old seg and old curseg.
After that, we call locate_dirty_segment with old curseg.

But, the new address is always allocated from old curseg and
we call locate_dirty_segment with old curseg in refresh_sit_entry.
So, we do not need to call locate_dirty_segment with old curseg again.

We've discussed like below:

Jaegeuk said:
 "When considering SSR, we need to take care of the following scenario.
  - old segno : X
  - new address : Z
  - old curseg : Y
  This means, a new block is supposed to be written to Z from X.
  And Z is newly allocated in the same path from Y.

  In that case, we should trigger locate_dirty_segment for Y, since
  it was a current_segment and can be dirty owing to SSR.
  But that was not included in the dirty list."

Changman said:
 "We already choosed old curseg(Y) and then we allocate new address(Z) from old
  curseg(Y). After that we call refresh_sit_entry(old address, new address).
  In the funcation, we call locate_dirty_segment with old seg and old curseg.
  So calling locate_dirty_segment after refresh_sit_entry again is redundant."

Jaegeuk said:
 "Right. The new address is always allocated from old_curseg."

Reviewed-by: Chao Yu 
Signed-off-by: Dongho Sim 
Signed-off-by: Jaegeuk Kim

f2fs: add tracepoint for f2fs_issue_flush

2014-07-30T21:13:36+00:00

This patch adds a tracepoint for f2fs_issue_flush.

Signed-off-by: Jaegeuk Kim

f2fs: avoid retrying wrong recovery routine when error was occurred

2014-07-30T21:13:35+00:00

This patch eliminates the propagation of recovery errors to the next mount.

Signed-off-by: Jaegeuk Kim

f2fs: add nobarrier mount option

2014-07-29T12:27:48+00:00

This patch adds a mount option, nobarrier, in f2fs.
The assumption in here is that file system keeps the IO ordering, but
doesn't care about cache flushes inside the storages.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: use inner macro and function to clean up codes

2014-07-09T21:04:26+00:00

In this patch we use below inner macro and function to clean up codes.
1. ADDRS_PER_PAGE
2. SM_I
3. f2fs_readonly

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: replace count*size kzalloc by kcalloc

2014-07-09T21:04:25+00:00

kcalloc manages count*sizeof overflow.

Cc: Jaegeuk Kim 
Cc: linux-f2fs-devel@lists.sourceforge.net
Signed-off-by: Fabian Frederick 
Signed-off-by: Jaegeuk Kim

f2fs: avoid to access NULL pointer in issue_flush_thread

2014-07-09T12:59:55+00:00

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=75861

Denis 2014-05-10 11:28:59 UTC reported:
"F2FS-fs (mmcblk0p28): mounting..
 Unable to handle kernel NULL pointer dereference at virtual address 00000018
 ...
 [] (_raw_spin_lock+0x3c/0x70) from [] (issue_flush_thread+0x50/0x17c)
 [] (issue_flush_thread+0x50/0x17c) from [] (kthread+0x98/0xa4)
 [] (kthread+0x98/0xa4) from [] (kernel_thread_exit+0x0/0x8)"

This patch assign cmd_control_info in sm_info before issue_flush_thread is being
created, so this make sure that issue flush thread will have no chance to access
invalid info in fcc.

Signed-off-by: Chao Yu 
Reviewed-by: Gu Zheng 
Signed-off-by: Jaegeuk Kim