linux.git/fs/f2fs/node.h, branch v4.14

f2fs: simplify the way of calulating next nat address

2017-07-04T09:11:34+00:00

The index of segment which the next nat block is in has only one different
bit than the current one, so to get the next nat address, we can simply
alter that one bit.

Signed-off-by: Fan Li 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: guard macro variables with braces

2017-04-11T02:48:10+00:00

Add braces around variables used within macros for those make sense
to do it. Many of the macros in f2fs already do this. What this commit
doesn't do is anything that changes line# as a result of adding braces,
which usually affects the binary via __LINE__.

Confirmed no diff in fs/f2fs/f2fs.ko before/after this commit on x86_64,
to make sure this has no functional change as well as there's been no
unexpected side effect due to callers' arithmetics within the existing
code.

Signed-off-by: Tomohiro Kusumi 
Signed-off-by: Jaegeuk Kim

f2fs: adjust the way of calculating nat block

2017-03-22T02:34:27+00:00

use a slightly simpler expression to calculate nat block with nid.

Signed-off-by: Fan Li 
Signed-off-by: Jaegeuk Kim

f2fs: new helper cur_cp_crc() getting crc in f2fs_checkpoint

2017-02-27T18:07:47+00:00

There are four places that getting the crc value in f2fs_checkpoint,
just add a new helper cur_cp_crc for them.

Signed-off-by: Kinglong Mee 
Signed-off-by: Jaegeuk Kim

f2fs: remove unsafe bitmap checking

2017-02-27T17:59:51+00:00

proc A:                      proc B:
- writeback_sb_inodes
- __writeback_single_inode
- do_writepages
- f2fs_write_node_pages
- f2fs_balance_fs_bg         - write_checkpoint
- build_free_nids            - flush_nat_entries
- __build_free_nids          - __flush_nat_entry_set
- ra_meta_pages              - get_next_nat_page
- current_nat_addr           - set_to_next_nat
[do nat_bitmap checking]     - f2fs_change_bit

For proc A, nat_bitmap and nat_bitmap_mir would be compared without lock_op and
nm_i->nat_tree_lock, while proc B is changing nat_bitmap/nat_bitmap_ver in cp.

So it is normal for nat_bitmap/nat_bitmap diffrence under such scenario.

This patch fix this by removing the monitoring point.

[Fix: 599a09b f2fs: check in-memory nat version bitmap]
Signed-off-by: Hou Pengyang 
Signed-off-by: Jaegeuk Kim

f2fs: change recovery policy of xattr node block

2017-02-23T18:10:52+00:00

Currently, if we call fsync after updating the xattr date belongs to the
file, f2fs needs to trigger checkpoint to keep xattr data consistent. But,
this policy cause low performance as checkpoint will block most foreground
operations and cause unneeded and unrelated IOs around checkpoint.

This patch will reuse regular file recovery policy for xattr node block,
so, we change to write xattr node block tagged with fsync flag to warm
area instead of cold area, and during recovery, we search warm node chain
for fsynced xattr block, and do the recovery.

So, for below application IO pattern, performance can be improved
obviously:
- touch file
- create/update/delete xattr entry in file
- fsync file

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: check in-memory nat version bitmap

2017-02-23T02:48:49+00:00

This patch adds a mirror for nat version bitmap, and use it to detect
in-memory bitmap corruption which may be caused by bit-transition of
cache or memory overflow.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: clean up with list_{first, last}_entry

2017-02-23T02:48:47+00:00

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: split free nid list

2016-11-23T20:11:00+00:00

During free nid allocation, in order to do preallocation, we will tag free
nid entry as allocated one and still leave it in free nid list, for other
allocators who want to grab free nids, it needs to traverse the free nid
list for lookup. It becomes overhead in scenario of allocating free nid
intensively by multithreads.

This patch splits free nid list to two list: {free,alloc}_nid_list, to
keep free nids and preallocated free nids separately, after that, traverse
latency will be gone, besides split nid_cnt for separate statistic.

Additionally, introduce __insert_nid_to_list and __remove_nid_from_list for
cleanup.

Signed-off-by: Chao Yu 
[Jaegeuk Kim: modify f2fs_bug_on to avoid needless branches]
Signed-off-by: Jaegeuk Kim

f2fs: fix sparse warnings

2016-11-23T20:10:57+00:00

f2fs contained a number of endianness conversion bugs.

Also, one function should have been 'static'.

Found with sparse by running 'make C=2 CF=-D__CHECK_ENDIAN__ fs/f2fs/'

Signed-off-by: Eric Biggers 
Signed-off-by: Jaegeuk Kim