linux.git/fs/f2fs/node.c, branch v6.16

f2fs: Fix __write_node_folio() conversion

2025-06-10T14:52:21+00:00

This conversion moved the folio_unlock() to inside __write_node_folio(),
but missed one caller so we had a double-unlock on this path.

Cc: Christoph Hellwig 
Cc: Chao Yu 
Cc: Jaegeuk Kim 
Reported-by: syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com
Fixes: 80f31d2a7e5f (f2fs: return bool from __write_node_folio)
Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: introduce is_{meta,node}_folio

2025-05-28T16:03:26+00:00

Just cleanup, no changes.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add f2fs_bug_on() to detect potential bug

2025-05-27T23:52:35+00:00

Add f2fs_bug_on() to check whether memory preallocation will fail or
not after radix_tree_preload(GFP_NOFS | __GFP_NOFAIL).

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: return bool from __write_node_folio

2025-05-08T15:23:46+00:00

__write_node_folio can only return 0 or AOP_WRITEPAGE_ACTIVATE.
As part of phasing out AOP_WRITEPAGE_ACTIVATE, switch to a bool return
instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: simplify return value handling in f2fs_fsync_node_pages

2025-05-08T15:23:31+00:00

Always assign ret where the error happens, and jump to out instead
of multiple loop exit conditions to prepare for changes in the
__write_node_folio calling convention.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove wbc->for_reclaim handling

2025-05-08T15:22:45+00:00

Since commits 7ff0104a8052 ("f2fs: Remove f2fs_write_node_page()") and
3b47398d9861 ("f2fs: Remove f2fs_write_meta_page()'), f2fs can't be
called from reclaim context any more.  Remove all code keyed of the
wbc->for_reclaim flag, which is now only set for writing out swap or
shmem pages inside the swap code, but never passed to file systems.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to return correct error number in f2fs_sync_node_pages()

2025-05-08T15:21:58+00:00

If __write_node_folio() failed, it will return AOP_WRITEPAGE_ACTIVATE,
the incorrect return value may be passed to userspace in below path,
fix it.

- sync_filesystem
 - sync_fs
  - f2fs_issue_checkpoint
   - block_operations
    - f2fs_sync_node_pages
     - __write_node_folio
     : return AOP_WRITEPAGE_ACTIVATE

Cc: stable@vger.kernel.org
Reported-by: Christoph Hellwig 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Convert clear_node_page_dirty() to clear_node_folio_dirty()

2025-04-28T15:26:48+00:00

Both callers have a folio so pass it in, removing five calls to
compound_head().

Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Use a folio in flush_inline_data()

2025-04-28T15:26:47+00:00

Get a folio from the page cache and use it throughout.  Removes
six calls to compound_head().

Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Remove f2fs_new_node_page()

2025-04-28T15:26:47+00:00

All callers now use f2fs_new_node_folio().

Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim