linux.git/fs/f2fs/node.c, branch v5.9-rc2

f2fs: space related cleanup

2020-07-26T15:15:40+00:00

Just for code style, no logic change
1. delete useless space
2. change spaces into tab

Signed-off-by: Jack Qiu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Change the type of f2fs_flush_inline_data() to void

2020-07-24T03:22:37+00:00

The return value of f2fs_flush_inline_data() is not used,
so delete it.

Signed-off-by: Jia Yang 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: should avoid inode eviction in synchronous path

2020-07-21T19:55:54+00:00

https://bugzilla.kernel.org/show_bug.cgi?id=208565

PID: 257    TASK: ecdd0000  CPU: 0   COMMAND: "init"
  #0 [] (__schedule) from []
  #1 [] (schedule) from []
  #2 [] (rwsem_down_read_failed) from []
  #3 [] (down_read) from []
  #4 [] (f2fs_truncate_blocks) from []
  #5 [] (f2fs_truncate) from []
  #6 [] (f2fs_evict_inode) from []
  #7 [] (evict) from []
  #8 [] (iput) from []
  #9 [] (f2fs_sync_node_pages) from []
 #10 [] (f2fs_write_checkpoint) from []
 #11 [] (f2fs_sync_fs) from []
 #12 [] (f2fs_do_sync_file) from []
 #13 [] (f2fs_sync_file) from []
 #14 [] (vfs_fsync_range) from []
 #15 [] (do_fsync) from []
 #16 [] (sys_fsync) from []

This can be caused by flush_dirty_inode() in f2fs_sync_node_pages() where
iput() requires f2fs_lock_op() again resulting in livelock.

Reported-by: Zhiguo Niu 
Signed-off-by: Jaegeuk Kim

f2fs: fix error path in do_recover_data()

2020-07-08T17:11:19+00:00

- don't panic kernel if f2fs_get_node_page() fails in
f2fs_recover_inline_data() or f2fs_recover_inline_xattr();
- return error number of f2fs_truncate_blocks() to
f2fs_recover_inline_data()'s caller;

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: lost matching-pair of trace in f2fs_truncate_inode_blocks

2020-07-08T04:51:47+00:00

if get_node_path() return -E2BIG and trace of
f2fs_truncate_inode_blocks_enter/exit enabled
then the matching-pair of trace_exit will lost
in log.

Signed-off-by: Yubo Feng 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove useless parameter of __insert_free_nid()

2020-07-08T04:51:45+00:00

In current version, @state will only be FREE_NID. This parameter
has no real effect so remove it to keep clean.

Signed-off-by: Liu Song 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: don't return vmalloc() memory from f2fs_kmalloc()

2020-06-09T03:34:58+00:00

kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either
kmalloc'ed or vmalloc'ed memory.  But the f2fs wrappers, f2fs_kmalloc()
and f2fs_kvmalloc(), both return both kinds of memory.

It's redundant to have two functions that do the same thing, and also
breaking the standard naming convention is causing bugs since people
assume it's safe to kfree() memory allocated by f2fs_kmalloc().  See
e.g. the various allocations in fs/f2fs/compress.c.

Fix this by making f2fs_kmalloc() just use kmalloc().  And to avoid
re-introducing the allocation failures that the vmalloc fallback was
intended to fix, convert the largest allocations to use f2fs_kvmalloc().

Signed-off-by: Eric Biggers 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25T03:54:34+00:00

Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages
in an inifinite loop. Let's drop dirty pages at umount in that case.

Signed-off-by: Jaegeuk Kim

f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-12T03:36:47+00:00

There could be a scenario where f2fs_sync_node_pages gets
called during checkpoint, which in turn tries to flush
inline data and calls iput(). This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the
beginning by checkpoint->block_operations().

Call stack :

Thread A		Thread B
f2fs_write_checkpoint()
- block_operations(sbi)
 - f2fs_lock_all(sbi);
  - down_write(&sbi->cp_rwsem);

                        - open()
                         - igrab()
                        - write() write inline data
                        - unlink()
- f2fs_sync_node_pages()
 - if (is_inline_node(page))
  - flush_inline_data()
   - ilookup()
     page = f2fs_pagecache_get_page()
     if (!page)
      goto iput_out;
     iput_out:
			-close()
			-iput()
       iput(inode);
       - f2fs_evict_inode()
        - f2fs_truncate_blocks()
         - f2fs_lock_op()
           - down_read(&sbi->cp_rwsem);

Fixes: 2049d4fcb057 ("f2fs: avoid multiple node page writes due to inline_data")
Signed-off-by: Sayali Lokhande 
Signed-off-by: Jaegeuk Kim

f2fs: shrink spinlock coverage

2020-05-12T03:36:46+00:00

In f2fs_try_to_free_nids(), .nid_list_lock spinlock critical region will
increase as expected shrink number increase, to avoid spining other CPUs
for long time, we change to release nid caches with small batch each time
under .nid_list_lock coverage.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim