linux.git/fs/f2fs/node.c, branch v5.10

f2fs: handle errors of f2fs_get_meta_page_nofail

2020-10-14T06:23:29+00:00

First problem is we hit BUG_ON() in f2fs_get_sum_page given EIO on
f2fs_get_meta_page_nofail().

Quick fix was not to give any error with infinite loop, but syzbot caught
a case where it goes to that loop from fuzzed image. In turned out we abused
f2fs_get_meta_page_nofail() like in the below call stack.

- f2fs_fill_super
 - f2fs_build_segment_manager
  - build_sit_entries
   - get_current_sit_page

INFO: task syz-executor178:6870 can't die for more than 143 seconds.
task:syz-executor178 state:R
 stack:26960 pid: 6870 ppid:  6869 flags:0x00004006
Call Trace:

Showing all locks held in the system:
1 lock held by khungtaskd/1179:
 #0: ffffffff8a554da0 (rcu_read_lock){....}-{1:2}, at: debug_show_all_locks+0x53/0x260 kernel/locking/lockdep.c:6242
1 lock held by systemd-journal/3920:
1 lock held by in:imklog/6769:
 #0: ffff88809eebc130 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xe9/0x100 fs/file.c:930
1 lock held by syz-executor178/6870:
 #0: ffff8880925120e0 (&type->s_umount_key#47/1){+.+.}-{3:3}, at: alloc_super+0x201/0xaf0 fs/super.c:229

Actually, we didn't have to use _nofail in this case, since we could return
error to mount(2) already with the error handler.

As a result, this patch tries to 1) remove _nofail callers as much as possible,
2) deal with error case in last remaining caller, f2fs_get_sum_page().

Reported-by: syzbot+ee250ac8137be41d7b13@syzkaller.appspotmail.com
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: remove unused check on version_bitmap

2020-09-29T08:48:33+00:00

A NULL will not be return by __bitmap_ptr here.
Remove the unused check.

Signed-off-by: Wang Xiaojun 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: clean up kvfree

2020-09-14T18:15:37+00:00

After commit 0b6d4ca04a86 ("f2fs: don't return vmalloc() memory from
f2fs_kmalloc()"), f2fs_k{m,z}alloc() will not return vmalloc()'ed
memory, so clean up to use kfree() instead of kvfree() to free
vmalloc()'ed memory.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix indefinite loop scanning for free nid

2020-09-09T03:31:33+00:00

If the sbi->ckpt->next_free_nid is not NAT block aligned and if there
are free nids in that NAT block between the start of the block and
next_free_nid, then those free nids will not be scanned in scan_nat_page().
This results into mismatch between nm_i->available_nids and the sum of
nm_i->free_nid_count of all NAT blocks scanned. And nm_i->available_nids
will always be greater than the sum of free nids in all the blocks.
Under this condition, if we use all the currently scanned free nids,
then it will loop forever in f2fs_alloc_nid() as nm_i->available_nids
is still not zero but nm_i->free_nid_count of that partially scanned
NAT block is zero.

Fix this to align the nm_i->next_scan_nid to the first nid of the
corresponding NAT block.

Signed-off-by: Sahitya Tummala 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

f2fs: space related cleanup

2020-07-26T15:15:40+00:00

Just for code style, no logic change
1. delete useless space
2. change spaces into tab

Signed-off-by: Jack Qiu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: Change the type of f2fs_flush_inline_data() to void

2020-07-24T03:22:37+00:00

The return value of f2fs_flush_inline_data() is not used,
so delete it.

Signed-off-by: Jia Yang 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: should avoid inode eviction in synchronous path

2020-07-21T19:55:54+00:00

https://bugzilla.kernel.org/show_bug.cgi?id=208565

PID: 257    TASK: ecdd0000  CPU: 0   COMMAND: "init"
  #0 [] (__schedule) from []
  #1 [] (schedule) from []
  #2 [] (rwsem_down_read_failed) from []
  #3 [] (down_read) from []
  #4 [] (f2fs_truncate_blocks) from []
  #5 [] (f2fs_truncate) from []
  #6 [] (f2fs_evict_inode) from []
  #7 [] (evict) from []
  #8 [] (iput) from []
  #9 [] (f2fs_sync_node_pages) from []
 #10 [] (f2fs_write_checkpoint) from []
 #11 [] (f2fs_sync_fs) from []
 #12 [] (f2fs_do_sync_file) from []
 #13 [] (f2fs_sync_file) from []
 #14 [] (vfs_fsync_range) from []
 #15 [] (do_fsync) from []
 #16 [] (sys_fsync) from []

This can be caused by flush_dirty_inode() in f2fs_sync_node_pages() where
iput() requires f2fs_lock_op() again resulting in livelock.

Reported-by: Zhiguo Niu 
Signed-off-by: Jaegeuk Kim

f2fs: fix error path in do_recover_data()

2020-07-08T17:11:19+00:00

- don't panic kernel if f2fs_get_node_page() fails in
f2fs_recover_inline_data() or f2fs_recover_inline_xattr();
- return error number of f2fs_truncate_blocks() to
f2fs_recover_inline_data()'s caller;

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: lost matching-pair of trace in f2fs_truncate_inode_blocks

2020-07-08T04:51:47+00:00

if get_node_path() return -E2BIG and trace of
f2fs_truncate_inode_blocks_enter/exit enabled
then the matching-pair of trace_exit will lost
in log.

Signed-off-by: Yubo Feng 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim