<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/fs/f2fs/dir.c, branch v3.19</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>f2fs: introduce f2fs_dentry_kunmap to clean up</title>
<updated>2014-11-24T05:51:53+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-11-22T00:36:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=9486ba442b00a6b227bfe0d66b0f4dbcd1a2ee91'/>
<id>9486ba442b00a6b227bfe0d66b0f4dbcd1a2ee91</id>
<content type='text'>
This patch introduces f2fs_dentry_kunmap to clean up dirty codes.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch introduces f2fs_dentry_kunmap to clean up dirty codes.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: remove pointless bit testing in f2fs_delete_entry()</title>
<updated>2014-11-04T00:07:38+00:00</updated>
<author>
<name>Jan Kara</name>
<email>jack@suse.cz</email>
</author>
<published>2014-10-23T12:40:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=1f7732fe6cc0c37befc74cef1d289cd2272b7a5c'/>
<id>1f7732fe6cc0c37befc74cef1d289cd2272b7a5c</id>
<content type='text'>
There's no point in using test_and_clear_bit_le() when we don't use the
return value of the function. Just use clear_bit_le() instead.

Coverity-id: 1016434
Signed-off-by: Jan Kara &lt;jack@suse.cz&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There's no point in using test_and_clear_bit_le() when we don't use the
return value of the function. Just use clear_bit_le() instead.

Coverity-id: 1016434
Signed-off-by: Jan Kara &lt;jack@suse.cz&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: reuse make_empty_dir code for inline_dentry</title>
<updated>2014-11-04T00:07:34+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-19T06:06:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=062a3e7ba7eebcd7d44e49e9510135f901f93f48'/>
<id>062a3e7ba7eebcd7d44e49e9510135f901f93f48</id>
<content type='text'>
This patch introduces do_make_empty_dir to mitigate code redundancy
for inline_dentry.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch introduces do_make_empty_dir to mitigate code redundancy
for inline_dentry.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: introduce f2fs_dentry_ptr structure for code clean-up</title>
<updated>2014-11-04T00:07:34+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-19T05:52:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=7b3cd7d6f026784b1a2a74b6e207b26253d9d780'/>
<id>7b3cd7d6f026784b1a2a74b6e207b26253d9d780</id>
<content type='text'>
This patch introduces f2fs_dentry_ptr structure for the use of a function
parameter in inline_dentry operations.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch introduces f2fs_dentry_ptr structure for the use of a function
parameter in inline_dentry operations.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: reuse core function in f2fs_readdir for inline_dentry</title>
<updated>2014-11-04T00:07:34+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-16T04:29:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=38594de767b32db62b7213631772d050690d3803'/>
<id>38594de767b32db62b7213631772d050690d3803</id>
<content type='text'>
This patch introduces a core function, f2fs_fill_dentries, to remove
redundant code in f2fs_readdir and f2fs_read_inline_dir.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch introduces a core function, f2fs_fill_dentries, to remove
redundant code in f2fs_readdir and f2fs_read_inline_dir.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: avoid deadlock on init_inode_metadata</title>
<updated>2014-11-04T00:07:33+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-14T02:42:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=bce8d1120707c06088928b2ee52a58703d74ac29'/>
<id>bce8d1120707c06088928b2ee52a58703d74ac29</id>
<content type='text'>
Previously, init_inode_metadata does not hold any parent directory's inode
page. So, f2fs_init_acl can grab its parent inode page without any problem.
But, when we use inline_dentry, that page is grabbed during f2fs_add_link,
so that we can fall into deadlock condition like below.

INFO: task mknod:11006 blocked for more than 120 seconds.
      Tainted: G           OE  3.17.0-rc1+ #13
"echo 0 &gt; /proc/sys/kernel/hung_task_timeout_secs" disables this message.
mknod           D ffff88003fc94580     0 11006  11004 0x00000000
 ffff880007717b10 0000000000000002 ffff88003c323220 ffff880007717fd8
 0000000000014580 0000000000014580 ffff88003daecb30 ffff88003c323220
 ffff88003fc94e80 ffff88003ffbb4e8 ffff880007717ba0 0000000000000002
Call Trace:
 [&lt;ffffffff8173dc40&gt;] ? bit_wait+0x50/0x50
 [&lt;ffffffff8173d4cd&gt;] io_schedule+0x9d/0x130
 [&lt;ffffffff8173dc6c&gt;] bit_wait_io+0x2c/0x50
 [&lt;ffffffff8173da3b&gt;] __wait_on_bit_lock+0x4b/0xb0
 [&lt;ffffffff811640a7&gt;] __lock_page+0x67/0x70
 [&lt;ffffffff810acf50&gt;] ? autoremove_wake_function+0x40/0x40
 [&lt;ffffffff811652cc&gt;] pagecache_get_page+0x14c/0x1e0
 [&lt;ffffffffa029afa9&gt;] get_node_page+0x59/0x130 [f2fs]
 [&lt;ffffffffa02a63ad&gt;] read_all_xattrs+0x24d/0x430 [f2fs]
 [&lt;ffffffffa02a6ca2&gt;] f2fs_getxattr+0x52/0xe0 [f2fs]
 [&lt;ffffffffa02a7481&gt;] f2fs_get_acl+0x41/0x2d0 [f2fs]
 [&lt;ffffffff8122d847&gt;] get_acl+0x47/0x70
 [&lt;ffffffff8122db5a&gt;] posix_acl_create+0x5a/0x150
 [&lt;ffffffffa02a7759&gt;] f2fs_init_acl+0x29/0xcb [f2fs]
 [&lt;ffffffffa0286a8d&gt;] init_inode_metadata+0x5d/0x340 [f2fs]
 [&lt;ffffffffa029253a&gt;] f2fs_add_inline_entry+0x12a/0x2e0 [f2fs]
 [&lt;ffffffffa0286ea5&gt;] __f2fs_add_link+0x45/0x4a0 [f2fs]
 [&lt;ffffffffa028b5b6&gt;] ? f2fs_new_inode+0x146/0x220 [f2fs]
 [&lt;ffffffffa028b816&gt;] f2fs_mknod+0x86/0xf0 [f2fs]
 [&lt;ffffffff811e3ec1&gt;] vfs_mknod+0xe1/0x160
 [&lt;ffffffff811e4b26&gt;] SyS_mknod+0x1f6/0x200
 [&lt;ffffffff81741d7f&gt;] tracesys+0xe1/0xe6

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, init_inode_metadata does not hold any parent directory's inode
page. So, f2fs_init_acl can grab its parent inode page without any problem.
But, when we use inline_dentry, that page is grabbed during f2fs_add_link,
so that we can fall into deadlock condition like below.

INFO: task mknod:11006 blocked for more than 120 seconds.
      Tainted: G           OE  3.17.0-rc1+ #13
"echo 0 &gt; /proc/sys/kernel/hung_task_timeout_secs" disables this message.
mknod           D ffff88003fc94580     0 11006  11004 0x00000000
 ffff880007717b10 0000000000000002 ffff88003c323220 ffff880007717fd8
 0000000000014580 0000000000014580 ffff88003daecb30 ffff88003c323220
 ffff88003fc94e80 ffff88003ffbb4e8 ffff880007717ba0 0000000000000002
Call Trace:
 [&lt;ffffffff8173dc40&gt;] ? bit_wait+0x50/0x50
 [&lt;ffffffff8173d4cd&gt;] io_schedule+0x9d/0x130
 [&lt;ffffffff8173dc6c&gt;] bit_wait_io+0x2c/0x50
 [&lt;ffffffff8173da3b&gt;] __wait_on_bit_lock+0x4b/0xb0
 [&lt;ffffffff811640a7&gt;] __lock_page+0x67/0x70
 [&lt;ffffffff810acf50&gt;] ? autoremove_wake_function+0x40/0x40
 [&lt;ffffffff811652cc&gt;] pagecache_get_page+0x14c/0x1e0
 [&lt;ffffffffa029afa9&gt;] get_node_page+0x59/0x130 [f2fs]
 [&lt;ffffffffa02a63ad&gt;] read_all_xattrs+0x24d/0x430 [f2fs]
 [&lt;ffffffffa02a6ca2&gt;] f2fs_getxattr+0x52/0xe0 [f2fs]
 [&lt;ffffffffa02a7481&gt;] f2fs_get_acl+0x41/0x2d0 [f2fs]
 [&lt;ffffffff8122d847&gt;] get_acl+0x47/0x70
 [&lt;ffffffff8122db5a&gt;] posix_acl_create+0x5a/0x150
 [&lt;ffffffffa02a7759&gt;] f2fs_init_acl+0x29/0xcb [f2fs]
 [&lt;ffffffffa0286a8d&gt;] init_inode_metadata+0x5d/0x340 [f2fs]
 [&lt;ffffffffa029253a&gt;] f2fs_add_inline_entry+0x12a/0x2e0 [f2fs]
 [&lt;ffffffffa0286ea5&gt;] __f2fs_add_link+0x45/0x4a0 [f2fs]
 [&lt;ffffffffa028b5b6&gt;] ? f2fs_new_inode+0x146/0x220 [f2fs]
 [&lt;ffffffffa028b816&gt;] f2fs_mknod+0x86/0xf0 [f2fs]
 [&lt;ffffffff811e3ec1&gt;] vfs_mknod+0xe1/0x160
 [&lt;ffffffff811e4b26&gt;] SyS_mknod+0x1f6/0x200
 [&lt;ffffffff81741d7f&gt;] tracesys+0xe1/0xe6

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: fix to wait correct block type</title>
<updated>2014-11-04T00:07:33+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-14T02:34:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=59a0615540812297e4ff9673de5c1269413d0c40'/>
<id>59a0615540812297e4ff9673de5c1269413d0c40</id>
<content type='text'>
The inode page needs to wait NODE block io.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The inode page needs to wait NODE block io.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: reuse find_in_block code for find_in_inline_dir</title>
<updated>2014-11-04T00:07:32+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-14T00:26:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=4e6ebf6d493591403237400e94e6fc17b7cb1c62'/>
<id>4e6ebf6d493591403237400e94e6fc17b7cb1c62</id>
<content type='text'>
This patch removes redundant copied code in find_in_inline_dir.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch removes redundant copied code in find_in_inline_dir.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: reuse room_for_filename for inline dentry operation</title>
<updated>2014-11-04T00:07:32+00:00</updated>
<author>
<name>Jaegeuk Kim</name>
<email>jaegeuk@kernel.org</email>
</author>
<published>2014-10-13T23:28:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=a82afa20197a2ed289dd8fd18208a9e8b9af0130'/>
<id>a82afa20197a2ed289dd8fd18208a9e8b9af0130</id>
<content type='text'>
This patch introduces to reuse the existing room_for_filename for inline dentry
operation.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch introduces to reuse the existing room_for_filename for inline dentry
operation.

Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>f2fs: enable inline dir handling</title>
<updated>2014-11-04T00:07:32+00:00</updated>
<author>
<name>Chao Yu</name>
<email>chao2.yu@samsung.com</email>
</author>
<published>2014-09-24T10:19:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=622f28ae9ba4fa89b4ff0f4a6cf75d153ea838ce'/>
<id>622f28ae9ba4fa89b4ff0f4a6cf75d153ea838ce</id>
<content type='text'>
Add inline dir functions into normal dir ops' function to handle inline ops.
Besides, we enable inline dir mode when a new dir inode is created if
inline_data option is on.

Signed-off-by: Chao Yu &lt;chao2.yu@samsung.com&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add inline dir functions into normal dir ops' function to handle inline ops.
Besides, we enable inline dir mode when a new dir inode is created if
inline_data option is on.

Signed-off-by: Chao Yu &lt;chao2.yu@samsung.com&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
