linux.git/fs/f2fs/dir.c, branch v3.17

f2fs: avoid double lock in truncate_blocks

2014-08-21T20:57:01+00:00

The init_inode_metadata calls truncate_blocks when error is occurred.
The callers holds f2fs_lock_op, so we should not call it again in
truncate_blocks.

Signed-off-by: Jaegeuk Kim

f2fs: fix typo

2014-08-19T17:01:33+00:00

Fix typo and some grammatical errors.

The words "filesystem" and "readahead" are being used without the space treewide.

Signed-off-by: Park Ju Hyung 
Signed-off-by: Jaegeuk Kim

f2fs: check name_len of dir entry to prevent from deadloop

2014-07-11T00:00:02+00:00

We assume that modification of some special application could result in zeroed
name_len, or it is consciously made by somebody. We will deadloop in
find_in_block when name_len of dir entry is zero.

This patch is added for preventing deadloop in above scenario.

change log from v1:
 o use f2fs_bug_on rather than break out from searching dir entry suggested by
Jaegeuk Kim.

Jaegeuk describe:
"Well, IMO, it would be good to add f2fs_bug_on() here with a specific comment.
In the current phase of f2fs, it is more important to investigate the file
system bugs, rather than workarounds for any corrupted images.
And, definitely it needs to stop the kernel if any corrupted image was mounted,
so that we can figure out where the bugs are occurred."

Suggested-by: Jaegeuk Kim 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: arguments cleanup of finding file flow functions

2014-07-09T21:04:26+00:00

Signed-off-by: Gu Zheng 
Signed-off-by: Jaegeuk Kim

f2fs: remove the needless point-cast

2014-07-09T21:04:26+00:00

Signed-off-by: Gu Zheng 
Signed-off-by: Jaegeuk Kim

f2fs: clean up an unused parameter and assignment

2014-07-09T21:04:25+00:00

This patch cleans up simple unnecessary codes.

Signed-off-by: Jaegeuk Kim

f2fs: introduce f2fs_do_tmpfile for code consistency

2014-07-09T21:04:24+00:00

This patch adds f2fs_do_tmpfile to eliminate the redundant init_inode_metadata
flow.
Throught this, we can provide the consistent lock usage, e.g., fi->i_sem,  and
this will enable better debugging stuffs.

Signed-off-by: Jaegeuk Kim

f2fs: support ->tmpfile()

2014-07-09T21:04:24+00:00

Add function f2fs_tmpfile() to support O_TMPFILE file creation, and modify logic
of init_inode_metadata to enable linkat temp file.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix error path in init_inode_metadata

2014-07-09T12:58:50+00:00

If we fail in this path:
->init_inode_metadata
  ->make_empty_dir
    ->get_new_data_page
      ->grab_cache_page return -ENOMEM

We will bug on in error path of init_inode_metadata when call remove_inode_page
because i_block = 2 (one inode block will be released later & one dentry block).

We should release the dentry block in init_inode_metadata to avoid this BUG_ON,
and avoid leak of dentry block resource, because we never have second chance to
release that block in ->evict_inode as in upper error path we make this inode
'bad'.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: avoid overflow when large directory feathure is enabled

2014-06-04T04:34:30+00:00

When large directory feathure is enable, We have one case which could cause
overflow in dir_buckets() as following:
special case: level + dir_level >= 32 and level < MAX_DIR_HASH_DEPTH / 2.

Here we define MAX_DIR_BUCKETS to limit the return value when the condition
could trigger potential overflow.

Changes from V1
 o modify description of calculation in f2fs.txt suggested by Changman Lee.

Suggested-by: Changman Lee 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim