linux.git/fs/f2fs/dir.c, branch v3.14

f2fs: move a branch for code redability

2014-01-22T09:41:07+00:00

This patch moves a function in f2fs_delete_entry for code readability.

Signed-off-by: Jaegeuk Kim

f2fs: call mark_inode_dirty to flush dirty pages

2014-01-22T09:40:34+00:00

If a dentry page is updated, we should call mark_inode_dirty to add the inode
into the dirty list, so that its dentry pages are flushed to the disk.
Otherwise, the inode can be evicted without flush.

Signed-off-by: Jaegeuk Kim

f2fs: clean checkpatch warnings

2014-01-20T01:27:12+00:00

Fixed a variety of trivial checkpatch warnings.  The only delta should
be some minor formatting on log strings that were split / too long.

Signed-off-by: Chris Fries 
Signed-off-by: Jaegeuk Kim

f2fs: handle errors correctly during f2fs_reserve_block

2014-01-06T07:42:21+00:00

The get_dnode_of_data nullifies inode and node page when error is occurred.

There are two cases that passes inode page into get_dnode_of_data().

1. make_empty_dir()
    -> get_new_data_page()
      -> f2fs_reserve_block(ipage)
	-> get_dnode_of_data()

2. f2fs_convert_inline_data()
    -> __f2fs_convert_inline_data()
      -> f2fs_reserve_block(ipage)
	-> get_dnode_of_data()

This patch adds correct error handling codes when get_dnode_of_data() returns
an error.

At first, f2fs_reserve_block() calls f2fs_put_dnode() whenever reserve_new_block
returns an error.
So, the rule of f2fs_reserve_block() is to nullify inode page when there is any
error internally.

Finally, two callers of f2fs_reserve_block() should call f2fs_put_dnode()
appropriately if they got an error since successful f2fs_reserve_block().

Signed-off-by: Jaegeuk Kim

f2fs: introduce F2FS_INODE macro to get f2fs_inode

2013-12-26T11:32:48+00:00

This patch introduces F2FS_INODE that returns struct f2fs_inode * from the inode
page.
By using this macro, we can remove unnecessary casting codes like below.

   struct f2fs_inode *ri = &F2FS_NODE(inode_page)->i;
-> struct f2fs_inode *ri = F2FS_INODE(inode_page);

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: check filename length in recover_dentry

2013-12-26T03:50:09+00:00

In current flow, we will get Null return value of f2fs_find_entry in
recover_dentry when name.len is bigger than F2FS_NAME_LEN, and then we
still add this inode into its dir entry.
To avoid this situation, we must check filename length before we use it.

Another point is that we could remove the code of checking filename length
In f2fs_find_entry, because f2fs_lookup will be called previously to ensure of
validity of filename length.

V2:
 o add WARN_ON() as Jaegeuk Kim suggested.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: avoid to set wrong pino of inode when rename dir

2013-12-23T01:42:51+00:00

When we rename a dir to new name which is not exist previous,
we will set pino of parent inode with ino of child inode in f2fs_set_link.
It destroy consistency of pino, it should be fixed.

Thanks for previous work of Shu Tan.

Signed-off-by: Shu Tan 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: update several comments

2013-12-23T01:26:03+00:00

Update several comments:
1. use f2fs_{un}lock_op install of mutex_{un}lock_op.
2. update comment of get_data_block().
3. update description of node offset.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add unlikely() macro for compiler optimization

2013-12-23T01:18:06+00:00

As we know, some of our branch condition will rarely be true. So we could add
'unlikely' to let compiler optimize these code, by this way we could drop
unneeded 'jump' assemble code to improve performance.

change log:
 o add *unlikely* as many as possible across the whole source files at once
   suggested by Jaegeuk Kim.

Suggested-by: Jaegeuk Kim 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add an option to avoid unnecessary BUG_ONs

2013-10-29T06:44:38+00:00

If you want to remove unnecessary BUG_ONs, you can just turn off F2FS_CHECK_FS
in your kernel config.

Signed-off-by: Jaegeuk Kim