linux.git/fs/f2fs/data.c, branch v5.7

f2fs: fix to use f2fs_readpage_limit() in f2fs_read_multi_pages()

2020-03-31T03:46:25+00:00

Multipage read flow should consider fsverity, so it needs to use
f2fs_readpage_limit() instead of i_size_read() to check EOF condition.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to avoid double unlock

2020-03-31T03:46:25+00:00

On image that has verity and compression feature, if compressed pages
and non-compressed pages are mixed in one bio, we may double unlock
non-compressed page in below flow:

- f2fs_post_read_work
 - f2fs_decompress_work
  - f2fs_decompress_bio
   - __read_end_io
    - unlock_page
 - fsverity_enqueue_verify_work
  - f2fs_verity_work
   - f2fs_verify_bio
    - unlock_page

So it should skip handling non-compressed page in f2fs_decompress_work()
if verity is on.

Besides, add missing dec_page_count() in f2fs_verify_bio().

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix NULL pointer dereference in f2fs_verity_work()

2020-03-31T03:46:25+00:00

If both compression and fsverity feature is on, generic/572 will
report below NULL pointer dereference bug.

 BUG: kernel NULL pointer dereference, address: 0000000000000018
 RIP: 0010:f2fs_verity_work+0x60/0x90 [f2fs]
 #PF: supervisor read access in kernel mode
 Workqueue: fsverity_read_queue f2fs_verity_work [f2fs]
 RIP: 0010:f2fs_verity_work+0x60/0x90 [f2fs]
 Call Trace:
  process_one_work+0x16c/0x3f0
  worker_thread+0x4c/0x440
  ? rescuer_thread+0x350/0x350
  kthread+0xf8/0x130
  ? kthread_unpark+0x70/0x70
  ret_from_fork+0x35/0x40

There are two issue in f2fs_verity_work():
- it needs to traverse and verify all pages in bio.
- if pages in bio belong to non-compressed cluster, accessing
decompress IO context stored in page private will cause NULL
pointer dereference.

Fix them.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to avoid potential deadlock

2020-03-31T03:46:23+00:00

We should always check F2FS_I(inode)->cp_task condition in prior to other
conditions in __should_serialize_io() to avoid deadloop described in
commit 040d2bb318d1 ("f2fs: fix to avoid deadloop if data_flush is on"),
however we break this rule when we support compression, fix it.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: delete DIO read lock

2020-03-31T03:46:23+00:00

This lock can be a contention with multi 4k random read IO with single inode.

example) fio --output=test --name=test --numjobs=60 --filename=/media/samsung960pro/file_test --rw=randread --bs=4k
 --direct=1 --time_based --runtime=7 --ioengine=libaio --iodepth=256 --group_reporting --size=10G

With this commit, it remove that possible lock contention.

Signed-off-by: Dongjoo Seo 
Signed-off-by: Jaegeuk Kim

f2fs: avoid __GFP_NOFAIL in f2fs_bio_alloc

2020-03-19T18:41:26+00:00

__f2fs_bio_alloc() won't fail due to memory pool backend, remove unneeded
__GFP_NOFAIL flag in __f2fs_bio_alloc().

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to avoid triggering IO in write path

2020-03-19T18:41:26+00:00

If we are in write IO path, we need to avoid using GFP_KERNEL.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add prefix for f2fs slab cache name

2020-03-19T18:41:26+00:00

In order to avoid polluting global slab cache namespace.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: introduce DEFAULT_IO_TIMEOUT

2020-03-19T18:41:26+00:00

As Geert Uytterhoeven reported:

for parameter HZ/50 in congestion_wait(BLK_RW_ASYNC, HZ/50);

On some platforms, HZ can be less than 50, then unexpected 0 timeout
jiffies will be set in congestion_wait().

This patch introduces a macro DEFAULT_IO_TIMEOUT to wrap a determinate
value with msecs_to_jiffies(20) to instead HZ/50 to avoid such issue.

Quoted from Geert Uytterhoeven:

"A timeout of HZ means 1 second.
HZ/50 means 20 ms, but has the risk of being zero, if HZ < 50.

If you want to use a timeout of 20 ms, you best use msecs_to_jiffies(20),
as that takes care of the special cases, and never returns 0."

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: clean up lfs/adaptive mount option

2020-03-19T18:41:25+00:00

This patch removes F2FS_MOUNT_ADAPTIVE and F2FS_MOUNT_LFS mount options,
and add F2FS_OPTION.fs_mode with below two status to indicate filesystem
mode.

enum {
	FS_MODE_ADAPTIVE,	/* use both lfs/ssr allocation */
	FS_MODE_LFS,		/* use lfs allocation only */
};

It can enhance code readability and fs mode's scalability.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim