linux.git/fs/f2fs/acl.c, branch v5.2

f2fs: Replace spaces with tab

2019-05-09T04:23:11+00:00

Modify coding style
ERROR: code indent should use tabs where possible

Signed-off-by: Youngjun Yoo 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: insert space before the open parenthesis '('

2019-05-09T04:23:11+00:00

Modify coding style
ERROR: space required before the open parenthesis '('

Signed-off-by: Youngjun Yoo 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: use kvmalloc, if kmalloc is failed

2018-12-26T23:16:53+00:00

One report says memalloc failure during mount.

 (unwind_backtrace) from [] (show_stack+0x10/0x14)
 (show_stack) from [] (dump_stack+0x8c/0xa0)
 (dump_stack) from [] (warn_alloc+0xc4/0x160)
 (warn_alloc) from [] (__alloc_pages_nodemask+0x3f4/0x10d0)
 (__alloc_pages_nodemask) from [] (kmalloc_order_trace+0x2c/0x120)
 (kmalloc_order_trace) from [] (build_node_manager+0x35c/0x688)
 (build_node_manager) from [] (f2fs_fill_super+0xf0c/0x16cc)
 (f2fs_fill_super) from [] (mount_bdev+0x15c/0x188)
 (mount_bdev) from [] (f2fs_mount+0x18/0x20)
 (f2fs_mount) from [] (mount_fs+0x158/0x19c)
 (mount_fs) from [] (vfs_kern_mount+0x78/0x134)
 (vfs_kern_mount) from [] (do_mount+0x474/0xca4)
 (do_mount) from [] (SyS_mount+0x94/0xbc)
 (SyS_mount) from [] (ret_fast_syscall+0x0/0x48)

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix wrong return value of f2fs_acl_create

2018-11-26T23:54:37+00:00

When call f2fs_acl_create_masq() failed, the caller f2fs_acl_create()
should return -EIO instead of -ENOMEM, this patch makes it consistent
with posix_acl_create() which has been fixed in commit beaf226b863a
("posix_acl: don't ignore return value of posix_acl_create_masq()").

Fixes: 83dfe53c185e ("f2fs: fix reference leaks in f2fs_acl_create")
Signed-off-by: Tiezhu Yang 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add SPDX license identifiers

2018-09-12T20:07:10+00:00

Remove the verbose license text from f2fs files and replace them with
SPDX tags.  This does not change the license of any of the code.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: cache NULL when both default_acl and acl are NULL

2018-09-11T20:16:03+00:00

default_acl and acl of newly created inode will be initiated
as ACL_NOT_CACHED in vfs function inode_init_always() and later
will be updated by calling xxx_init_acl() in specific filesystems.
Howerver, when default_acl and acl are NULL then they keep the value
of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
in this case.

Signed-off-by: Chengguang Xu 
Acked-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: add additional sanity check in f2fs_acl_from_disk()

2018-09-05T20:40:31+00:00

Add additinal sanity check for irregular case(e.g. corruption).
If size of extended attribution is smaller than size of acl header,
then return -EINVAL.

Signed-off-by: Chengguang Xu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

posix_acl: convert posix_acl.a_refcount from atomic_t to refcount_t

2018-01-03T03:27:28+00:00

atomic_t variables are currently used to implement reference
counters with the following properties:
 - counter is initialized to 1 using atomic_set()
 - a resource is freed upon counter reaching zero
 - once counter reaches zero, its further
   increments aren't allowed
 - counter schema uses basic atomic operations
   (set, inc, inc_not_zero, dec_and_test, etc.)

Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.

The variable posix_acl.a_refcount is used as pure reference counter.
Convert it to refcount_t and fix up the operations.

**Important note for maintainers:

Some functions from refcount_t API defined in lib/refcount.c
have different memory ordering guarantees than their atomic
counterparts.
The full comparison can be seen in
https://lkml.org/lkml/2017/11/15/57 and it is hopefully soon
in state to be merged to the documentation tree.
Normally the differences should not matter since refcount_t provides
enough guarantees to satisfy the refcounting use cases, but in
some rare cases it might matter.
Please double check that you don't have some undocumented
memory guarantees for this variable usage.

For the posix_acl.a_refcount it might make a difference
in following places:
 - get_cached_acl(): increment in refcount_inc_not_zero() only
   guarantees control dependency on success vs. fully ordered
   atomic counterpart. However this operation is performed under
   rcu_read_lock(), so this should be fine.
 - posix_acl_release(): decrement in refcount_dec_and_test() only
   provides RELEASE ordering and control dependency on success
   vs. fully ordered atomic counterpart

Suggested-by: Kees Cook 
Reviewed-by: David Windsor 
Reviewed-by: Hans Liljestrand 
Signed-off-by: Elena Reshetova 
Signed-off-by: Jaegeuk Kim

f2fs: stop all the operations by cp_error flag

2017-11-06T00:41:43+00:00

This patch replaces to use cp_error flag instead of RDONLY for quota off.

Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: preserve i_mode if __f2fs_set_acl() fails

2017-07-29T00:48:54+00:00

When changing a file's acl mask, __f2fs_set_acl() will first set the
group bits of i_mode to the value of the mask, and only then set the
actual extended attribute representing the new acl.

If the second part fails (due to lack of space, for example) and the
file had no acl attribute to begin with, the system will from now on
assume that the mask permission bits are actual group permission bits,
potentially granting access to the wrong users.

Prevent this by only changing the inode mode after the acl has been set.

Signed-off-by: Ernesto A. Fernández 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim