linux.git/fs/ext4, branch v4.13

ext4: add missing xattr hash update

2017-08-14T12:30:06+00:00

When updating an extended attribute, if the padded value sizes are the
same, a shortcut is taken to avoid the bulk of the work. This was fine
until the xattr hash update was moved inside ext4_xattr_set_entry().
With that change, the hash update got missed in the shortcut case.

Thanks to ZhangYi (yizhang089@gmail.com) for root causing the problem.

Fixes: daf8328172df ("ext4: eliminate xattr entry e_hash recalculation for removes")

Reported-by: Miklos Szeredi 
Signed-off-by: Tahsin Erdogan 
Signed-off-by: Theodore Ts'o

ext4: fix clang build regression

2017-08-14T12:29:18+00:00

Arnd Bergmann 

As Stefan pointed out, I misremembered what clang can do specifically,
and it turns out that the variable-length array at the end of the
structure did not work (a flexible array would have worked here
but not solved the problem):

fs/ext4/mballoc.c:2303:17: error: fields must have a constant size:
'variable length array in structure' extension will never be supported
                ext4_grpblk_t counters[blocksize_bits + 2];

This reverts part of my previous patch, using a fixed-size array
again, but keeping the check for the array overflow.

Fixes: 2df2c3402fc8 ("ext4: fix warning about stack corruption")
Reported-by: Stefan Agner 
Tested-by: Chandan Rajendra 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Theodore Ts'o

ext4: fix copy paste error in ext4_swap_extents()

2017-08-06T05:33:07+00:00

This bug was found by a static code checker tool for copy paste
problems.

Signed-off-by: Maninder Singh 
Signed-off-by: Vaneet Narang 
Signed-off-by: Theodore Ts'o

ext4: fix overflow caused by missing cast in ext4_resize_fs()

2017-08-06T05:18:31+00:00

On a 32-bit platform, the value of n_blcoks_count may be wrong during
the file system is resized to size larger than 2^32 blocks.  This may
caused the superblock being corrupted with zero blocks count.

Fixes: 1c6bd7173d66
Signed-off-by: Jerry Lee 
Signed-off-by: Theodore Ts'o 
Cc: stable@vger.kernel.org # 3.7+

ext4, project: expand inode extra size if possible

2017-08-06T05:00:49+00:00

When upgrading from old format, try to set project id
to old file first time, it will return EOVERFLOW, but if
that file is dirtied(touch etc), changing project id will
be allowed, this might be confusing for users, we could
try to expand @i_extra_isize here too.

Reported-by: Zhang Yi 
Signed-off-by: Miao Xie 
Signed-off-by: Wang Shilong 
Signed-off-by: Theodore Ts'o

ext4: cleanup ext4_expand_extra_isize_ea()

2017-08-06T04:55:48+00:00

Clean up some goto statement, make ext4_expand_extra_isize_ea() clearer.

Signed-off-by: Miao Xie 
Signed-off-by: Theodore Ts'o 
Reviewed-by: Wang Shilong

ext4: restructure ext4_expand_extra_isize

2017-08-06T04:40:01+00:00

Current ext4_expand_extra_isize just tries to expand extra isize, if
someone is holding xattr lock or some check fails, it will give up.
So rename its name to ext4_try_to_expand_extra_isize.

Besides that, we clean up unnecessary check and move some relative checks
into it.

Signed-off-by: Miao Xie 
Signed-off-by: Theodore Ts'o 
Reviewed-by: Wang Shilong

ext4: fix forgetten xattr lock protection in ext4_expand_extra_isize

2017-08-06T04:27:38+00:00

We should avoid the contention between the i_extra_isize update and
the inline data insertion, so move the xattr trylock in front of
i_extra_isize update.

Signed-off-by: Miao Xie 
Reviewed-by: Wang Shilong

ext4: make xattr inode reads faster

2017-08-06T04:07:01+00:00

ext4_xattr_inode_read() currently reads each block sequentially while
waiting for io operation to complete before moving on to the next
block. This prevents request merging in block layer.

Add a ext4_bread_batch() function that starts reads for all blocks
then optionally waits for them to complete. A similar logic is used
in ext4_find_entry(), so update that code to use the new function.

Signed-off-by: Tahsin Erdogan 
Signed-off-by: Theodore Ts'o

ext4: inplace xattr block update fails to deduplicate blocks

2017-08-06T02:41:42+00:00

When an xattr block has a single reference, block is updated inplace
and it is reinserted to the cache. Later, a cache lookup is performed
to see whether an existing block has the same contents. This cache
lookup will most of the time return the just inserted entry so
deduplication is not achieved.

Running the following test script will produce two xattr blocks which
can be observed in "File ACL: " line of debugfs output:

  mke2fs -b 1024 -I 128 -F -O extent /dev/sdb 1G
  mount /dev/sdb /mnt/sdb

  touch /mnt/sdb/{x,y}

  setfattr -n user.1 -v aaa /mnt/sdb/x
  setfattr -n user.2 -v bbb /mnt/sdb/x

  setfattr -n user.1 -v aaa /mnt/sdb/y
  setfattr -n user.2 -v bbb /mnt/sdb/y

  debugfs -R 'stat x' /dev/sdb | cat
  debugfs -R 'stat y' /dev/sdb | cat

This patch defers the reinsertion to the cache so that we can locate
other blocks with the same contents.

Signed-off-by: Tahsin Erdogan 
Signed-off-by: Theodore Ts'o 
Reviewed-by: Andreas Dilger