linux.git/fs/ext4, branch v3.19-rc2

move_extent_per_page(): get rid of unused w_flags

2014-12-17T11:43:56+00:00

... and comparing get_fs() with KERNEL_DS used only to initialize that

Signed-off-by: Al Viro

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2014-12-12T17:28:03+00:00

Pull ext4 updates from Ted Ts'o:
 "Lots of bugs fixes, including Zheng and Jan's extent status shrinker
  fixes, which should improve CPU utilization and potential soft lockups
  under heavy memory pressure, and Eric Whitney's bigalloc fixes"

* tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: (26 commits)
  ext4: ext4_da_convert_inline_data_to_extent drop locked page after error
  ext4: fix suboptimal seek_{data,hole} extents traversial
  ext4: ext4_inline_data_fiemap should respect callers argument
  ext4: prevent fsreentrance deadlock for inline_data
  ext4: forbid journal_async_commit in data=ordered mode
  jbd2: remove unnecessary NULL check before iput()
  ext4: Remove an unnecessary check for NULL before iput()
  ext4: remove unneeded code in ext4_unlink
  ext4: don't count external journal blocks as overhead
  ext4: remove never taken branch from ext4_ext_shift_path_extents()
  ext4: create nojournal_checksum mount option
  ext4: update comments regarding ext4_delete_inode()
  ext4: cleanup GFP flags inside resize path
  ext4: introduce aging to extent status tree
  ext4: cleanup flag definitions for extent status tree
  ext4: limit number of scanned extents in status tree shrinker
  ext4: move handling of list of shrinkable inodes into extent status code
  ext4: change LRU to round-robin in extent status tree shrinker
  ext4: cache extent hole in extent status tree for ext4_da_map_blocks()
  ext4: fix block reservation for bigalloc filesystems
  ...

ext4: ext4_da_convert_inline_data_to_extent drop locked page after error

2014-12-06T02:37:15+00:00

Testcase:
xfstests generic/270
MKFS_OPTIONS="-q -I 256 -O inline_data,64bit"

Call Trace:
 [] lock_page+0x35/0x39 -------> DEADLOCK
 [] pagecache_get_page+0x65/0x15a
 [] truncate_inode_pages_range+0x1db/0x45c
 [] ? ext4_da_get_block_prep+0x439/0x4b6
 [] ? __block_write_begin+0x284/0x29c
 [] ? ext4_change_inode_journal_flag+0x16b/0x16b
 [] truncate_inode_pages+0x12/0x14
 [] ext4_truncate_failed_write+0x19/0x25
 [] ext4_da_write_inline_data_begin+0x196/0x31c
 [] ext4_da_write_begin+0x189/0x302
 [] ? trace_hardirqs_on+0xd/0xf
 [] ? read_seqcount_begin.clone.1+0x9f/0xcc
 [] generic_perform_write+0xc7/0x1c6
 [] ? mark_held_locks+0x59/0x77
 [] __generic_file_write_iter+0x17f/0x1c5
 [] ext4_file_write_iter+0x2a5/0x354
 [] ? file_start_write+0x2a/0x2c
 [] ? bad_area_nosemaphore+0x13/0x15
 [] new_sync_write+0x8a/0xb2
 [] vfs_write+0xb5/0x14d
 [] SyS_write+0x5c/0x8c
 [] system_call_fastpath+0x12/0x17

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o

ext4: fix suboptimal seek_{data,hole} extents traversial

2014-12-02T23:08:53+00:00

It is ridiculous practice to scan inode block by block, this technique
applicable only for old indirect files. This takes significant amount
of time for really large files. Let's reuse ext4_fiemap which already
traverse inode-tree in most optimal meaner.

TESTCASE:
ftruncate64(fd, 0);
ftruncate64(fd, 1ULL << 40);
/* lseek will spin very long time */
lseek64(fd, 0, SEEK_DATA);
lseek64(fd, 0, SEEK_HOLE);

Original report: https://lkml.org/lkml/2014/10/16/620

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o

ext4: ext4_inline_data_fiemap should respect callers argument

2014-12-02T21:11:20+00:00

Currently ext4_inline_data_fiemap ignores requested arguments (start
and len) which may lead endless loop if start != 0.  Also fix incorrect
extent length determination.

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o

ext4: prevent fsreentrance deadlock for inline_data

2014-12-02T21:09:50+00:00

ext4_da_convert_inline_data_to_extent() invokes
grab_cache_page_write_begin().  grab_cache_page_write_begin performs
memory allocation, so fs-reentrance should be prohibited because we
are inside journal transaction.

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o

ext4: forbid journal_async_commit in data=ordered mode

2014-11-26T01:19:17+00:00

Option journal_async_commit breaks gurantees of data=ordered mode as it
sends only a single cache flush after writing a transaction commit
block. Thus even though the transaction including the commit block is
fully stored on persistent storage, file data may still linger in drives
caches and will be lost on power failure. Since all checksums match on
journal recovery, we replay the transaction thus possibly exposing stale
user data.

To fix this data exposure issue, remove the possibility to use
journal_async_commit in data=ordered mode.

Signed-off-by: Jan Kara 
Signed-off-by: Theodore Ts'o

ext4: Remove an unnecessary check for NULL before iput()

2014-11-26T01:01:37+00:00

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Theodore Ts'o

ext4: remove unneeded code in ext4_unlink

2014-11-25T21:34:38+00:00

Setting retval to zero is not needed in ext4_unlink.
Remove unneeded code.

Signed-off-by: Namjae Jeon 
Signed-off-by: Ashish Sangwan 
Signed-off-by: Theodore Ts'o

ext4: don't count external journal blocks as overhead

2014-11-25T21:27:44+00:00

This was fixed for ext3 with:

e6d8fb3 ext3: Count internal journal as bsddf overhead in ext3_statfs

but was never fixed for ext4.

With a large external journal and no used disk blocks, df comes
out negative without this, as journal blocks are added to the
overhead & subtracted from used blocks unconditionally.

Signed-off-by: Eric Sandeen 
Signed-off-by: Theodore Ts'o