linux.git/fs/ext4, branch v2.6.24

ext3, ext4: avoid divide by zero

2007-12-18T03:28:16+00:00

As it turns out, the kernel divides by EXT3_INODES_PER_GROUP(s) when
mounting an ext3 filesystem.  If that number is zero, a crash follows.
Below a patch.

This crash was reported by Joeri de Ruiter, Carst Tankink and Pim Vullers.

Cc: 
Acked-by: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Forbid user to change file flags on quota files

2007-11-15T02:45:38+00:00

Forbid user from changing file flags on quota files.  User has no bussiness
in playing with these flags when quota is on.  Furthermore there is a
remote possibility of deadlock due to a lock inversion between quota file's
i_mutex and transaction's start (i_mutex for quota file is locked only when
trasaction is started in quota operations) in ext3 and ext4.

Signed-off-by: Jan Kara 
Cc: LIOU Payphone 
Cc: 
Acked-by: Dave Kleikamp 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Revert "ext2/ext3/ext4: add block bitmap validation"

2007-11-13T16:09:11+00:00

This reverts commit 7c9e69faa28027913ee059c285a5ea8382e24b5d, fixing up
conflicts in fs/ext4/balloc.c manually.

The cost of doing the bitmap validation on each lookup - even when the
bitmap is cached - is absolutely prohibitive.  We could, and probably
should, do it only when adding the bitmap to the buffer cache.  However,
right now we are better off just reverting it.

Peter Zijlstra measured the cost of this extra validation as a 85%
decrease in cached iozone, and while I had a patch that took it down to
just 17% by not being _quite_ so stupid in the validation, it was still
a big slowdown that could have been avoided by just doing it right.

Cc: Peter Zijlstra 
Cc: Andrew Morton 
Cc: Aneesh Kumar 
Cc: Andreas Dilger 
Cc: Mingming Cao 
Signed-off-by: Linus Torvalds

exportfs: make struct export_operations const

2007-10-22T15:13:21+00:00

Now that nfsd has stopped writing to the find_exported_dentry member we an
mark the export_operations const

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: 
Cc: Dave Kleikamp 
Cc: Anton Altaparmakov 
Cc: David Chinner 
Cc: Timothy Shimmin 
Cc: OGAWA Hirofumi 
Cc: Hugh Dickins 
Cc: Chris Mason 
Cc: Jeff Mahoney 
Cc: "Vladimir V. Saveliev" 
Cc: Steven Whitehouse 
Cc: Mark Fasheh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext4: new export ops

2007-10-22T15:13:20+00:00

Trivial switch over to the new generic helpers.

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext4: lighten up resize transaction requirements

2007-10-17T22:50:04+00:00

When resizing online, setup_new_group_blocks attempts to reserve a
potentially very large transaction, depending on the current filesystem
geometry.  For some journal sizes, there may not be enough room for this
transaction, and the online resize will fail.

The patch below resizes & restarts the transaction as necessary while
setting up the new group, and should work with even the smallest journal.

Tested with something like:

[root@newbox ~]# dd if=/dev/zero of=fsfile bs=1024 count=32768
[root@newbox ~]# mkfs.ext3 -b 1024 fsfile 16384
[root@newbox ~]# mount -o loop fsfile mnt/
[root@newbox ~]# resize2fs /dev/loop0
resize2fs 1.40.2 (12-Jul-2007)
Filesystem at /dev/loop0 is mounted on /root/mnt; on-line resizing required
old desc_blocks = 1, new_desc_blocks = 1
Performing an on-line resize of /dev/loop0 to 32768 (1k) blocks.
resize2fs: No space left on device While trying to add group #2
[root@newbox ~]# dmesg | tail -n 1
JBD: resize2fs wants too many credits (258 > 256)
[root@newbox ~]#

With the below change, it works.

Signed-off-by: Eric Sandeen 
Signed-off-by: Mingming Cao 
Acked-by: Andreas Dilger

ext4: fix setup_new_group_blocks locking

2007-10-17T22:50:04+00:00

setup_new_group_blocks() manipulates the group descriptor block bh
under the block_bitmap bh's lock.  It shouldn't matter since nobody
but resize should be touching these blocks, but it's worth fixing up.

Signed-off-by: Eric Sandeen 
Signed-off-by: Mingming Cao

ext4: sparse fixes

2007-10-17T22:50:03+00:00

Signed-off-by: Aneesh Kumar K.V

ext4: Convert ext4_extent_idx.ei_leaf to ext4_extent_idx.ei_leaf_lo

2007-10-17T22:50:03+00:00

Convert ext4_extent_idx.ei_leaf  ext4_extent_idx.ei_leaf_lo
This helps in finding BUGs due to direct partial access of
these split 48 bit values.

Signed-off-by: Aneesh Kumar K.V

ext4: Convert ext4_extent.ee_start to ext4_extent.ee_start_lo

2007-10-17T22:50:03+00:00

Convert ext4_extent.ee_start to ext4_extent.ee_start_lo
This helps in finding BUGs due to direct partial access of
these split 48 bit values

Also fix direct partial access in ext4 code

Signed-off-by: Aneesh Kumar K.V