linux.git/fs/ext4/inode.c, branch v3.11

jbd2: Fix oops in jbd2_journal_file_inode()

2013-08-17T01:19:41+00:00

Commit 0713ed0cde76438d05849f1537d3aab46e099475 added
jbd2_journal_file_inode() call into ext4_block_zero_page_range().
However that function gets called from truncate path and thus inode
needn't have jinode attached - that happens in ext4_file_open() but
the file needn't be ever open since mount. Calling
jbd2_journal_file_inode() without jinode attached results in the oops.

We fix the problem by attaching jinode to inode also in ext4_truncate()
and ext4_punch_hole() when we are going to zero out partial blocks.

Reported-by: majianpeng 
Signed-off-by: Jan Kara 
Signed-off-by: "Theodore Ts'o"

ext4: add WARN_ON to check the length of allocated blocks

2013-07-29T16:51:42+00:00

In commit 921f266b: ext4: add self-testing infrastructure to do a
sanity check, some sanity checks were added in map_blocks to make sure
'retval == map->m_len'.

Enable these checks by default and report any assertion failures using
ext4_warning() and WARN_ON() since they can help us to figure out some
bugs that are otherwise hard to hit.

Signed-off-by: Zheng Liu 
Signed-off-by: "Theodore Ts'o"

ext4: call ext4_es_lru_add() after handling cache miss

2013-07-16T14:28:47+00:00

If there are no items in the extent status tree, ext4_es_lru_add() is
a no-op.  So it is not sufficient to call ext4_es_lru_add() before we
try to lookup an entry in the extent status tree.  We also need to
call it at the end of ext4_ext_map_blocks(), after items have been
added to the extent status tree.

This could lead to inodes with that have extent status trees but which
are not in the LRU list, which means they won't get considered for
eviction by the es_shrinker.

Signed-off-by: "Theodore Ts'o" 
Cc: Zheng Liu 
Cc: stable@vger.kernel.org

ext4: fix spelling errors and a comment in extent_status tree

2013-07-13T04:40:31+00:00

Replace "assertation" with "assertion" in lots and lots of debugging
messages.

Correct the comment stating when ext4_es_insert_extent() is used.  It
was no doubt tree at one point, but it is no longer true...

Signed-off-by: "Theodore Ts'o" 
Cc: Zheng Liu

ext4: silence warning in ext4_writepages()

2013-07-06T01:57:22+00:00

The loop in mpage_map_and_submit_extent() is guaranteed to always run
at least once since the caller of mpage_map_and_submit_extent() makes
sure map->m_len > 0. So make that explicit using do-while instead of
pure while which also silences the compiler warning about
uninitialized 'err' variable.

Signed-off-by: Jan Kara 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Lukas Czerner

ext4: fix up error handling for mpage_map_and_submit_extent()

2013-07-01T12:12:40+00:00

The function mpage_released_unused_page() must only be called once;
otherwise the kernel will BUG() when the second call to
mpage_released_unused_page() tries to unlock the pages which had been
unlocked by the first call.

Also restructure the error handling so that we only give up on writing
the dirty pages in the case of ENOSPC where retrying the allocation
won't help.  Otherwise, a transient failure, such as a kmalloc()
failure in calling ext4_map_blocks() might cause us to give up on
those pages, leading to a scary message in /var/log/messages plus data
loss.

Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Jan Kara

ext4: only zero partial blocks in ext4_zero_partial_blocks()

2013-07-01T12:12:39+00:00

Currently if we pass range into ext4_zero_partial_blocks() which covers
entire block we would attempt to zero it even though we should only zero
unaligned part of the block.

Fix this by checking whether the range covers the whole block skip
zeroing if so.

Signed-off-by: Lukas Czerner 
Signed-off-by: "Theodore Ts'o"

ext4: check error return from ext4_write_inline_data_end()

2013-07-01T12:12:39+00:00

The function ext4_write_inline_data_end() can return an error.  So we
need to assign it to a signed integer variable to check for an error
return (since copied is an unsigned int).

Signed-off-by: "Theodore Ts'o" 
Cc: Zheng Liu 
Cc: stable@vger.kernel.org

ext4: delete unnecessary C statements

2013-07-01T12:12:39+00:00

Comparing unsigned variable with 0 always returns false.
err = 0 is duplicated and unnecessary.

[ tytso: Also cleaned up error handling in ext4_block_zero_page_range() ]

Signed-off-by: "Jon Ernst" 
Signed-off-by: "Theodore Ts'o"

ext4: pass inode pointer instead of file pointer to punch hole

2013-07-01T12:12:38+00:00

No need to pass file pointer when we can directly pass inode pointer.

Signed-off-by: Ashish Sangwan 
Signed-off-by: Namjae Jeon 
Signed-off-by: "Theodore Ts'o"