linux.git/fs/ext4/inode.c, branch v2.6.32

ext4: code clean up for dio fallocate handling

2009-11-03T19:44:54+00:00

The ext4_debug() call in ext4_end_io_dio() should be moved after the
check to make sure that io_end is non-NULL.

The comment above ext4_get_block_dio_write() ("Maximum number of
blocks...") is a duplicate; the original and correct comment is above
the #define DIO_MAX_BLOCKS up above.

Based on review comments from Curt Wohlgemuth.

Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: skip conversion of uninit extents after direct IO if there isn't any

2009-11-10T15:48:04+00:00

At the end of direct I/O operation, ext4_ext_direct_IO() always called
ext4_convert_unwritten_extents(), regardless of whether there were any
unwritten extents involved in the I/O or not.

This commit adds a state flag so that ext4_ext_direct_IO() only calls
ext4_convert_unwritten_extents() when necessary.

Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: fix ext4_ext_direct_IO()'s return value after converting uninit extents

2009-11-10T15:48:08+00:00

After a direct I/O request covering an uninitalized extent (i.e.,
created using the fallocate system call) or a hole in a file, ext4
will convert the uninitialized extent so it is marked as initialized
by calling ext4_convert_unwritten_extents().  This function returns
zero on success.

This return value was getting returned by ext4_direct_IO(); however
the file system's direct_IO function is supposed to return the number
of bytes read or written on a success.  By returning zero, it confused
the direct I/O code into falling back to buffered I/O unnecessarily.

Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: discard preallocation when restarting a transaction during truncate

2009-11-02T23:50:49+00:00

When restart a transaction during a truncate operation, we drop and
reacquire i_data_sem.  After reacquiring i_data_sem, we need to
discard any inode-based preallocation that might have been grabbed
while we released i_data_sem (for example, if pdflush is allocating
blocks and racing against the truncate).

Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: "Theodore Ts'o"

[PATCH] ext4: retry failed direct IO allocations

2009-10-03T01:20:55+00:00

On a 256M filesystem, doing this in a loop:

        xfs_io -F -f -d -c 'pwrite 0 64m' test
        rm -f test

eventually leads to ENOSPC.  (the xfs_io command does a
64m direct IO write to the file "test")

As with other block allocation callers, it looks like we need to
potentially retry the allocations on the initial ENOSPC.

Signed-off-by: Eric Sandeen 
Signed-off-by: "Theodore Ts'o"

ext4: Fix build warning in ext4_dirty_inode()

2009-10-03T01:08:32+00:00

This fixes the following warning:

fs/ext4/inode.c: In function 'ext4_dirty_inode':
fs/ext4/inode.c:5615: warning: unused variable 'current_handle'

We remove the jbd_debug() statement which does use current_handle, as
it's not terribly important in the grand scheme of things.

Thanks to Stephen Rothwell for pointing this out.

Signed-off-by: Curt Wohlgemuth 
Signed-off-by: "Theodore Ts'o"

ext4: fix a BUG_ON crash by checking that page has buffers attached to it

2009-10-01T02:57:41+00:00

In ext4_num_dirty_pages() we were calling page_buffers() before
checking to see if the page actually had pages attached to it; this
would cause a BUG check crash in the inline function page_buffers().

Thanks to Markus Trippelsdorf for reporting this bug.

Signed-off-by: "Theodore Ts'o"

ext4: Make sure ext4_dirty_inode() updates the inode in no journal mode

2009-09-29T20:06:01+00:00

This patch a problem that ext4_dirty_inode() was not calling
ext4_mark_inode_dirty() if the current_handle is not valid, which it
is the case in no journal mode.

It also removes a test for non-matching transaction which can never
happen.

Signed-off-by: Curt Wohlgemuth 
Signed-off-by: "Theodore Ts'o"

ext4: Avoid updating the inode table bh twice in no journal mode

2009-09-29T14:07:47+00:00

This is a cleanup of commit 91ac6f4.  Since ext4_mark_inode_dirty()
has already called ext4_mark_iloc_dirty(), which in turn calls
ext4_do_update_inode(), it's not necessary to have ext4_write_inode()
call ext4_do_update_inode() in no journal mode.  Indeed, it would be
duplicated work.

Reviewed-by: "Aneesh Kumar K.V" 
Signed-off-by: Frank Mayhar 
Signed-off-by: "Theodore Ts'o"

ext4: async direct IO for holes and fallocate support

2009-09-28T19:48:29+00:00

For async direct IO that covers holes or fallocate, the end_io
callback function now queued the convertion work on workqueue but
don't flush the work rightaway as it might take too long to afford.

But when fsync is called after all the data is completed, user expects
the metadata also being updated before fsync returns.

Thus we need to flush the conversion work when fsync() is called.
This patch keep track of a listed of completed async direct io that
has a work queued on workqueue.  When fsync() is called, it will go
through the list and do the conversion.

Signed-off-by: Mingming Cao