linux.git/fs/ext3, branch v2.6.33

ext3: Replace lock/unlock_super() with an explicit lock for resizing

2009-12-23T12:44:12+00:00

Use a separate lock to protect s_groups_count and the other block
group descriptors which get changed via an on-line resize operation,
so we can stop overloading the use of lock_super().

Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: Replace lock/unlock_super() with an explicit lock for the orphan list

2009-12-23T12:44:11+00:00

Use a separate lock to protect the orphan list, so we can stop
overloading the use of lock_super().

Port of ext4 commit 3b9d4ed26680771295d904a6b83e88e620780893
by Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: ext3_mark_recovery_complete() doesn't need to use lock_super

2009-12-23T12:44:11+00:00

The function ext3_mark_recovery_complete() is called from two call
paths: either (a) while mounting the filesystem, in which case there's
no danger of any other CPU calling write_super() until the mount is
completed, and (b) while remounting the filesystem read-write, in
which case the fs core has already locked the superblock.  This also
allows us to take out a very vile unlock_super()/lock_super() pair in
ext3_remount().

Port of ext4 commit a63c9eb2ce6f5028da90f282798232c4f398ceb8 by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: Remove outdated comment about lock_super()

2009-12-23T12:43:50+00:00

ext3_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked.  The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: quota macros cleanup [V2]

2009-12-23T12:33:54+00:00

Currently all quota block reservation macros contains hardcoded "2"
aka MAXQUOTAS value. This is no good because in some places it is not
obvious to understand what does this digit represent. Let's introduce
new macro with self descriptive name.

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Jan Kara

sanitize xattr handler prototypes

2009-12-16T17:16:49+00:00

Add a flags argument to struct xattr_handler and pass it to all xattr
handler methods.  This allows using the same methods for multiple
handlers, e.g. for the ACL methods which perform exactly the same action
for the access and default ACLs, just using a different underlying
attribute.  With a little more groundwork it'll also allow sharing the
methods for the regular user/trusted/secure handlers in extN, ocfs2 and
jffs2 like it's already done for xfs in this patch.

Also change the inode argument to the handlers to a dentry to allow
using the handlers mechnism for filesystems that require it later,
e.g. cifs.

[with GFS2 bits updated by Steven Whitehouse ]

Signed-off-by: Christoph Hellwig 
Reviewed-by: James Morris 
Acked-by: Joel Becker 
Signed-off-by: Al Viro

ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks()

2009-12-10T14:02:55+00:00

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin 
Signed-off-by: Jan Kara

ext3: Fix data / filesystem corruption when write fails to copy data

2009-12-10T14:02:55+00:00

When ext3_write_begin fails after allocating some blocks or
generic_perform_write fails to copy data to write, we truncate blocks already
instantiated beyond i_size. Although these blocks were never inside i_size, we
have to truncate pagecache of these blocks so that corresponding buffers get
unmapped. Otherwise subsequent __block_prepare_write (called because we are
retrying the write) will find the buffers mapped, not call ->get_block, and
thus the page will be backed by already freed blocks leading to filesystem and
data corruption.

Reported-by: James Y Knight 
Signed-off-by: Jan Kara

ext3: Support for vfsv1 quota format

2009-12-10T14:02:54+00:00

We just have to add proper mount options handling. The rest is handled by
the generic quota code.

CC: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara

ext3: Unify log messages in ext3

2009-12-10T14:02:53+00:00

Make messages produced by ext3 more unified. It should be
easy to parse.

dmesg before patch:
[ 4893.684892] reservations ON
[ 4893.684896] xip option not supported
[ 4893.684964] EXT3-fs warning: maximal mount count reached, running
e2fsck is recommended

dmesg after patch:
[  873.300792] EXT3-fs (loop0): using internal journaln
[  873.300796] EXT3-fs (loop0): mounted filesystem with writeback data mode
[  924.163657] EXT3-fs (loop0): error: can't find ext3 filesystem on dev loop0.
[  723.755642] EXT3-fs (loop0): error: bad blocksize 8192
[  357.874687] EXT3-fs (loop0): error: no journal found. mounting ext3 over ext2?
[  873.300764] EXT3-fs (loop0): warning: maximal mount count reached, running e2fsck is recommended
[  924.163657] EXT3-fs (loop0): error: can't find ext3 filesystem on dev loop0.

Signed-off-by: Alexey Fisher 
Signed-off-by: Jan Kara