linux.git/fs/ext3, branch v2.6.24

ext3, ext4: avoid divide by zero

2007-12-18T03:28:16+00:00

As it turns out, the kernel divides by EXT3_INODES_PER_GROUP(s) when
mounting an ext3 filesystem.  If that number is zero, a crash follows.
Below a patch.

This crash was reported by Joeri de Ruiter, Carst Tankink and Pim Vullers.

Cc: 
Acked-by: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix 64KB blocksize in ext3 directories

2007-11-15T02:45:43+00:00

With 64KB blocksize, a directory entry can have size 64KB which does not
fit into 16 bits we have for entry lenght.  So we store 0xffff instead and
convert value when read from / written to disk.  The patch also converts
some places to use ext3_next_entry() when we are changing them anyway.

[akpm@linux-foundation.org: coding-style cleanups]
Signed-off-by: Jan Kara 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Forbid user to change file flags on quota files

2007-11-15T02:45:38+00:00

Forbid user from changing file flags on quota files.  User has no bussiness
in playing with these flags when quota is on.  Furthermore there is a
remote possibility of deadlock due to a lock inversion between quota file's
i_mutex and transaction's start (i_mutex for quota file is locked only when
trasaction is started in quota operations) in ext3 and ext4.

Signed-off-by: Jan Kara 
Cc: LIOU Payphone 
Cc: 
Acked-by: Dave Kleikamp 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Revert "ext2/ext3/ext4: add block bitmap validation"

2007-11-13T16:09:11+00:00

This reverts commit 7c9e69faa28027913ee059c285a5ea8382e24b5d, fixing up
conflicts in fs/ext4/balloc.c manually.

The cost of doing the bitmap validation on each lookup - even when the
bitmap is cached - is absolutely prohibitive.  We could, and probably
should, do it only when adding the bitmap to the buffer cache.  However,
right now we are better off just reverting it.

Peter Zijlstra measured the cost of this extra validation as a 85%
decrease in cached iozone, and while I had a patch that took it down to
just 17% by not being _quite_ so stupid in the validation, it was still
a big slowdown that could have been avoided by just doing it right.

Cc: Peter Zijlstra 
Cc: Andrew Morton 
Cc: Aneesh Kumar 
Cc: Andreas Dilger 
Cc: Mingming Cao 
Signed-off-by: Linus Torvalds

exportfs: make struct export_operations const

2007-10-22T15:13:21+00:00

Now that nfsd has stopped writing to the find_exported_dentry member we an
mark the export_operations const

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: 
Cc: Dave Kleikamp 
Cc: Anton Altaparmakov 
Cc: David Chinner 
Cc: Timothy Shimmin 
Cc: OGAWA Hirofumi 
Cc: Hugh Dickins 
Cc: Chris Mason 
Cc: Jeff Mahoney 
Cc: "Vladimir V. Saveliev" 
Cc: Steven Whitehouse 
Cc: Mark Fasheh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext3: new export ops

2007-10-22T15:13:19+00:00

Trivial switch over to the new generic helpers.

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

JBD: Fix JBD warnings when compiling with CONFIG_JBD_DEBUG

2007-10-19T18:53:35+00:00

Note from Mingming's JBD2 fix:

Noticed all warnings are occurs when the debug level is 0.  Then found the
"jbd2: Move jbd2-debug file to debugfs" patch
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0f49d5d019afa4e94253bfc92f0daca3badb990b

changed the jbd2_journal_enable_debug from int type to u8, makes the
jbd_debug comparision is always true when the debugging level is 0.  Thus
the compile warning occurs.

Thought about changing the jbd2_journal_enable_debug data type back to int,
but can't, because the jbd2-debug is moved to debug fs, where calling
debugfs_create_u8() to create the debugfs entry needs the value to be u8
type.

Even if we changed the data type back to int, the code is still buggy,
kernel should not print jbd2 debug message if the jbd2_journal_enable_debug
is set to 0.  But this is not the case.

The fix is change the level of debugging to 1.  The same should fixed in
ext3/JBD, but currently ext3 jbd-debug via /proc fs is broken, so we
probably should fix it all together.

Signed-off-by: Jose R. Santos 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

JBD/ext3 cleanups: convert to kzalloc

2007-10-19T18:53:34+00:00

Convert kmalloc to kzalloc() and get rid of the memset().

Signed-off-by: Mingming Cao 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sparse pointer use of zero as null

2007-10-18T21:37:31+00:00

Get rid of sparse related warnings from places that use integer as NULL
pointer.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Stephen Hemminger 
Cc: Andi Kleen 
Cc: Jeff Garzik 
Cc: Matt Mackall 
Cc: Ian Kent 
Cc: Arnd Bergmann 
Cc: Davide Libenzi 
Cc: Stephen Smalley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext3: fix setup_new_group_blocks locking

2007-10-18T21:37:29+00:00

setup_new_group_blocks() manipulates the group descriptor block bh under
the block_bitmap bh's lock.  It shouldn't matter since nobody but resize
should be touching these blocks, but it's worth fixing up.

Signed-off-by: Eric Sandeen 
C: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds