linux.git/fs/ext3/inode.c, branch v2.6.26

ext3: fix test ext_generic_write_end() copied return value

2008-04-30T02:01:27+00:00

'copied' is unsigned, whereas 'ret2' is not. The test (copied < 0) fails

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: "Theodore Ts'o"

ext3: replace remaining FUNCTION occurrences

2008-04-28T15:58:45+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext3: use ext3_get_group_desc()

2008-04-28T15:58:44+00:00

Use ext3_get_group_desc()

Signed-off-by: Akinobu Mita 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext*: spelling fix prefered -> preferred

2008-04-21T22:45:55+00:00

Spelling fix: prefered -> preferred

Signed-off-by: Benoit Boissinot 
Signed-off-by: Jesper Juhl

iget: stop EXT3 from using iget() and read_inode()

2008-02-07T16:42:27+00:00

Stop the EXT3 filesystem from using iget() and read_inode().  Replace
ext3_read_inode() with ext3_iget(), and call that instead of iget().
ext3_iget() then uses iget_locked() directly and returns a proper error code
instead of an inode in the event of an error.

ext3_fill_super() returns any error incurred when getting the root inode
instead of EINVAL.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: David Howells 
Acked-by: "Theodore Ts'o" 
Acked-by: Jan Kara 
Cc: 
Acked-by: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext3: fix lock inversion in direct IO

2008-02-06T18:41:21+00:00

We cannot start transaction in ext3_direct_IO() and just let it last during
the whole write because dio_get_page() acquires mmap_sem which ranks above
transaction start (e.g.  because we have dependency chain
mmap_sem->PageLock->journal_start, or because we update atime while holding
mmap_sem) and thus deadlocks could happen.  We solve the problem by
starting a transaction separately for each ext3_get_block() call.

We *could* have a problem that we allocate a block and before its data are
written out the machine crashes and thus we expose stale data.  But that
does not happen because for hole-filling generic code falls back to
buffered writes and for file extension, we add inode to orphan list and
thus in case of crash, journal replay will truncate inode back to the
original size.

[akpm@linux-foundation.org: build fix]
Signed-off-by: Jan Kara 
Cc: 
Cc: Zach Brown 
Cc: Badari Pulavarty 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext[234]: remove unused argument for ext[234]_find_goal()

2008-02-06T18:41:21+00:00

The argument chain for ext[234]_find_goal() is not used.  This patch removes
it and fixes comment as well.

Cc: 
Signed-off-by: Akinobu Mita 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2008-02-05T17:44:13+00:00

Simplify page cache zeroing of segments of pages through 3 functions

zero_user_segments(page, start1, end1, start2, end2)

        Zeros two segments of the page. It takes the position where to
        start and end the zeroing which avoids length calculations and
	makes code clearer.

zero_user_segment(page, start, end)

        Same for a single segment.

zero_user(page, start, length)

        Length variant for the case where we know the length.

We remove the zero_user_page macro. Issues:

1. Its a macro. Inline functions are preferable.

2. The KM_USER0 macro is only defined for HIGHMEM.

   Having to treat this special case everywhere makes the
   code needlessly complex. The parameter for zeroing is always
   KM_USER0 except in one single case that we open code.

Avoiding KM_USER0 makes a lot of code not having to be dealing
with the special casing for HIGHMEM anymore. Dealing with
kmap is only necessary for HIGHMEM configurations. In those
configurations we use KM_USER0 like we do for a series of other
functions defined in highmem.h.

Since KM_USER0 is depends on HIGHMEM the existing zero_user_page
function could not be a macro. zero_user_* functions introduced
here can be be inline because that constant is not used when these
functions are called.

Also extract the flushing of the caches to be outside of the kmap.

[akpm@linux-foundation.org: fix nfs and ntfs build]
[akpm@linux-foundation.org: fix ntfs build some more]
Signed-off-by: Christoph Lameter 
Cc: Steven French 
Cc: Michael Halcrow 
Cc: 
Cc: Steven Whitehouse 
Cc: Trond Myklebust 
Cc: "J. Bruce Fields" 
Cc: Anton Altaparmakov 
Cc: Mark Fasheh 
Cc: David Chinner 
Cc: Michael Halcrow 
Cc: Steven French 
Cc: Steven Whitehouse 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

JBD: Fix JBD warnings when compiling with CONFIG_JBD_DEBUG

2007-10-19T18:53:35+00:00

Note from Mingming's JBD2 fix:

Noticed all warnings are occurs when the debug level is 0.  Then found the
"jbd2: Move jbd2-debug file to debugfs" patch
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0f49d5d019afa4e94253bfc92f0daca3badb990b

changed the jbd2_journal_enable_debug from int type to u8, makes the
jbd_debug comparision is always true when the debugging level is 0.  Thus
the compile warning occurs.

Thought about changing the jbd2_journal_enable_debug data type back to int,
but can't, because the jbd2-debug is moved to debug fs, where calling
debugfs_create_u8() to create the debugfs entry needs the value to be u8
type.

Even if we changed the data type back to int, the code is still buggy,
kernel should not print jbd2 debug message if the jbd2_journal_enable_debug
is set to 0.  But this is not the case.

The fix is change the level of debugging to 1.  The same should fixed in
ext3/JBD, but currently ext3 jbd-debug via /proc fs is broken, so we
probably should fix it all together.

Signed-off-by: Jose R. Santos 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sparse pointer use of zero as null

2007-10-18T21:37:31+00:00

Get rid of sparse related warnings from places that use integer as NULL
pointer.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Stephen Hemminger 
Cc: Andi Kleen 
Cc: Jeff Garzik 
Cc: Matt Mackall 
Cc: Ian Kent 
Cc: Arnd Bergmann 
Cc: Davide Libenzi 
Cc: Stephen Smalley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds