linux.git/fs/ext2, branch v2.6.24

fix up ext2_fs.h for userspace after reservations backport

2007-11-29T17:24:53+00:00

In commit a686cd898bd999fd026a51e90fb0a3410d258ddb:

 "Val's cross-port of the ext3 reservations code into ext2."

include/linux/ext2_fs.h got a new function whose return value is only
defined if __KERNEL__ is defined. Putting #ifdef __KERNEL__ around the
function seems to help, patch below.

Signed-off-by: Eric Sandeen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Forbid user to change file flags on quota files

2007-11-15T02:45:38+00:00

Forbid user from changing file flags on quota files.  User has no bussiness
in playing with these flags when quota is on.  Furthermore there is a
remote possibility of deadlock due to a lock inversion between quota file's
i_mutex and transaction's start (i_mutex for quota file is locked only when
trasaction is started in quota operations) in ext3 and ext4.

Signed-off-by: Jan Kara 
Cc: LIOU Payphone 
Cc: 
Acked-by: Dave Kleikamp 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Revert "ext2/ext3/ext4: add block bitmap validation"

2007-11-13T16:09:11+00:00

This reverts commit 7c9e69faa28027913ee059c285a5ea8382e24b5d, fixing up
conflicts in fs/ext4/balloc.c manually.

The cost of doing the bitmap validation on each lookup - even when the
bitmap is cached - is absolutely prohibitive.  We could, and probably
should, do it only when adding the bitmap to the buffer cache.  However,
right now we are better off just reverting it.

Peter Zijlstra measured the cost of this extra validation as a 85%
decrease in cached iozone, and while I had a patch that took it down to
just 17% by not being _quite_ so stupid in the validation, it was still
a big slowdown that could have been avoided by just doing it right.

Cc: Peter Zijlstra 
Cc: Andrew Morton 
Cc: Aneesh Kumar 
Cc: Andreas Dilger 
Cc: Mingming Cao 
Signed-off-by: Linus Torvalds

exportfs: make struct export_operations const

2007-10-22T15:13:21+00:00

Now that nfsd has stopped writing to the find_exported_dentry member we an
mark the export_operations const

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: 
Cc: Dave Kleikamp 
Cc: Anton Altaparmakov 
Cc: David Chinner 
Cc: Timothy Shimmin 
Cc: OGAWA Hirofumi 
Cc: Hugh Dickins 
Cc: Chris Mason 
Cc: Jeff Mahoney 
Cc: "Vladimir V. Saveliev" 
Cc: Steven Whitehouse 
Cc: Mark Fasheh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2: new export ops

2007-10-22T15:13:19+00:00

Trivial switch over to the new generic helpers.

Signed-off-by: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2: avoid rec_len overflow with 64KB block size

2007-10-22T15:13:18+00:00

With 64KB blocksize, a directory entry can have size 64KB which does not
fit into 16 bits we have for entry length.  So we store 0xffff instead and
convert the value when read from / written to disk.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Jan Kara 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2 reservations

2007-10-17T15:43:02+00:00

Val's cross-port of the ext3 reservations code into ext2.

[mbligh@mbligh.org: Small type error for printk
[akpm@linux-foundation.org: fix types, sync with ext3]
[mbligh@mbligh.org: Bring ext2 reservations code in line with latest ext3]
[akpm@linux-foundation.org: kill noisy printk]
[akpm@linux-foundation.org: remember to dirty the gdp's block]
[akpm@linux-foundation.org: cross-port the missed 5dea5176e5c32ef9f0d1a41d28427b3bf6881b3a]
[akpm@linux-foundation.org: cross-port e6022603b9aa7d61d20b392e69edcdbbc1789969]
[akpm@linux-foundation.org: Port the omitted 08fb306fe63d98eb86e3b16f4cc21816fa47f18e]
[akpm@linux-foundation.org: Backport the missed 20acaa18d0c002fec180956f87adeb3f11f635a6]
[akpm@linux-foundation.org: fixes]
[cmm@us.ibm.com: fix reservation extension]
[bunk@stusta.de: make ext2_get_blocks() static]
[hugh@veritas.com: fix hang]
[hugh@veritas.com: ext2_new_blocks should reset the reservation window size]
[hugh@veritas.com: ext2 balloc: fix off-by-one against rsv_end]
[hugh@veritas.com: grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such]
[hugh@veritas.com: rbtree usage cleanup]
[pbadari@us.ibm.com: Fix for ext2 reservation]
[bunk@kernel.org: remove fs/ext2/balloc.c:reserve_blocks()]
[hugh@veritas.com: ext2 balloc: use io_error label]
Cc: "Martin J. Bligh" 
Cc: Valerie Henson 
Cc: Mingming Cao 
Cc: Mel Gorman 
Cc: Hugh Dickins 
Signed-off-by: Adrian Bunk 
Signed-off-by: Hugh Dickins 
Signed-off-by: Badari Pulavarty 
Signed-off-by: Adrian Bunk 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2/4: use is_power_of_2()

2007-10-17T15:42:53+00:00

Replace n & (n - 1) with is_power_of_2(n)

Signed-off-by: vignesh babu 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2/ext3/ext4: add block bitmap validation

2007-10-17T15:42:52+00:00

When a new block bitmap is read from disk in read_block_bitmap() there are
a few bits that should ALWAYS be set.  In particular, the blocks given by
ext4_blk_bitmap, ext4_inode_bitmap and ext4_inode_table.  Validate the
block bitmap against these blocks.

[akpm@linux-foundation.org: cleanups]
Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: Andreas Dilger 
Acked-by: Mingming Cao 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

remove unused bh in calls to ext234_get_group_desc

2007-10-17T15:42:49+00:00

ext[234]_get_group_desc never tests the bh argument, and only sets it if it
is passed in; it is perfectly happy with a NULL bh argument.  But, many
callers send one in and never use it.  May as well call with NULL like
other callers who don't use the bh.

Signed-off-by: Eric Sandeen 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds