linux.git/fs/exfat, branch v6.3

Merge tag 'exfat-for-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat

2023-03-01T16:42:27+00:00

Pull exfat updates from Namjae Jeon:

 - Handle vendor extension and allocation entries as unrecognized benign
   secondary entries

 - Fix wrong ->i_blocks on devices with non-512 byte sector

 - Add the check to avoid returning -EIO from exfat_readdir() at current
   position exceeding the directory size

 - Fix a bug that reach the end of the directory stream at a position
   not aligned with the dentry size

 - Redefine DIR_DELETED as 0xFFFFFFF7, the bad cluster number

 - Two cleanup fixes and fix cluster leakage in error handling

* tag 'exfat-for-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat:
  exfat: fix the newly allocated clusters are not freed in error handling
  exfat: don't print error log in normal case
  exfat: remove unneeded code from exfat_alloc_cluster()
  exfat: handle unreconized benign secondary entries
  exfat: fix inode->i_blocks for non-512 byte sector size device
  exfat: redefine DIR_DELETED as the bad cluster number
  exfat: fix reporting fs error when reading dir beyond EOF
  exfat: fix unexpected EOF while reading dir

exfat: fix the newly allocated clusters are not freed in error handling

2023-02-28T11:01:40+00:00

In error handling 'free_cluster', before num_alloc clusters allocated,
p_chain->size will not updated and always 0, thus the newly allocated
clusters are not freed.

Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: don't print error log in normal case

2023-02-28T11:01:36+00:00

When allocating a new cluster, exFAT first allocates from the
next cluster of the last cluster of the file. If the last cluster
of the file is the last cluster of the volume, allocate from the
first cluster. This is a normal case, but the following error log
will be printed. It makes users confused, so this commit removes
the error log.

[1960905.181545] exFAT-fs (sdb1): hint_cluster is invalid (262130)

Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: remove unneeded code from exfat_alloc_cluster()

2023-02-28T11:01:22+00:00

In the removed code, num_clusters is 0, nothing is done in
exfat_chain_cont_cluster(), so it is unneeded, remove it.

Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: handle unreconized benign secondary entries

2023-02-27T12:14:46+00:00

Sony PXW-Z280 camera add vendor allocation entries to directory of
pictures. Currently, linux exfat does not support it and the file is
not visible. This patch handle vendor extension and allocation entries
as unreconized benign secondary entries. As described in the specification,
it is recognized but ignored, and when deleting directory entry set,
the associated clusters allocation are removed as well as benign secondary
directory entries.

Reported-by: Barócsi Dénes 
Reviewed-by: Sungjong Seo 
Reviewed-by: Yuezhang Mo 
Signed-off-by: Namjae Jeon

exfat: fix inode->i_blocks for non-512 byte sector size device

2023-02-27T12:14:45+00:00

inode->i_blocks is not real number of blocks, but 512 byte ones.

Fixes: 98d917047e8b ("exfat: add file operations")
Cc: stable@vger.kernel.org # v5.7+
Reported-by: Wang Yugui 
Tested-by: Wang Yugui 
Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Signed-off-by: Namjae Jeon

exfat: redefine DIR_DELETED as the bad cluster number

2023-02-27T12:14:45+00:00

When a file or a directory is deleted, the hint for the cluster of
its parent directory in its in-memory inode is set as DIR_DELETED.
Therefore, DIR_DELETED must be one of invalid cluster numbers. According
to the exFAT specification, a volume can have at most 2^32-11 clusters.
However, DIR_DELETED is wrongly defined as 0xFFFF0321, which could be
a valid cluster number. To fix it, let's redefine DIR_DELETED as
0xFFFFFFF7, the bad cluster number.

Fixes: 1acf1a564b60 ("exfat: add in-memory and on-disk structures and headers")
Cc: stable@vger.kernel.org # v5.7+
Reported-by: Yuezhang Mo 
Signed-off-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: fix reporting fs error when reading dir beyond EOF

2023-02-27T12:14:45+00:00

Since seekdir() does not check whether the position is valid, the
position may exceed the size of the directory. We found that for
a directory with discontinuous clusters, if the position exceeds
the size of the directory and the excess size is greater than or
equal to the cluster size, exfat_readdir() will return -EIO,
causing a file system error and making the file system unavailable.

Reproduce this bug by:

seekdir(dir, dir_size + cluster_size);
dirent = readdir(dir);

The following log will be printed if mount with 'errors=remount-ro'.

[11166.712896] exFAT-fs (sdb1): error, invalid access to FAT (entry 0xffffffff)
[11166.712905] exFAT-fs (sdb1): Filesystem has been set read-only

Fixes: 1e5654de0f51 ("exfat: handle wrong stream entry size in exfat_readdir()")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Reviewed-by: Aoyama Wataru 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: fix unexpected EOF while reading dir

2023-02-27T12:14:44+00:00

If the position is not aligned with the dentry size, the return
value of readdir() will be NULL and errno is 0, which means the
end of the directory stream is reached.

If the position is aligned with dentry size, but there is no file
or directory at the position, exfat_readdir() will continue to
get dentry from the next dentry. So the dentry gotten by readdir()
may not be at the position.

After this commit, if the position is not aligned with the dentry
size, round the position up to the dentry size and continue to get
the dentry.

Fixes: ca06197382bd ("exfat: add directory operations")
Cc: stable@vger.kernel.org # v5.7+
Reported-by: Wang Yugui 
Signed-off-by: Yuezhang Mo 
Reviewed-by: Andy Wu 
Reviewed-by: Aoyama Wataru 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

Merge tag 'for-6.3/dio-2023-02-16' of git://git.kernel.dk/linux

2023-02-20T22:10:36+00:00

Pull legacy dio update from Jens Axboe:
 "We only have a few file systems that use the old dio code, make them
  select it rather than build it unconditionally"

* tag 'for-6.3/dio-2023-02-16' of git://git.kernel.dk/linux:
  fs: build the legacy direct I/O code conditionally
  fs: move sb_init_dio_done_wq out of direct-io.c