linux.git/fs/ecryptfs/messaging.c, branch v2.6.30

eCryptfs: NULL pointer dereference in ecryptfs_send_miscdev()

2009-04-22T08:54:13+00:00

If data is NULL, msg_ctx->msg is set to NULL and then dereferenced
afterwards.  ecryptfs_send_raw_message() is the only place that
ecryptfs_send_miscdev() is called with data being NULL, but the only
caller of that function (ecryptfs_process_helo()) is never called.  In
short, there is currently no way to trigger the NULL pointer
dereference.

This patch removes the two unused functions and modifies
ecryptfs_send_miscdev() to remove the NULL dereferences.

Signed-off-by: Tyler Hicks

ecryptfs: use kzfree()

2009-04-01T15:59:23+00:00

Use kzfree() instead of memset() + kfree().

Signed-off-by: Johannes Weiner 
Reviewed-by: Pekka Enberg 
Acked-by: Tyler Hicks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: Replace %Z with %z

2009-01-06T23:59:22+00:00

%Z is a gcc-ism. Using %z instead.

Signed-off-by: Michael Halcrow 
Cc: Dustin Kirkland 
Cc: Eric Sandeen 
Cc: Tyler Hicks 
Cc: David Kleikamp 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

User namespaces: set of cleanups (v2)

2008-11-24T23:57:41+00:00

The user_ns is moved from nsproxy to user_struct, so that a struct
cred by itself is sufficient to determine access (which it otherwise
would not be).  Corresponding ecryptfs fixes (by David Howells) are
here as well.

Fix refcounting.  The following rules now apply:
        1. The task pins the user struct.
        2. The user struct pins its user namespace.
        3. The user namespace pins the struct user which created it.

User namespaces are cloned during copy_creds().  Unsharing a new user_ns
is no longer possible.  (We could re-add that, but it'll cause code
duplication and doesn't seem useful if PAM doesn't need to clone user
namespaces).

When a user namespace is created, its first user (uid 0) gets empty
keyrings and a clean group_info.

This incorporates a previous patch by David Howells.  Here
is his original patch description:

>I suggest adding the attached incremental patch.  It makes the following
>changes:
>
> (1) Provides a current_user_ns() macro to wrap accesses to current's user
>     namespace.
>
> (2) Fixes eCryptFS.
>
> (3) Renames create_new_userns() to create_user_ns() to be more consistent
>     with the other associated functions and because the 'new' in the name is
>     superfluous.
>
> (4) Moves the argument and permission checks made for CLONE_NEWUSER to the
>     beginning of do_fork() so that they're done prior to making any attempts
>     at allocation.
>
> (5) Calls create_user_ns() after prepare_creds(), and gives it the new creds
>     to fill in rather than have it return the new root user.  I don't imagine
>     the new root user being used for anything other than filling in a cred
>     struct.
>
>     This also permits me to get rid of a get_uid() and a free_uid(), as the
>     reference the creds were holding on the old user_struct can just be
>     transferred to the new namespace's creator pointer.
>
> (6) Makes create_user_ns() reset the UIDs and GIDs of the creds under
>     preparation rather than doing it in copy_creds().
>
>David

>Signed-off-by: David Howells 

Changelog:
	Oct 20: integrate dhowells comments
		1. leave thread_keyring alone
		2. use current_user_ns() in set_user()

Signed-off-by: Serge Hallyn

CRED: Wrap task credential accesses in the eCryptFS filesystem

2008-11-13T23:38:49+00:00

Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: David Howells 
Reviewed-by: James Morris 
Acked-by: Serge Hallyn 
Cc: Mike Halcrow 
Cc: Phillip Hellewell 
Cc: ecryptfs-devel@lists.sourceforge.net
Signed-off-by: James Morris

eCryptfs: remove netlink transport

2008-10-16T18:21:39+00:00

The netlink transport code has not worked for a while and the miscdev
transport is a simpler solution.  This patch removes the netlink code and
makes the miscdev transport the only eCryptfs kernel to userspace
transport.

Signed-off-by: Tyler Hicks 
Cc: Michael Halcrow 
Cc: Dustin Kirkland 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: make key module subsystem respect namespaces

2008-04-29T15:06:07+00:00

Make eCryptfs key module subsystem respect namespaces.

Since I will be removing the netlink interface in a future patch, I just made
changes to the netlink.c code so that it will not break the build.  With my
recent patches, the kernel module currently defaults to the device handle
interface rather than the netlink interface.

[akpm@linux-foundation.org: export free_user_ns()]
Signed-off-by: Michael Halcrow 
Acked-by: Serge Hallyn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: integrate eCryptfs device handle into the module.

2008-04-29T15:06:07+00:00

Update the versioning information.  Make the message types generic.  Add an
outgoing message queue to the daemon struct.  Make the functions to parse
and write the packet lengths available to the rest of the module.  Add
functions to create and destroy the daemon structs.  Clean up some of the
comments and make the code a little more consistent with itself.

[akpm@linux-foundation.org: printk fixes]
Signed-off-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: fix unlocking in error paths

2007-12-23T20:54:37+00:00

Thanks to Josef Bacik for finding these.

A couple of ecryptfs error paths don't properly unlock things they locked.

Signed-off-by: Eric Sandeen 
Cc: Josef Bacik 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: remove assignments in if-statements

2007-10-16T16:43:12+00:00

Remove assignments in if-statements.

Signed-off-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds