linux.git/fs/ecryptfs/keystore.c, branch v3.19

eCryptfs: Remove unnecessary casts when parsing packet lengths

2014-10-29T23:32:59+00:00

The elements in the data array are already unsigned chars and do not
need to be casted.

Signed-off-by: Tyler Hicks 
Reported-by: Dan Carpenter

ecryptfs: remove unnecessary break after goto

2014-07-14T19:29:11+00:00

Signed-off-by: Fabian Frederick 
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Tyler Hicks

ecryptfs: Remove unnecessary include of syscall.h in keystore.c

2014-07-03T21:38:23+00:00

There's no reason to include syscalls.h in keystore.c. Remove it.

Signed-off-by: Steven Rostedt 
Signed-off-by: Tyler Hicks

ecryptfs: Fix memory leakage in keystore.c

2013-10-16T22:18:01+00:00

In 'decrypt_pki_encrypted_session_key' function:

Initializes 'payload' pointer and releases it on exit.

Signed-off-by: Geyslan G. Bem 
Signed-off-by: Tyler Hicks 
Cc: stable@vger.kernel.org # v2.6.28+

eCryptfs: allow userspace messaging to be disabled

2013-03-04T07:59:59+00:00

When the userspace messaging (for the less common case of userspace key
wrap/unwrap via ecryptfsd) is not needed, allow eCryptfs to build with
it removed. This saves on kernel code size and reduces potential attack
surface by removing the /dev/ecryptfs node.

Signed-off-by: Kees Cook 
Signed-off-by: Tyler Hicks

eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check

2013-02-12T18:06:01+00:00

smatch analysis:

fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info:
 redundant null check on msg calling kfree()

Cc: Dustin Kirkland 
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Tim Gardner 
Signed-off-by: Tyler Hicks

eCryptfs: initialize payload_len in keystore.c

2013-01-17T19:31:25+00:00

This is meant to remove a compiler warning.  It should not make any
functional change.

payload_len should be initialized when it is passed to
write_tag_64_packet() as a pointer.  If that call fails, this function
should return early, and payload_len won't be used.

Signed-off-by: Simon Que 
Signed-off-by: Tyler Hicks

eCryptfs: Improve statfs reporting

2012-02-16T22:06:21+00:00

statfs() calls on eCryptfs files returned the wrong filesystem type and,
when using filename encryption, the wrong maximum filename length.

If mount-wide filename encryption is enabled, the cipher block size and
the lower filesystem's max filename length will determine the max
eCryptfs filename length. Pre-tested, known good lengths are used when
the lower filesystem's namelen is 255 and a cipher with 8 or 16 byte
block sizes is used. In other, less common cases, we fall back to a safe
rounded-down estimate when determining the eCryptfs namelen.

https://launchpad.net/bugs/885744

Signed-off-by: Tyler Hicks 
Reported-by: Kees Cook 
Reviewed-by: Kees Cook 
Reviewed-by: John Johansen

eCryptfs: Replace miscdev read/write magic numbers

2012-01-25T20:43:40+00:00

ecryptfs_miscdev_read() and ecryptfs_miscdev_write() contained many
magic numbers for specifying packet header field sizes and offsets. This
patch defines those values and replaces the magic values.

Signed-off-by: Tyler Hicks

eCryptfs: Fix payload_len unitialized variable warning

2011-08-09T18:42:46+00:00

fs/ecryptfs/keystore.c: In function ‘ecryptfs_generate_key_packet_set’:
fs/ecryptfs/keystore.c:1991:28: warning: ‘payload_len’ may be used uninitialized in this function [-Wuninitialized]
fs/ecryptfs/keystore.c:1976:9: note: ‘payload_len’ was declared here

Signed-off-by: Tyler Hicks