linux.git/fs/ecryptfs/inode.c, branch v2.6.33

ecryptfs: pass matching flags to interpose as defined and used there

2010-01-20T04:36:02+00:00

ecryptfs_interpose checks if one of the flags passed is
ECRYPTFS_INTERPOSE_FLAG_D_ADD, defined as 0x00000001 in ecryptfs_kernel.h.
But the only user of ecryptfs_interpose to pass a non-zero flag to it, has
hard-coded the value as "1". This could spell trouble if any of these values
changes in the future.

Signed-off-by: Erez Zadok 
Cc: Dustin Kirkland 
Cc: Al Viro 
Signed-off-by: Tyler Hicks

ecryptfs: remove unnecessary d_drop calls in ecryptfs_link

2010-01-20T04:36:00+00:00

Unnecessary because it would unhash perfectly valid dentries, causing them
to have to be re-looked up the next time they're needed, which presumably is
right after.

Signed-off-by: Aseem Rastogi 
Signed-off-by: Shrikar archak 
Signed-off-by: Erez Zadok 
Cc: Saumitra Bhanage 
Cc: Al Viro 
Signed-off-by: Tyler Hicks

ecryptfs: don't ignore return value from lock_rename

2010-01-20T04:35:59+00:00

Signed-off-by: Erez Zadok 
Cc: Dustin Kirkland 
Cc: Andrew Morton 
Cc: Al Viro 
Signed-off-by: Tyler Hicks

eCryptfs: Add getattr function

2010-01-20T04:32:09+00:00

The i_blocks field of an eCryptfs inode cannot be trusted, but
generic_fillattr() uses it to instantiate the blocks field of a stat()
syscall when a filesystem doesn't implement its own getattr().  Users
have noticed that the output of du is incorrect on newly created files.

This patch creates ecryptfs_getattr() which calls into the lower
filesystem's getattr() so that eCryptfs can use its kstat.blocks value
after calling generic_fillattr().  It is important to note that the
block count includes the eCryptfs metadata stored in the beginning of
the lower file plus any padding used to fill an extent before
encryption.

https://bugs.launchpad.net/ecryptfs/+bug/390833

Reported-by: Dominic Sacré 
Signed-off-by: Tyler Hicks

eCryptfs: Use notify_change for truncating lower inodes

2010-01-20T04:32:07+00:00

When truncating inodes in the lower filesystem, eCryptfs directly
invoked vmtruncate(). As Christoph Hellwig pointed out, vmtruncate() is
a filesystem helper function, but filesystems may need to do more than
just a call to vmtruncate().

This patch moves the lower inode truncation out of ecryptfs_truncate()
and renames the function to truncate_upper().  truncate_upper() updates
an iattr for the lower inode to indicate if the lower inode needs to be
truncated upon return.  ecryptfs_setattr() then calls notify_change(),
using the updated iattr for the lower inode, to complete the truncation.

For eCryptfs functions needing to truncate, ecryptfs_truncate() is
reintroduced as a simple way to truncate the upper inode to a specified
size and then truncate the lower inode accordingly.

https://bugs.launchpad.net/bugs/451368

Reported-by: Christoph Hellwig 
Acked-by: Dustin Kirkland 
Cc: ecryptfs-devel@lists.launchpad.net
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Tyler Hicks

ecryptfs: Fix refcnt leak on ecryptfs_follow_link() error path

2010-01-14T14:05:26+00:00

If ->follow_link handler return the error, it should decrement
nd->path refcnt. But, ecryptfs_follow_link() doesn't decrement.

This patch fix it by using usual nd_set_link() style error handling,
instead of playing with nd->path.

Signed-off-by: OGAWA Hirofumi 
Signed-off-by: Al Viro

fsstack/ecryptfs: remove unused get_nlinks param to fsstack_copy_attr_all

2009-12-17T15:57:30+00:00

This get_nlinks parameter was never used by the only mainline user,
ecryptfs; and it has never been used by unionfs or wrapfs either.

Acked-by: Dustin Kirkland 
Acked-by: Tyler Hicks 
Signed-off-by: Erez Zadok 
Signed-off-by: Al Viro

eCryptfs: Prevent lower dentry from going negative during unlink

2009-09-23T14:10:34+00:00

When calling vfs_unlink() on the lower dentry, d_delete() turns the
dentry into a negative dentry when the d_count is 1.  This eventually
caused a NULL pointer deref when a read() or write() was done and the
negative dentry's d_inode was dereferenced in
ecryptfs_read_update_atime() or ecryptfs_getxattr().

Placing mutt's tmpdir in an eCryptfs mount is what initially triggered
the oops and I was able to reproduce it with the following sequence:

open("/tmp/upper/foo", O_RDWR|O_CREAT|O_EXCL|O_NOFOLLOW, 0600) = 3
link("/tmp/upper/foo", "/tmp/upper/bar") = 0
unlink("/tmp/upper/foo")                = 0
open("/tmp/upper/bar", O_RDWR|O_CREAT|O_NOFOLLOW, 0600) = 4
unlink("/tmp/upper/bar")                = 0
write(4, "eCryptfs test\n"..., 14 
+++ killed by SIGKILL +++

https://bugs.launchpad.net/ecryptfs/+bug/387073

Reported-by: Loïc Minier 
Cc: Serge Hallyn 
Cc: Dave Kleikamp 
Cc: ecryptfs-devel@lists.launchpad.net
Cc: stable 
Signed-off-by: Tyler Hicks

eCryptfs: Fix min function comparison warning

2009-04-27T18:31:12+00:00

This warning shows up on 64 bit builds:

fs/ecryptfs/inode.c:693: warning: comparison of distinct pointer types
lacks a cast

Signed-off-by: Tyler Hicks

ecryptfs: fix printk format warning

2009-04-27T18:10:06+00:00

fs/ecryptfs/inode.c:670: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'

Signed-off-by: Randy Dunlap 
Signed-off-by: Tyler Hicks 
Cc: Dustin Kirkland 
Signed-off-by: Andrew Morton