linux.git/fs/ecryptfs/inode.c, branch v2.6.26

ecryptfs: clean up (un)lock_parent

2008-05-13T15:02:23+00:00

dget(dentry->d_parent) --> dget_parent(dentry)

unlock_parent() is racy and unnecessary.  Replace single caller with
unlock_dir().

There are several other suspect uses of ->d_parent in ecryptfs...

Signed-off-by: Miklos Szeredi 
Cc: Michael Halcrow 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Remove duplicated unlikely() in IS_ERR()

2008-04-29T15:06:25+00:00

Some drivers have duplicated unlikely() macros.  IS_ERR() already has
unlikely() in itself.

This patch cleans up such pointless code.

Signed-off-by: Hirofumi Nakagawa 
Acked-by: David S. Miller 
Acked-by: Jeff Garzik 
Cc: Paul Clements 
Cc: Richard Purdie 
Cc: Alessandro Zummo 
Cc: David Brownell 
Cc: James Bottomley 
Cc: Michael Halcrow 
Cc: Anton Altaparmakov 
Cc: Al Viro 
Cc: Carsten Otte 
Cc: Patrick McHardy 
Cc: Paul Mundt 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Acked-by: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: add missing lock around notify_change

2008-04-29T15:06:07+00:00

Callers of notify_change() need to hold i_mutex.

Signed-off-by: Miklos Szeredi 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: replace remaining FUNCTION occurrences

2008-04-29T15:06:06+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Embed a struct path into struct nameidata instead of nd->{dentry,mnt}

2008-02-15T05:13:33+00:00

This is the central patch of a cleanup series. In most cases there is no good
reason why someone would want to use a dentry for itself. This series reflects
that fact and embeds a struct path into nameidata.

Together with the other patches of this series
- it enforced the correct order of getting/releasing the reference count on
   pairs
- it prepares the VFS for stacking support since it is essential to have a
  struct path in every place where the stack can be traversed
- it reduces the overall code size:

without patch series:
   text    data     bss     dec     hex filename
5321639  858418  715768 6895825  6938d1 vmlinux

with patch series:
   text    data     bss     dec     hex filename
5320026  858418  715768 6894212  693284 vmlinux

This patch:

Switch from nd->{dentry,mnt} to nd->path.{dentry,mnt} everywhere.

[akpm@linux-foundation.org: coding-style fixes]
[akpm@linux-foundation.org: fix cifs]
[akpm@linux-foundation.org: fix smack]
Signed-off-by: Jan Blunck 
Signed-off-by: Andreas Gruenbacher 
Acked-by: Christoph Hellwig 
Cc: Al Viro 
Cc: Casey Schaufler 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: Minor fixes to printk messages

2008-02-06T18:41:12+00:00

The printk statements that result when the user does not have the
proper key available could use some refining.

Signed-off-by: Mike Halcrow 
Cc: Mike Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: track header bytes rather than extents

2008-02-06T18:41:12+00:00

Remove internal references to header extents; just keep track of header bytes
instead.  Headers can easily span multiple pages with the recent persistent
file changes.

Signed-off-by: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/ecryptfs/: possible cleanups

2008-02-06T18:41:12+00:00

- make the following needlessly global code static:
  - crypto.c:ecryptfs_lower_offset_for_extent()
  - crypto.c:key_tfm_list
  - crypto.c:key_tfm_list_mutex
  - inode.c:ecryptfs_getxattr()
  - main.c:ecryptfs_init_persistent_file()

- remove the no longer used mmap.c:ecryptfs_lower_page_cache

- #if 0 the unused read_write.c:ecryptfs_read()

Signed-off-by: Adrian Bunk 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: fix dentry handling on create error, unlink, and inode destroy

2008-01-09T00:10:36+00:00

This patch corrects some erroneous dentry handling in eCryptfs.

If there is a problem creating the lower file, then there is nothing that
the persistent lower file can do to really help us.  This patch makes a
vfs_create() failure in the lower filesystem always lead to an
unconditional do_create failure in eCryptfs.

Under certain sequences of operations, the eCryptfs dentry can remain in
the dcache after an unlink.  This patch calls d_drop() on the eCryptfs
dentry to correct this.

eCryptfs has no business calling d_delete() directly on a lower
filesystem's dentry.  This patch removes the call to d_delete() on the
lower persistent file's dentry in ecryptfs_destroy_inode().

(Thanks to David Kleikamp, Eric Sandeen, and Jeff Moyer for helping
identify and resolve this issue)

Signed-off-by: Michael Halcrow 
Cc: Dave Kleikamp 
Cc: Eric Sandeen 
Cc: Jeff Moyer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: allow lower fs to interpret ATTR_KILL_S*ID

2007-10-18T21:37:21+00:00

Make sure ecryptfs doesn't trip the BUG() in notify_change.  This also allows
the lower filesystem to interpret ATTR_KILL_S*ID in its own way.

Signed-off-by: Jeff Layton 
Cc: Michael Halcrow 
Cc: Christoph Hellwig 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Cc: Chris Mason 
Cc: Jeff Mahoney 
Cc: "Vladimir V. Saveliev" 
Cc: Josef 'Jeff' Sipek 
Cc: Trond Myklebust 
Cc: Steven French 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

linux.git/fs/ecryptfs/inode.c, branch v2.6.26

ecryptfs: clean up (un)lock_parent

Remove duplicated unlikely() in IS_ERR()

ecryptfs: add missing lock around notify_change

ecryptfs: replace remaining __FUNCTION__ occurrences

Embed a struct path into struct nameidata instead of nd->{dentry,mnt}

eCryptfs: Minor fixes to printk messages

eCryptfs: track header bytes rather than extents

fs/ecryptfs/: possible cleanups

eCryptfs: fix dentry handling on create error, unlink, and inode destroy

ecryptfs: allow lower fs to interpret ATTR_KILL_S*ID

ecryptfs: replace remaining FUNCTION occurrences