linux.git/fs/dlm/lowcomms.c, branch v6.13

dlm: handle port as __be16 network byte order

2024-10-04T15:31:31+00:00

This patch handles the DLM listen port setting internally as byte order
as it is a value that is used as network byte on the wire. The user
space still sets this value as host byte order for configfs as we don't
break UAPI here.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: do synchronized socket connect call

2024-08-08T20:15:08+00:00

To avoid -EINPROGRESS cases on connect that just ends in a retry we just
call connect in a synchronized way to wait until its done. Since commit
dbb751ffab0b ("fs: dlm: parallelize lowcomms socket handling") we have a
non ordered workqueue running for serving the DLM sockets that allows us
to call send/recv for each DLM socket connection in parallel. Before
each worker needed to wait until the previous worker was done and
probably the reason why connect() was called in an asynchronous way to
not block other workers. This is however not necessary anymore as other
socket handling workers don't need to wait.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

fs: dlm: remove unused struct 'dlm_processed_nodes'

2024-06-12T20:50:29+00:00

The last use of 'dlm_processed_nodes' was removed in
commit 1696c75f1864 ("fs: dlm: add send ack threshold and append acks to
msgs").

Remove it.

Signed-off-by: Dr. David Alan Gilbert 
Signed-off-by: David Teigland

dlm: remove unused parameter in dlm_midcomms_addr

2024-05-31T16:04:54+00:00

This patch removes an parameter which is currently not used by
dlm_midcomms_addr().

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: do message processing in softirq context

2024-04-09T16:47:51+00:00

Move dlm message processing from an ordered workqueue context to an
ordered softirq context.  Handling dlm messages in softirq will allow
requests to be cleared more quickly and efficiently, and should avoid
longer queues of incomplete requests.  Later patches are expected to
run completion/blocking callbacks directly from this message processing
context, further reducing context switches required to complete a request.
In the longer term, concurrent message processing could be implemented.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: use spin_lock_bh for message processing

2024-04-09T16:45:23+00:00

Use spin_lock_bh for all spinlocks involved in message processing,
in preparation for softirq message processing.  DLM lock requests
from user space involve dlm processing in user context, in addition
to the standard kernel context, necessitating bh variants.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: remove allocation parameter in msg allocation

2024-04-09T14:58:14+00:00

Remove the context parameter for message allocations and
always use GFP_ATOMIC. This prepares for softirq message
processing.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: Simplify the allocation of slab caches in dlm_lowcomms_msg_cache_create

2024-04-02T20:24:40+00:00

Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan 
Acked-by: Alexander Aring 
Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland

dlm: use kernel_connect() and kernel_bind()

2023-11-16T17:58:42+00:00

Recent changes to kernel_connect() and kernel_bind() ensure that
callers are insulated from changes to the address parameter made by BPF
SOCK_ADDR hooks. This patch wraps direct calls to ops->connect() and
ops->bind() with kernel_connect() and kernel_bind() to protect callers
in such cases.

Link: https://lore.kernel.org/netdev/9944248dba1bce861375fcce9de663934d933ba9.camel@redhat.com/
Fixes: d74bad4e74ee ("bpf: Hooks for sys_connect")
Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
Cc: stable@vger.kernel.org
Signed-off-by: Jordan Rife 
Signed-off-by: David Teigland

dlm: slow down filling up processing queue

2023-10-12T20:21:00+00:00

If there is a burst of message the receive worker will filling up the
processing queue but where are too slow to process dlm messages. This
patch will slow down the receiver worker to keep the buffer on the
socket layer to tell the sender to backoff. This is done by a threshold
to get the next buffers from the socket after all messages were
processed done by a flush_workqueue(). This however only occurs when we
have a message burst when we e.g. create 1 million locks. If we put more
and more new messages to process in the processqueue we will soon run out
of memory.

Signed-off-by: Alexander Aring 
Signed-off-by: David Teigland