linux.git/fs/dlm/lockspace.c, branch v4.14

dlm: constify kset_uevent_ops structure

2017-08-07T16:23:09+00:00

Declare kset_uevent_ops structure as const as it is only passed as an
argument to the function kset_create_and_add. This argument is of type
const, so declare the structure as const.

Signed-off-by: Bhumika Goyal 
Signed-off-by: David Teigland

dlm: print log message when cluster name is not set

2017-08-07T16:23:09+00:00

Print a message when a cluster name is not specified by
the caller.  In this case the cluster name configured
for the dlm is used without any validation that it is
the cluster expected by the application.

Signed-off-by: Zhu Lingshan 
Signed-off-by: David Teigland

dlm: Make dismatch error message more clear

2017-08-07T16:23:09+00:00

This change will try to make this error message more clear,
since the upper applications (e.g. ocfs2) invoke dlm_new_lockspace
to create a new lockspace with passing a cluster name. Sometimes,
dlm_new_lockspace return failure while two cluster names dismatch,
the user is a little confused since this line error message is not
enough obvious.

Signed-off-by: Gang He 
Signed-off-by: David Teigland

dlm: audit and remove any unnecessary uses of module.h

2016-10-19T16:00:03+00:00

Historically a lot of these existed because we did not have
a distinction between what was modular code and what was providing
support to modules via EXPORT_SYMBOL and friends.  That changed
when we forked out support for the latter into the export.h file.
This means we should be able to reduce the usage of module.h
in code that is obj-y Makefile or bool Kconfig.

In the case of some code where it is modular, we can extend that to
also include files that are building basic support functionality but
not related to loading or registering the final module; such files
also have no need whatsoever for module.h

The advantage in removing such instances is that module.h itself
sources about 15 other headers; adding significantly to what we feed
cpp, and it can obscure what headers we are effectively using.

Since module.h might have been the implicit source for init.h
(for __init) and for export.h (for EXPORT_SYMBOL) we consider each
instance for the presence of either and replace as needed.

In the dlm case, we remove module.h from a global header and only
introduce it in the files where it is explicitly required, since
there is nothing modular in dlm_internal.h itself.

Signed-off-by: Paul Gortmaker 
Signed-off-by: David Teigland

fs/dlm/lockspace.c: convert simple_str to kstr

2014-06-06T23:08:18+00:00

Replace obsolete functions.

Signed-off-by: Fabian Frederick 
Cc: Christine Caulfield 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dlm: use INFO for recovery messages

2014-02-14T17:54:44+00:00

The log messages relating to the progress of recovery
are minimal and very often useful.  Change these to
the KERN_INFO level so they are always available.

Signed-off-by: David Teigland

dlm: Avoid that dlm_release_lockspace() incorrectly returns -EBUSY

2013-10-16T15:32:42+00:00

When dlm_release_lockspace(ls, 1) is invoked on a busy system
immediately after the last dlm_unlock() AST has finished it can occur
that lkb_idr_is_local() is invoked for the unlocked LKB since removal
from ls_lkbidr only occurs after the AST has returned. If that happens
dlm_release_lockspace(ls, 1) will return -EBUSY instead of releasing
the lockspace. Fix this race condition by changing lkb_idr_is_local()
such that it only returns true for LKB's that have not yet been
unlocked.

Signed-off-by: Bart Van Assche 
Signed-off-by: David Teigland

dlm: log an error for unmanaged lockspaces

2013-06-25T17:53:20+00:00

Log an error message if the dlm user daemon exits
before all the lockspaces have been removed.

Signed-off-by: David Teigland

dlm: don't use idr_remove_all()

2013-02-28T03:10:13+00:00

idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.

The conversion isn't completely trivial for recover_idr_clear() as it's
the only place in kernel which makes legitimate use of idr_remove_all()
w/o idr_destroy().  Replace it with idr_remove() call inside
idr_for_each_entry() loop.  It goes on top so that it matches the
operation order in recover_idr_del().

Signed-off-by: Tejun Heo 
Cc: Christine Caulfield 
Cc: David Teigland 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dlm: fix unlock balance warnings

2012-08-08T16:33:49+00:00

The in_recovery rw_semaphore has always been acquired and
released by different threads by design.  To work around
the "BUG: bad unlock balance detected!" messages, adjust
things so the dlm_recoverd thread always does both down_write
and up_write.

Signed-off-by: David Teigland