linux.git/fs/dlm/lock.c, branch v5.5

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 193

2019-05-30T18:29:21+00:00

Based on 1 normalized pattern(s):

  this copyrighted material is made available to anyone wishing to use
  modify copy or redistribute it subject to the terms and conditions
  of the gnu general public license v 2

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 45 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Richard Fontana 
Reviewed-by: Allison Randal 
Reviewed-by: Steve Winslow 
Reviewed-by: Alexios Zavras 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190528170027.342746075@linutronix.de
Signed-off-by: Greg Kroah-Hartman

dlm: memory leaks on error path in dlm_user_request()

2018-11-15T15:57:22+00:00

According to comment in dlm_user_request() ua should be freed
in dlm_free_lkb() after successful attach to lkb.

However ua is attached to lkb not in set_lock_args() but later,
inside request_lock().

Fixes 597d0cae0f99 ("[DLM] dlm: user locks")
Cc: stable@kernel.org # 2.6.19

Signed-off-by: Vasily Averin 
Signed-off-by: David Teigland

dlm: lost put_lkb on error path in receive_convert() and receive_unlock()

2018-11-15T15:57:22+00:00

Fixes 6d40c4a708e0 ("dlm: improve error and debug messages")
Cc: stable@kernel.org # 3.5

Signed-off-by: Vasily Averin 
Signed-off-by: David Teigland

dlm: possible memory leak on error path in create_lkb()

2018-11-15T15:57:22+00:00

Fixes 3d6aa675fff9 ("dlm: keep lkbs in idr")
Cc: stable@kernel.org # 3.1

Signed-off-by: Vasily Averin 
Signed-off-by: David Teigland

dlm: remove dlm_send_rcom_lookup_dump

2017-10-09T14:29:31+00:00

This function was only for debugging.  It would be
called in a condition that should not happen, and
should probably have been removed from the final
version of the original commit.

Remove it because it does mutex lock under spin lock.

Signed-off-by: David Teigland

DLM: fix conversion deadlock when DLM_LKF_NODLCKWT flag is set

2017-09-25T17:45:21+00:00

When the DLM_LKF_NODLCKWT flag was set, even if conversion deadlock
was detected, the caller of can_be_granted() was unknown.
We change the behavior of can_be_granted() and change it to detect
conversion deadlock regardless of whether the DLM_LKF_NODLCKWT flag
is set or not. And depending on whether the DLM_LKF_NODLCKWT flag
is set or not, we change the behavior at the caller of can_be_granted().

This fix has no effect except when using DLM_LKF_NODLCKWT flag.
Currently, ocfs2 uses the DLM_LKF_NODLCKWT flag and does not expect a
cancel operation from conversion deadlock when calling dlm_lock().
ocfs2 is implemented to perform a cancel operation by requesting
BASTs (callback).

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

dlm: Delete an error message for a failed memory allocation in dlm_recover_waiters_pre()

2017-08-07T16:23:09+00:00

Omit an extra message for a memory allocation failure in this function.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

dlm: Improve a size determination in dlm_recover_waiters_pre()

2017-08-07T16:23:09+00:00

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

dlm: Use kcalloc() in dlm_scan_waiters()

2017-08-07T16:23:09+00:00

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

ktime: Get rid of ktime_equal()

2016-12-25T16:21:23+00:00

No point in going through loops and hoops instead of just comparing the
values.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra