linux.git/fs/dlm/lock.c, branch v4.16

dlm: remove dlm_send_rcom_lookup_dump

2017-10-09T14:29:31+00:00

This function was only for debugging.  It would be
called in a condition that should not happen, and
should probably have been removed from the final
version of the original commit.

Remove it because it does mutex lock under spin lock.

Signed-off-by: David Teigland

DLM: fix conversion deadlock when DLM_LKF_NODLCKWT flag is set

2017-09-25T17:45:21+00:00

When the DLM_LKF_NODLCKWT flag was set, even if conversion deadlock
was detected, the caller of can_be_granted() was unknown.
We change the behavior of can_be_granted() and change it to detect
conversion deadlock regardless of whether the DLM_LKF_NODLCKWT flag
is set or not. And depending on whether the DLM_LKF_NODLCKWT flag
is set or not, we change the behavior at the caller of can_be_granted().

This fix has no effect except when using DLM_LKF_NODLCKWT flag.
Currently, ocfs2 uses the DLM_LKF_NODLCKWT flag and does not expect a
cancel operation from conversion deadlock when calling dlm_lock().
ocfs2 is implemented to perform a cancel operation by requesting
BASTs (callback).

Signed-off-by: Tadashi Miyauchi 
Signed-off-by: Tsutomu Owa 
Signed-off-by: David Teigland

dlm: Delete an error message for a failed memory allocation in dlm_recover_waiters_pre()

2017-08-07T16:23:09+00:00

Omit an extra message for a memory allocation failure in this function.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

dlm: Improve a size determination in dlm_recover_waiters_pre()

2017-08-07T16:23:09+00:00

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

dlm: Use kcalloc() in dlm_scan_waiters()

2017-08-07T16:23:09+00:00

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: David Teigland

ktime: Get rid of ktime_equal()

2016-12-25T16:21:23+00:00

No point in going through loops and hoops instead of just comparing the
values.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra

ktime: Cleanup ktime_set() usage

2016-12-25T16:21:22+00:00

ktime_set(S,N) was required for the timespec storage type and is still
useful for situations where a Seconds and Nanoseconds part of a time value
needs to be converted. For anything where the Seconds argument is 0, this
is pointless and can be replaced with a simple assignment.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra

dlm: adopt orphan locks

2014-11-19T20:48:02+00:00

A process may exit, leaving an orphan lock in the lockspace.
This adds the capability for another process to acquire the
orphan lock.  Acquiring the orphan just moves the lock from
the orphan list onto the acquiring process's list of locks.

An adopting process must specify the resource name and mode
of the lock it wants to adopt.  If a matching lock is found,
the lock is moved to the caller's 's list of locks, and the
lkid of the lock is returned like the lkid of a new lock.

If an orphan with a different mode is found, then -EAGAIN is
returned.  If no orphan lock is found on the resource, then
-ENOENT is returned.  No async completion is used because
the result is immediately available.

Also, when orphans are purged, allow a zero nodeid to refer
to the local nodeid so the caller does not need to look up
the local nodeid.

Signed-off-by: David Teigland

dlm: use INFO for recovery messages

2014-02-14T17:54:44+00:00

The log messages relating to the progress of recovery
are minimal and very often useful.  Change these to
the KERN_INFO level so they are always available.

Signed-off-by: David Teigland

dlm: silence a harmless use after free warning

2014-02-12T21:44:03+00:00

We pass the freed "r" pointer back to the caller.  It's harmless but it
upsets the static checkers.

Signed-off-by: Dan Carpenter 
Signed-off-by: David Teigland