linux.git/fs/debugfs/file.c, branch v6.6

debugfs: Add write support to debugfs_create_str()

2023-08-22T18:04:07+00:00

Currently, debugfs_create_str() only supports reading strings from
debugfs. Add support for writing them as well.

Based on original implementation by Peter Zijlstra [0]. Write support
was present in the initial patch version, but dropped in v2 due to lack
of users. We have a user now, so reintroduce it.

[0] https://lore.kernel.org/all/YF3Hv5zXb%2F6lauzs@hirez.programming.kicks-ass.net/

Signed-off-by: Mike Tipton 
Acked-by: Greg Kroah-Hartman 
Link: https://lore.kernel.org/r/20230807142914.12480-2-quic_mdtipton@quicinc.com
Signed-off-by: Georgi Djakov

debugfs: Correct the 'debugfs_create_str' docs

2023-05-31T18:02:14+00:00

The documentation of the 'debugfs_create_str' says that the function
returns a pointer to a dentry created, or an ERR_PTR in case of error.
Actually, this is not true: this function doesn't return anything at all.
Correct the documentation correspondingly.

Signed-off-by: Ivan Orlov 
Link: https://lore.kernel.org/r/20230514172353.52878-1-ivan.orlov0322@gmail.com
Signed-off-by: Greg Kroah-Hartman

debugfs: Export debugfs_create_str symbol

2023-01-20T11:41:00+00:00

Needed by SCMI Raw mode support when compiled as a loadable module.

Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Cristian Marussi 
Tested-by: Florian Fainelli 
Tested-by: Vincent Guittot 
Acked-by: Greg Kroah-Hartman 
Link: https://lore.kernel.org/r/20230118121426.492864-10-cristian.marussi@arm.com
Signed-off-by: Sudeep Holla

debugfs: fix error when writing negative value to atomic_t debugfs file

2022-12-01T00:13:16+00:00

The simple attribute files do not accept a negative value since the commit
488dac0c9237 ("libfs: fix error cast of negative value in
simple_attr_write()"), so we have to use a 64-bit value to write a
negative value for a debugfs file created by debugfs_create_atomic_t().

This restores the previous behaviour by introducing
DEFINE_DEBUGFS_ATTRIBUTE_SIGNED for a signed value.

Link: https://lkml.kernel.org/r/20220919172418.45257-4-akinobu.mita@gmail.com
Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()")
Signed-off-by: Akinobu Mita 
Reported-by: Zhao Gongyi 
Reviewed-by: David Hildenbrand 
Reviewed-by: Greg Kroah-Hartman 
Cc: Alexander Viro 
Cc: Jonathan Corbet 
Cc: Oscar Salvador 
Cc: Rafael J. Wysocki 
Cc: Shuah Khan 
Cc: Wei Yongjun 
Cc: Yicong Yang 
Signed-off-by: Andrew Morton

debugfs: use DEFINE_SHOW_ATTRIBUTE to define debugfs_regset32_fops

2022-09-24T13:00:48+00:00

Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.

Signed-off-by: ChenXiaoSong 
Link: https://lore.kernel.org/r/20220923102554.2443452-1-chenxiaosong2@huawei.com
Signed-off-by: Greg Kroah-Hartman

debugfs: lockdown: Allow reading debugfs files that are not world readable

2022-01-06T14:47:41+00:00

When the kernel is locked down the kernel allows reading only debugfs
files with mode 444. Mode 400 is also valid but is not allowed.

Make the 444 into a mask.

Fixes: 5496197f9b08 ("debugfs: Restrict debugfs when the kernel is locked down")
Signed-off-by: Michal Suchanek 
Link: https://lore.kernel.org/r/20220104170505.10248-1-msuchanek@suse.de
Signed-off-by: Greg Kroah-Hartman

debugfs: Return error during {full/open}_proxy_open() on rmmod

2021-08-05T12:42:40+00:00

If a kernel module gets unloaded then it printed report about a leak before
commit 275678e7a9be ("debugfs: Check module state before warning in
{full/open}_proxy_open()"). An additional check was added in this commit to
avoid this printing. But it was forgotten that the function must return an
error in this case because it was not actually opened.

As result, the systems started to crash or to hang when a module was
unloaded while something was trying to open a file.

Fixes: 275678e7a9be ("debugfs: Check module state before warning in {full/open}_proxy_open()")
Cc: Taehee Yoo 
Reported-by: Mário Lopes 
Signed-off-by: Sven Eckelmann 
Link: https://lore.kernel.org/r/20210802162444.7848-1-sven@narfation.org
Signed-off-by: Greg Kroah-Hartman

Merge tag 'v5.13-rc6' into driver-core-next

2021-06-14T07:07:45+00:00

We need the driver core fix in here as well.

Signed-off-by: Greg Kroah-Hartman

debugfs: Fix debugfs_read_file_str()

2021-06-04T13:01:08+00:00

Read the entire size of the buffer, including the trailing new line
character.
Discovered while reading the sched domain names of CPU0:

before:

cat /sys/kernel/debug/sched/domains/cpu0/domain*/name
SMTMCDIE

after:

cat /sys/kernel/debug/sched/domains/cpu0/domain*/name
SMT
MC
DIE

Fixes: 9af0440ec86eb ("debugfs: Implement debugfs_create_str()")
Reviewed-by: Steven Rostedt (VMware) 
Acked-by: Peter Zijlstra (Intel) 
Signed-off-by: Dietmar Eggemann 
Link: https://lore.kernel.org/r/20210527091105.258457-1-dietmar.eggemann@arm.com
Signed-off-by: Greg Kroah-Hartman

debugfs: remove return value of debugfs_create_ulong()

2021-05-21T18:59:55+00:00

No one checks the return value of debugfs_create_ulong(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20210521184340.1348539-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman