linux.git/fs/crypto/crypto.c, branch v4.10 Linux kernel source tree fscrypt: Rename FS_WRITE_PATH_FL to FS_CTX_HAS_BOUNCE_BUFFER_FL 2016-12-11T21:33:18+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:58+00:00 6a34e4d2be07255cc59e6ccaf820669cfd7f815c ... to better explain its purpose after introducing in-place encryption without bounce buffer. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
... to better explain its purpose after introducing in-place encryption
without bounce buffer.

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Delay bounce page pool allocation until needed 2016-12-11T21:33:11+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:57+00:00 f32d7ac20a5864483c1f96e4970daa083e18bfd1 Since fscrypt users can now indicated if fscrypt_encrypt_page() should use a bounce page, we can delay the bounce page pool initialization util it is really needed. That is until fscrypt_operations has no FS_CFLG_OWN_PAGES flag set. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
Since fscrypt users can now indicated if fscrypt_encrypt_page() should
use a bounce page, we can delay the bounce page pool initialization util
it is really needed. That is until fscrypt_operations has no
FS_CFLG_OWN_PAGES flag set.

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Cleanup page locking requirements for fscrypt_{decrypt,encrypt}_page() 2016-12-11T21:26:12+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:56+00:00 bd7b8290388dd58a8c0a3710b171e58ef952ca4d Rename the FS_CFLG_INPLACE_ENCRYPTION flag to FS_CFLG_OWN_PAGES which, when set, indicates that the fs uses pages under its own control as opposed to writeback pages which require locking and a bounce buffer for encryption. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
Rename the FS_CFLG_INPLACE_ENCRYPTION flag to FS_CFLG_OWN_PAGES which,
when set, indicates that the fs uses pages under its own control as
opposed to writeback pages which require locking and a bounce buffer for
encryption.

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Cleanup fscrypt_{decrypt,encrypt}_page() 2016-12-11T21:26:12+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:55+00:00 1400451f04f2ff28b658b92557495e5090914aee - Improve documentation - Add BUG_ON(len == 0) to avoid accidental switch of offs and len parameters - Improve variable names for readability Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
- Improve documentation
- Add BUG_ON(len == 0) to avoid accidental switch of offs and len
parameters
- Improve variable names for readability

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Never allocate fscrypt_ctx on in-place encryption 2016-12-11T21:26:11+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:54+00:00 9e532772b4e36888584efc7a9531143bd43355b3 In case of in-place encryption fscrypt_ctx was allocated but never released. Since we don't need it for in-place encryption, we skip allocating it. Fixes: 1c7dcf69eea3 ("fscrypt: Add in-place encryption mode") Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
In case of in-place encryption fscrypt_ctx was allocated but never
released. Since we don't need it for in-place encryption, we skip
allocating it.

Fixes: 1c7dcf69eea3 ("fscrypt: Add in-place encryption mode")

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Use correct index in decrypt path. 2016-12-11T21:26:10+00:00 David Gstir david@sigma-star.at 2016-12-06T22:53:53+00:00 e550c16c8aab95c7996b0c864d5fcedc2c430a43 Actually use the fs-provided index instead of always using page->index which is only set for page-cache pages. Fixes: 9c4bb8a3a9b4 ("fscrypt: Let fs select encryption index/tweak") Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
Actually use the fs-provided index instead of always using page->index
which is only set for page-cache pages.

Fixes: 9c4bb8a3a9b4 ("fscrypt: Let fs select encryption index/tweak")

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: move non-public structures and constants to fscrypt_private.h 2016-12-11T21:26:09+00:00 Theodore Ts'o tytso@mit.edu 2016-11-27T03:05:18+00:00 cc4e0df038ddb73510c01712abf302b3f0130147 Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Eric Biggers <ebiggers@google.com> 
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Eric Biggers <ebiggers@google.com>
fscrypt: unexport fscrypt_initialize() 2016-12-11T21:26:08+00:00 Theodore Ts'o tytso@mit.edu 2016-11-27T01:43:09+00:00 b98701df349b7003efd52d9330acbb7be5a255c6 The fscrypt_initalize() function isn't used outside fs/crypto, so there's no point making it be an exported symbol. Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Eric Biggers <ebiggers@google.com> 
The fscrypt_initalize() function isn't used outside fs/crypto, so
there's no point making it be an exported symbol.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Eric Biggers <ebiggers@google.com>
fscrypt: Let fs select encryption index/tweak 2016-11-14T01:18:16+00:00 David Gstir david@sigma-star.at 2016-11-13T21:20:48+00:00 9c4bb8a3a9b4de21753053d667310c2b7cb39916 Avoid re-use of page index as tweak for AES-XTS when multiple parts of same page are encrypted. This will happen on multiple (partial) calls of fscrypt_encrypt_page on same page. page->index is only valid for writeback pages. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
Avoid re-use of page index as tweak for AES-XTS when multiple parts of
same page are encrypted. This will happen on multiple (partial) calls of
fscrypt_encrypt_page on same page.
page->index is only valid for writeback pages.

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fscrypt: Constify struct inode pointer 2016-11-14T01:18:01+00:00 David Gstir david@sigma-star.at 2016-11-13T21:20:47+00:00 0b93e1b94b86f826d18a2aaf219a53e271274d49 Some filesystems, such as UBIFS, maintain a const pointer for struct inode. Signed-off-by: David Gstir <david@sigma-star.at> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Theodore Ts'o <tytso@mit.edu> 
Some filesystems, such as UBIFS, maintain a const pointer for struct
inode.

Signed-off-by: David Gstir <david@sigma-star.at>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>