linux.git/fs/configfs/file.c, branch v4.2

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15T19:06:57+00:00

that's the bulk of filesystem drivers dealing with inodes of their own

Signed-off-by: David Howells 
Signed-off-by: Al Viro

configfs_add_file: fold into its sole caller

2015-02-18T03:16:46+00:00

Signed-off-by: Al Viro

configfs: use capped length for ->store_attribute()

2013-07-03T23:07:23+00:00

The difference between "count" and "len" is that "len" is capped at
4095.  Changing it like this makes it match how sysfs_write_file() is
implemented.

This is a static analysis patch.  I haven't found any store_attribute()
functions where this change makes a difference.

Signed-off-by: Dan Carpenter 
Acked-by: Joel Becker 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs: replace remaining FUNCTION occurrences

2008-04-30T15:29:54+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

configfs: file.c fix possible recursive locking

2008-01-25T23:05:47+00:00

configfs_register_subsystem() with default_groups triggers recursive locking.
it seems that mutex_lock_nested is needed.

=============================================
[ INFO: possible recursive locking detected ]
2.6.24-rc6 #145
---------------------------------------------
swapper/1 is trying to acquire lock:
 (&sb->s_type->i_mutex_key#3){--..}, at: [] configfs_add_file+0x2e/0x70

but task is already holding lock:
 (&sb->s_type->i_mutex_key#3){--..}, at: [] configfs_register_subsystem+0x55/0x130

other info that might help us debug this:
1 lock held by swapper/1:
 #0:  (&sb->s_type->i_mutex_key#3){--..}, at: [] configfs_register_subsystem+0x55/0x130

stack backtrace:
Pid: 1, comm: swapper Not tainted 2.6.24-rc6 #145
 [] show_trace_log_lvl+0x1a/0x30
 [] show_trace+0x12/0x20
 [] dump_stack+0x6e/0x80
 [] __lock_acquire+0xe62/0x1120
 [] lock_acquire+0x82/0xa0
 [] mutex_lock_nested+0x98/0x2e0
 [] configfs_add_file+0x2e/0x70
 [] configfs_create_file+0x2c/0x40
 [] configfs_attach_item+0x139/0x220
 [] configfs_attach_group+0x14/0x140
 [] configfs_attach_group+0xc9/0x140
 [] configfs_register_subsystem+0xc6/0x130
 [] init_netconsole+0x2b6/0x300
 [] kernel_init+0x142/0x320
 [] kernel_thread_helper+0x7/0x14
 =======================

Signed-off-by: Joonwoo Park 
Signed-off-by: Joel Becker 
Signed-off-by: Mark Fasheh

[PATCH] configsfs buffer: use mutex

2007-07-11T00:10:58+00:00

Seems copied from sysfs, but I don't see a reason here nor there to use
a semaphore instead of a mutex. Convert.

Signed-off-by: Johannes Berg 
Signed-off-by: Joel Becker 
Signed-off-by: Mark Fasheh

configfs: consistent attribute size

2007-07-10T23:52:22+00:00

The attribute store/show code currently limits attributes at PAGE_SIZE.
This code comes from sysfs, where it still works that way.

However, PAGE_SIZE is not constant.  A 16k attribute string works on
ia64 but not on x86.  Really a subsystem shouldn't allow different
attribute sizes based on platform.

As such, limit all simple attributes to 4k.  This works on all
platforms, and is consistent with all current code.

Signed-off-by: Joel Becker 
Signed-off-by: Mark Fasheh

use simple_read_from_buffer() in fs/

2007-05-09T19:30:49+00:00

Cleanup using simple_read_from_buffer() in binfmt_misc, configfs, and sysfs.

Cc: Greg Kroah-Hartman 
Cc: Joel Becker 
Signed-off-by: Akinobu Mita 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

configfs: Zero terminate data in configfs attribute writes.

2007-02-07T20:17:08+00:00

Attributes in configfs are text files.  As such, most handlers expect to be
able to call functions like simple_strtoul() without checking the bounds
of the buffer.  Change the call to zero terminate the buffer before calling
the client's ->store() method.  This does reduce the attribute size from
PAGE_SIZE to PAGE_SIZE-1.

Also, change get_zeroed_page() to alloc_page(), as we are handling the
termination.

Signed-off-by: Joel Becker 
Signed-off-by: Mark Fasheh

[PATCH] configfs: change uses of f_{dentry, vfsmnt} to use f_path

2006-12-08T16:28:43+00:00

Change all the uses of f_{dentry,vfsmnt} to f_path.{dentry,mnt} in the
configfs filesystem.

Signed-off-by: Josef "Jeff" Sipek 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds