linux.git/fs/compat.c, branch v2.6.17

[PATCH] NFS: fix error handling on access_ok in compat_sys_nfsservctl

2006-05-21T19:59:16+00:00

Functions compat_nfs_svc_trans, compat_nfs_clnt_trans,
compat_nfs_exp_trans, compat_nfs_getfd_trans and compat_nfs_getfs_trans,
which are called by compat_sys_nfsservctl(fs/compat.c), don't handle the
return value of access_ok properly.  access_ok return 1 when the addr is
valid, and 0 when it's not, but these functions have the reversed
understanding.  When the address is valid, they always return -EFAULT to
compat_sys_nfsservctl.

An example is to run /usr/sbin/rpc.nfsd(32bit program on Power5).  It
doesn't function as expected.  strace showes that nfsservctl returns
-EFAULT.

The patch fixes this by correcting the error handling on the return value
of access_ok in the five functions.

Signed-off-by: Lin Feng Shen 
Cc: Trond Myklebust 
Acked-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fs/compat.c: fix 'if (a |= b )' typo

2006-05-15T18:20:57+00:00

Mentioned by Mark Armbrust somewhere on Usenet.

Signed-off-by: Alexey Dobriyan 
Cc: David Woodhouse 
Cc: Ulrich Drepper 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] compat_sys_vmsplice: one-off in UIO_MAXIOV check

2006-05-04T07:13:49+00:00

nr_segs may not be > UIO_MAXIOV, however it may be equal to. This makes
the behaviour identical to the real sys_vmsplice(). The other foov
syscalls also agree that this is the way to go.

Signed-off-by: Jens Axboe

[PATCH] x86_64: Add compat_sys_vmsplice and use it in x86-64

2006-05-02T01:17:43+00:00

Signed-off-by: Andi Kleen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] LSM: add missing hook to do_compat_readv_writev()

2006-04-26T14:52:21+00:00

This patch addresses a flaw in LSM, where there is no mediation of readv()
and writev() in for 32-bit compatible apps using a 64-bit kernel.

This bug was discovered and fixed initially in the native readv/writev
code [1], but was not fixed in the compat code.  Thanks to Al for spotting
this one.

  [1] http://lwn.net/Articles/154282/

Signed-off-by: James Morris 
Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[PATCH] Fold select_bits_alloc/free into caller code.

2006-03-28T17:16:04+00:00

Remove an unnecessary level of indirection in allocating and freeing select
bits, as per the select_bits_alloc() and select_bits_free() functions.
Both select.c and compat.c are updated.

Signed-off-by: Vadim Lobanov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] use kzalloc and kcalloc in core fs code

2006-03-25T16:23:00+00:00

Signed-off-by: Oliver Neukum 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] compat_sys_nfsservctl(): handle errors correctly

2006-03-25T16:22:59+00:00

Correct some error handling on the compat version of the nfsservctl()
system.  It was detecting errors while copying in the arguments from user
space, but then attempting to use the arguments anyway.  This didn't seem
so good.

Signed-off-by: Peter Staubach 
Cc: Trond Myklebust 
Cc: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Conditionalize compat_sys_newfstatat

2006-03-24T15:33:27+00:00

If we don't want sys_newfstatat because __ARCH_WANT_STAT64 is defined, then
we certainly don't want compat_sys_newfstatat either.

Signed-off-by: Grant Grundler 
Signed-off-by: Kyle McMartin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] select: time comparison fixes

2006-02-17T21:59:28+00:00

I got all of these backwards.  We want to return

	min(input timeout, new timeout)

to userspace to prevent increasing the time-remaining value.

Thanks to Ernst Herzberg  for reporting and diagnosing.

Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds