linux.git/fs/cifs, branch v6.0

cifs: update internal module number

2022-09-14T09:00:06+00:00

To 2.39

Signed-off-by: Steve French

cifs: add missing spinlock around tcon refcount

2022-09-14T08:59:51+00:00

Add missing spinlock to protect updates on tcon refcount in
cifs_put_tcon().

Fixes: d7d7a66aacd6 ("cifs: avoid use of global locks for high contention data")
Signed-off-by: Paulo Alcantara (SUSE) 
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: always initialize struct msghdr smb_msg completely

2022-09-14T03:55:45+00:00

So far we were just lucky because the uninitialized members
of struct msghdr are not used by default on a SOCK_STREAM tcp
socket.

But as new things like msg_ubuf and sg_from_iter where added
recently, we should play on the safe side and avoid potention
problems in future.

Signed-off-by: Stefan Metzmacher 
Cc: stable@vger.kernel.org
Reviewed-by: Paulo Alcantara (SUSE) 
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: don't send down the destination address to sendmsg for a SOCK_STREAM

2022-09-14T03:55:15+00:00

This is ignored anyway by the tcp layer.

Signed-off-by: Stefan Metzmacher 
Cc: stable@vger.kernel.org
Reviewed-by: Ronnie Sahlberg 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: revalidate mapping when doing direct writes

2022-09-12T18:24:08+00:00

Kernel bugzilla: 216301

When doing direct writes we need to also invalidate the mapping in case
we have a cached copy of the affected page(s) in memory or else
subsequent reads of the data might return the old/stale content
before we wrote an update to the server.

Cc: stable@vger.kernel.org
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: fix small mempool leak in SMB2_negotiate()

2022-08-31T01:08:13+00:00

In some cases of failure (dialect mismatches) in SMB2_negotiate(), after
the request is sent, the checks would return -EIO when they should be
rather setting rc = -EIO and jumping to neg_exit to free the response
buffer from mempool.

Signed-off-by: Enzo Matsumiya 
Cc: stable@vger.kernel.org
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Steve French

smb3: use filemap_write_and_wait_range instead of filemap_write_and_wait

2022-08-30T22:10:29+00:00

When doing insert range and collapse range we should be
writing out the cached pages for the ranges affected but not
the whole file.

Fixes: c3a72bb21320 ("smb3: Move the flush out of smb2_copychunk_range() into its callers")
Cc: stable@vger.kernel.org
Reviewed-by: Paulo Alcantara (SUSE) 
Reviewed-by: David Howells 
Signed-off-by: Steve French

smb3: fix temporary data corruption in insert range

2022-08-29T03:34:08+00:00

insert range doesn't discard the affected cached region
so can risk temporarily corrupting file data.

Also includes some minor cleanup (avoiding rereading
inode size repeatedly unnecessarily) to make it clearer.

Cc: stable@vger.kernel.org
Fixes: 7fe6fe95b936 ("cifs: add FALLOC_FL_INSERT_RANGE support")
Signed-off-by: David Howells 
cc: Ronnie Sahlberg 
Signed-off-by: Steve French

smb3: fix temporary data corruption in collapse range

2022-08-29T03:34:07+00:00

collapse range doesn't discard the affected cached region
so can risk temporarily corrupting the file data. This
fixes xfstest generic/031

I also decided to merge a minor cleanup to this into the same patch
(avoiding rereading inode size repeatedly unnecessarily) to make it
clearer.

Cc: stable@vger.kernel.org
Fixes: 5476b5dd82c8b ("cifs: add support for FALLOC_FL_COLLAPSE_RANGE")
Reported-by: David Howells 
Tested-by: David Howells 
Reviewed-by: David Howells 
cc: Ronnie Sahlberg 
Signed-off-by: Steve French

smb3: Move the flush out of smb2_copychunk_range() into its callers

2022-08-29T03:34:07+00:00

Move the flush out of smb2_copychunk_range() into its callers.  This will
allow the pagecache to be invalidated between the flush and the operation
in smb3_collapse_range() and smb3_insert_range().

Signed-off-by: David Howells 
cc: Ronnie Sahlberg 
Signed-off-by: Steve French