linux.git/fs/cifs, branch v5.3

cifs: update internal module number

2019-08-27T22:29:56+00:00

To 2.22

Signed-off-by: Steve French

cifs: replace various strncpy with strscpy and similar

2019-08-27T22:25:12+00:00

Using strscpy is cleaner, and avoids some problems with
handling maximum length strings.  Linus noticed the
original problem and Aurelien pointed out some additional
problems. Fortunately most of this is SMB1 code (and
in particular the ASCII string handling older, which
is less common).

Reported-by: Linus Torvalds 
Reviewed-by: Aurelien Aptel 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: Use kzfree() to zero out the password

2019-08-27T21:44:27+00:00

It's safer to zero out the password so that it can never be disclosed.

Fixes: 0c219f5799c7 ("cifs: set domainName when a domain-key is used in multiuser")
Signed-off-by: Dan Carpenter 
Signed-off-by: Steve French

cifs: set domainName when a domain-key is used in multiuser

2019-08-27T21:44:24+00:00

RHBZ: 1710429

When we use a domain-key to authenticate using multiuser we must also set
the domainnmame for the new volume as it will be used and passed to the server
in the NTLMSSP Domain-name.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

signal: Allow cifs and drbd to receive their terminating signals

2019-08-19T11:34:13+00:00

My recent to change to only use force_sig for a synchronous events
wound up breaking signal reception cifs and drbd.  I had overlooked
the fact that by default kthreads start out with all signals set to
SIG_IGN.  So a change I thought was safe turned out to have made it
impossible for those kernel thread to catch their signals.

Reverting the work on force_sig is a bad idea because what the code
was doing was very much a misuse of force_sig.  As the way force_sig
ultimately allowed the signal to happen was to change the signal
handler to SIG_DFL.  Which after the first signal will allow userspace
to send signals to these kernel threads.  At least for
wake_ack_receiver in drbd that does not appear actively wrong.

So correct this problem by adding allow_kernel_signal that will allow
signals whose siginfo reports they were sent by the kernel through,
but will not allow userspace generated signals, and update cifs and
drbd to call allow_kernel_signal in an appropriate place so that their
thread can receive this signal.

Fixing things this way ensures that userspace won't be able to send
signals and cause problems, that it is clear which signals the
threads are expecting to receive, and it guarantees that nothing
else in the system will be affected.

This change was partly inspired by similar cifs and drbd patches that
added allow_signal.

Reported-by: ronnie sahlberg 
Reported-by: Christoph Böhmwalder 
Tested-by: Christoph Böhmwalder 
Cc: Steve French 
Cc: Philipp Reisner 
Cc: David Laight 
Fixes: 247bc9470b1e ("cifs: fix rmmod regression in cifs.ko caused by force_sig changes")
Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig")
Fixes: fee109901f39 ("signal/drbd: Use send_sig not force_sig")
Fixes: 3cf5d076fb4d ("signal: Remove task parameter from force_sig")
Signed-off-by: "Eric W. Biederman"

SMB3: Kernel oops mounting a encryptData share with CONFIG_DEBUG_VIRTUAL

2019-08-06T03:50:38+00:00

Fix kernel oops when mounting a encryptData CIFS share with
CONFIG_DEBUG_VIRTUAL

Signed-off-by: Sebastien Tisserant 
Reviewed-by: Pavel Shilovsky 
Signed-off-by: Steve French

smb3: send CAP_DFS capability during session setup

2019-08-06T03:50:38+00:00

We had a report of a server which did not do a DFS referral
because the session setup Capabilities field was set to 0
(unlike negotiate protocol where we set CAP_DFS).  Better to
send it session setup in the capabilities as well (this also
more closely matches Windows client behavior).

Signed-off-by: Steve French 
Reviewed-off-by: Ronnie Sahlberg 
Reviewed-by: Pavel Shilovsky 
CC: Stable

SMB3: Fix potential memory leak when processing compound chain

2019-08-06T03:50:13+00:00

When a reconnect happens in the middle of processing a compound chain
the code leaks a buffer from the memory pool. Fix this by properly
checking for a return code and freeing buffers in case of error.

Also maintain a buf variable to be equal to either smallbuf or bigbuf
depending on a response buffer size while parsing a chain and when
returning to the caller.

Signed-off-by: Pavel Shilovsky 
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Steve French

SMB3: Fix deadlock in validate negotiate hits reconnect

2019-08-06T03:49:54+00:00

Currently we skip SMB2_TREE_CONNECT command when checking during
reconnect because Tree Connect happens when establishing
an SMB session. For SMB 3.0 protocol version the code also calls
validate negotiate which results in SMB2_IOCL command being sent
over the wire. This may deadlock on trying to acquire a mutex when
checking for reconnect. Fix this by skipping SMB2_IOCL command
when doing the reconnect check.

Signed-off-by: Pavel Shilovsky 
Signed-off-by: Steve French 
Reviewed-by: Ronnie Sahlberg 
CC: Stable

cifs: fix rmmod regression in cifs.ko caused by force_sig changes

2019-08-05T03:02:29+00:00

Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig")

The global change from force_sig caused module unloading of cifs.ko
to fail (since the cifsd process could not be killed, "rmmod cifs"
now would always fail)

Signed-off-by: Steve French 
Reviewed-by: Ronnie Sahlberg 
CC: Eric W. Biederman