linux.git/fs/cifs, branch v5.16

cifs: sanitize multiple delimiters in prepath

2021-12-18T01:16:49+00:00

mount.cifs can pass a device with multiple delimiters in it. This will
cause rename(2) to fail with ENOENT.

V2:
  - Make sanitize_path more readable.
  - Fix multiple delimiters between UNC and prepath.
  - Avoid a memory leak if a bad user starts putting a lot of delimiters
    in the path on purpose.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=2031200
Fixes: 24e0a1eff9e2 ("cifs: switch to new mount api")
Cc: stable@vger.kernel.org # 5.11+
Acked-by: Ronnie Sahlberg 
Signed-off-by: Thiago Rafael Becker 
Signed-off-by: Steve French

cifs: ignore resource_id while getting fscache super cookie

2021-12-18T01:09:06+00:00

We have a cyclic dependency between fscache super cookie
and root inode cookie. The super cookie relies on
tcon->resource_id, which gets populated from the root inode
number. However, fetching the root inode initializes inode
cookie as a child of super cookie, which is yet to be populated.

resource_id is only used as auxdata to check the validity of
super cookie. We can completely avoid setting resource_id to
remove the circular dependency. Since vol creation time and
vol serial numbers are used for auxdata, we should be fine.
Additionally, there will be auxiliary data check for each
inode cookie as well.

Fixes: 5bf91ef03d98 ("cifs: wait for tcon resource_id before getting fscache super")
CC: David Howells 
Signed-off-by: Shyam Prasad N 
Signed-off-by: Steve French

cifs: fix ntlmssp auth when there is no key exchange

2021-12-08T22:48:43+00:00

Warn on the lack of key exchange during NTLMSSP authentication rather
than aborting it as there are some servers that do not set it in
CHALLENGE message.

Signed-off-by: Paulo Alcantara (SUSE) 
Acked-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: avoid use of dstaddr as key for fscache client cookie

2021-12-03T18:38:25+00:00

server->dstaddr can change when the DNS mapping for the
server hostname changes. But conn_id is a u64 counter
that is incremented each time a new TCP connection
is setup. So use only that as a key.

Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: add server conn_id to fscache client cookie

2021-12-03T18:36:04+00:00

The fscache client cookie uses the server address
(and port) as the cookie key. This is a problem when
nosharesock is used. Two different connections will
use duplicate cookies. Avoid this by adding
server->conn_id to the key, so that it's guaranteed
that cookie will not be duplicated.

Also, for secondary channels of a session, copy the
fscache pointer from the primary channel. The primary
channel is guaranteed not to go away as long as secondary
channels are in use.  Also addresses minor problem found
by kernel test robot.

Reported-by: kernel test robot 
Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: wait for tcon resource_id before getting fscache super

2021-12-03T18:29:59+00:00

The logic for initializing tcon->resource_id is done inside
cifs_root_iget. fscache super cookie relies on this for aux
data. So we need to push the fscache initialization to this
later point during mount.

Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: fix missed refcounting of ipc tcon

2021-12-03T18:29:10+00:00

Fix missed refcounting of IPC tcon used for getting domain-based DFS
root referrals.  We want to keep it alive as long as mount is active
and can be refreshed.  For standalone DFS root referrals it wouldn't
be a problem as the client ends up having an IPC tcon for both mount
and cache.

Fixes: c88f7dcd6d64 ("cifs: support nested dfs links over reconnect")
Signed-off-by: Paulo Alcantara (SUSE) 
Reviewed-by: Enzo Matsumiya 
Signed-off-by: Steve French

cifs: update internal version number

2021-11-23T16:07:15+00:00

To 2.34

Signed-off-by: Steve French

smb2: clarify rc initialization in smb2_reconnect

2021-11-23T16:07:00+00:00

It is clearer to initialize rc at the beginning of the function.

Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: populate server_hostname for extra channels

2021-11-23T16:05:39+00:00

Recently, a new field got added to the smb3_fs_context struct
named server_hostname. While creating extra channels, pick up
this field from primary channel.

Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French