linux.git/fs/cifs, branch v5.15

cifs: fix incorrect check for null pointer in header_assemble

2021-09-24T02:12:53+00:00

Although very unlikely that the tlink pointer would be null in this case,
get_next_mid function can in theory return null (but not an error)
so need to check for null (not for IS_ERR, which can not be returned
here).

Address warning:

        fs/smbfs_client/connect.c:2392 cifs_match_super()
        warn: 'tlink' isn't an ERR_PTR

Pointed out by Dan Carpenter via smatch code analysis tool

CC: stable@vger.kernel.org
Reported-by: Dan Carpenter 
Acked-by: Ronnie Sahlberg 
Signed-off-by: Steve French

smb3: correct server pointer dereferencing check to be more consistent

2021-09-24T02:12:23+00:00

Address warning:

    fs/smbfs_client/misc.c:273 header_assemble()
    warn: variable dereferenced before check 'treeCon->ses->server'

Pointed out by Dan Carpenter via smatch code analysis tool

Although the check is likely unneeded, adding it makes the code
more consistent and easier to read, as the same check is
done elsewhere in the function.

Reported-by: Dan Carpenter 
Acked-by: Ronnie Sahlberg 
Signed-off-by: Steve French

smb3: correct smb3 ACL security descriptor

2021-09-23T21:17:07+00:00

Address warning:

        fs/smbfs_client/smb2pdu.c:2425 create_sd_buf()
        warn: struct type mismatch 'smb3_acl vs cifs_acl'

Pointed out by Dan Carpenter via smatch code analysis tool

Reported-by: Dan Carpenter 
Acked-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: Clear modified attribute bit from inode flags

2021-09-23T21:16:19+00:00

Clear CIFS_INO_MODIFIED_ATTR bit from inode flags after
updating mtime and ctime

Signed-off-by: Rohith Surabattula 
Reviewed-by: Paulo Alcantara (SUSE) 
Acked-by: Ronnie Sahlberg 
Cc: stable@vger.kernel.org # 5.13+
Signed-off-by: Steve French

cifs: Deal with some warnings from W=1

2021-09-23T19:06:17+00:00

Deal with some warnings generated from make W=1:

 (1) Add/remove/fix kerneldoc parameters descriptions.

 (2) Turn cifs' rqst_page_get_length()'s banner comment into a kerneldoc
     comment.  It should probably be prefixed with "cifs_" though.

Signed-off-by: David Howells 
Signed-off-by: Steve French

cifs: fix a sign extension bug

2021-09-22T01:51:50+00:00

The problem is the mismatched types between "ctx->total_len" which is
an unsigned int, "rc" which is an int, and "ctx->rc" which is a
ssize_t.  The code does:

	ctx->rc = (rc == 0) ? ctx->total_len : rc;

We want "ctx->rc" to store the negative "rc" error code.  But what
happens is that "rc" is type promoted to a high unsigned int and
'ctx->rc" will store the high positive value instead of a negative
value.

The fix is to change "rc" from an int to a ssize_t.

Fixes: c610c4b619e5 ("CIFS: Add asynchronous write support through kernel AIO")
Signed-off-by: Dan Carpenter 
Signed-off-by: Steve French

cifs: Not to defer close on file when lock is set

2021-09-17T21:59:41+00:00

Close file immediately when lock is set.

Cc: stable@vger.kernel.org # 5.13+
Signed-off-by: Rohith Surabattula 
Signed-off-by: Steve French

cifs: Fix soft lockup during fsstress

2021-09-17T21:54:25+00:00

Below traces are observed during fsstress and system got hung.
[  130.698396] watchdog: BUG: soft lockup - CPU#6 stuck for 26s!

Cc: stable@vger.kernel.org # 5.13+
Signed-off-by: Rohith Surabattula 
Signed-off-by: Steve French

cifs: Deferred close performance improvements

2021-09-17T21:39:53+00:00

During unlink/rename instead of closing all the deferred handles
under tcon, close only handles under the requested dentry.

Signed-off-by: Rohith Surabattula 
Signed-off-by: Steve French

cifs: fix incorrect kernel doc comments

2021-09-13T23:29:46+00:00

Correct kernel-doc comments pointed out by the
automated kernel test robot.

Reported-by: kernel test robot 
Signed-off-by: Steve French