linux.git/fs/cifs, branch v5.14

cifs: Call close synchronously during unlink/rename/lease break.

2021-08-12T16:29:58+00:00

During unlink/rename/lease break, deferred work for close is
scheduled immediately but in an asynchronous manner which might
lead to race with actual(unlink/rename) commands.

This change will schedule close synchronously which will avoid
the race conditions with other commands.

Signed-off-by: Rohith Surabattula 
Reviewed-by: Shyam Prasad N 
Cc: stable@vger.kernel.org # 5.13
Signed-off-by: Steve French

cifs: Handle race conditions during rename

2021-08-12T16:29:54+00:00

When rename is executed on directory which has files for which
close is deferred, then rename will fail with EACCES.

This patch will try to close all deferred files when EACCES is received
and retry rename on a directory.

Signed-off-by: Rohith Surabattula 
Cc: stable@vger.kernel.org # 5.13
Reviewed-by: Shyam Prasad N 
Signed-off-by: Steve French

cifs: use the correct max-length for dentry_path_raw()

2021-08-10T15:45:50+00:00

RHBZ: 1972502

PATH_MAX is 4096 but PAGE_SIZE can be >4096 on some architectures
such as ppc and would thus write beyond the end of the actual object.

Cc: 
Reported-by: Xiaoli Feng 
Suggested-by: Brian foster 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: create sd context must be a multiple of 8

2021-08-05T17:48:42+00:00

We used to follow the rule earlier that the create SD context
always be a multiple of 8. However, with the change:
cifs: refactor create_sd_buf() and and avoid corrupting the buffer
...we recompute the length, and we failed that rule.
Fixing that with this change.

Cc:  # v5.10+
Signed-off-by: Shyam Prasad N 
Signed-off-by: Steve French

cifs: add missing parsing of backupuid

2021-07-28T22:03:24+00:00

We lost parsing of backupuid in the switch to new mount API.
Add it back.

Signed-off-by: Ronnie Sahlberg 
Reviewed-by: Shyam Prasad N 
Cc:  # v5.11+
Reported-by: Xiaoli Feng 
Signed-off-by: Steve French

smb3: rc uninitialized in one fallocate path

2021-07-27T03:35:46+00:00

Clang detected a problem with rc possibly being unitialized
(when length is zero) in a recently added fallocate code path.

Reported-by: kernel test robot 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

SMB3: fix readpage for large swap cache

2021-07-27T03:35:25+00:00

readpage was calculating the offset of the page incorrectly
for the case of large swapcaches.

    loff_t offset = (loff_t)page->index << PAGE_SHIFT;

As pointed out by Matthew Wilcox, this needs to use
page_file_offset() to calculate the offset instead.
Pages coming from the swap cache have page->index set
to their index within the swapcache, not within the backing
file.  For a sufficiently large swapcache, we could have
overlapping values of page->index within the same backing file.

Suggested by: Matthew Wilcox (Oracle) 
Cc:  # v5.7+
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: fix fallocate when trying to allocate a hole.

2021-07-23T02:24:22+00:00

Remove the conditional checking for out_data_len and skipping the fallocate
if it is 0. This is wrong will actually change any legitimate the fallocate
where the entire region is unallocated into a no-op.

Additionally, before allocating the range, if FALLOC_FL_KEEP_SIZE is set then
we need to clamp the length of the fallocate region as to not extend the size of the file.

Fixes: 966a3cb7c7db ("cifs: improve fallocate emulation")
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

CIFS: Clarify SMB1 code for POSIX delete file

2021-07-22T19:35:15+00:00

Coverity also complains about the way we calculate the offset
(starting from the address of a 4 byte array within the
header structure rather than from the beginning of the struct
plus 4 bytes) for SMB1 CIFSPOSIXDelFile. This changeset
doesn't change the address but makes it slightly clearer.

Addresses-Coverity: 711519 ("Out of bounds write")
Signed-off-by: Steve French

CIFS: Clarify SMB1 code for POSIX Create

2021-07-22T18:50:41+00:00

Coverity also complains about the way we calculate the offset
(starting from the address of a 4 byte array within the
header structure rather than from the beginning of the struct
plus 4 bytes) for SMB1 CIFSPOSIXCreate. This changeset
doesn't change the address but makes it slightly clearer.

Addresses-Coverity: 711518 ("Out of bounds write")
Signed-off-by: Steve French