linux.git/fs/cifs, branch v5.12

cifs: escape spaces in share names

2021-04-08T02:30:27+00:00

Commit 653a5efb849a ("cifs: update super_operations to show_devname")
introduced the display of devname for cifs mounts. However, when mounting
a share which has a whitespace in the name, that exact share name is also
displayed in mountinfo. Make sure that all whitespace is escaped.

Signed-off-by: Maciek Borzecki 
CC:  # 5.11+
Reviewed-by: Shyam Prasad N 
Signed-off-by: Steve French

fs: cifs: Remove unnecessary struct declaration

2021-04-08T02:30:27+00:00

struct cifs_readdata is declared twice. One is declared
at 208th line.
And struct cifs_readdata is defined blew.
The declaration here is not needed. Remove the duplicate.

Signed-off-by: Wan Jiabing 
Reviewed-by: Shyam Prasad N 
Signed-off-by: Steve French

cifs: On cifs_reconnect, resolve the hostname again.

2021-04-08T02:29:36+00:00

On cifs_reconnect, make sure that DNS resolution happens again.
It could be the cause of connection to go dead in the first place.

This also contains the fix for a build issue identified by Intel bot.
Reported-by: kernel test robot 

Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Reviewed-by: Pavel Shilovsky 
CC:  # 5.11+
Signed-off-by: Steve French

smb3: fix cached file size problems in duplicate extents (reflink)

2021-03-26T23:41:55+00:00

There were two problems (one of which could cause data corruption)
that were noticed with duplicate extents (ie reflink)
when debugging why various xfstests were being incorrectly skipped
(e.g. generic/138, generic/140, generic/142). First, we were not
updating the file size locally in the cache when extending a
file due to reflink (it would refresh after actimeo expires)
but xfstest was checking the size immediately which was still
0 so caused the test to be skipped.  Second, we were setting
the target file size (which could shrink the file) in all cases
to the end of the reflinked range rather than only setting the
target file size when reflink would extend the file.

CC: 
Signed-off-by: Steve French

cifs: Silently ignore unknown oplock break handle

2021-03-26T23:05:26+00:00

Make SMB2 not print out an error when an oplock break is received for an
unknown handle, similar to SMB1.  The debug message which is printed for
these unknown handles may also be misleading, so fix that too.

The SMB2 lease break path is not affected by this patch.

Without this, a program which writes to a file from one thread, and
opens, reads, and writes the same file from another thread triggers the
below errors several times a minute when run against a Samba server
configured with "smb2 leases = no".

 CIFS: VFS: \\192.168.0.1 No task to wake, unknown frame received! NumMids 2
 00000000: 424d53fe 00000040 00000000 00000012  .SMB@...........
 00000010: 00000001 00000000 ffffffff ffffffff  ................
 00000020: 00000000 00000000 00000000 00000000  ................
 00000030: 00000000 00000000 00000000 00000000  ................

Signed-off-by: Vincent Whitchurch 
Reviewed-by: Tom Talpey 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: revalidate mapping when we open files for SMB1 POSIX

2021-03-26T23:04:58+00:00

RHBZ: 1933527

Under SMB1 + POSIX, if an inode is reused on a server after we have read and
cached a part of a file, when we then open the new file with the
re-cycled inode there is a chance that we may serve the old data out of cache
to the application.
This only happens for SMB1 (deprecated) and when posix are used.
The simplest solution to avoid this race is to force a revalidate
on smb1-posix open.

Signed-off-by: Ronnie Sahlberg 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: Fix chmod with modefromsid when an older ACE already exists.

2021-03-26T23:04:35+00:00

My recent fixes to cifsacl to maintain inherited ACEs had
regressed modefromsid when an older ACL already exists.

Found testing xfstest 495 with modefromsid mount option

Fixes: f5065508897a ("cifs: Retain old ACEs when converting between mode bits and ACL")

Signed-off-by: Shyam Prasad N 
Reviewed-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: Adjust key sizes and key generation routines for AES256 encryption

2021-03-26T12:49:39+00:00

For AES256 encryption (GCM and CCM), we need to adjust the size of a few
fields to 32 bytes instead of 16 to accommodate the larger keys.

Also, the L value supplied to the key generator needs to be changed from
to 256 when these algorithms are used.

Keeping the ioctl struct for dumping keys of the same size for now.
Will send out a different patch for that one.

Signed-off-by: Shyam Prasad N 
Reviewed-by: Ronnie Sahlberg 
CC:  # v5.10+
Signed-off-by: Steve French

cifs: fix allocation size on newly created files

2021-03-19T16:51:31+00:00

Applications that create and extend and write to a file do not
expect to see 0 allocation size.  When file is extended,
set its allocation size to a plausible value until we have a
chance to query the server for it.  When the file is cached
this will prevent showing an impossible number of allocated
blocks (like 0).  This fixes e.g. xfstests 614 which does

    1) create a file and set its size to 64K
    2) mmap write 64K to the file
    3) stat -c %b for the file (to query the number of allocated blocks)

It was failing because we returned 0 blocks.  Even though we would
return the correct cached file size, we returned an impossible
allocation size.

Signed-off-by: Steve French 
CC: 
Reviewed-by: Aurelien Aptel

cifs: warn and fail if trying to use rootfs without the config option

2021-03-19T05:50:58+00:00

If CONFIG_CIFS_ROOT is not set, rootfs mount option is invalid

Signed-off-by: Aurelien Aptel 
CC:  # v5.11
Signed-off-by: Steve French