linux.git/fs/cifs, branch v4.20

smb3: Fix rmdir compounding regression to strict servers

2018-12-19T13:55:32+00:00

Some servers require that the setinfo matches the exact size,
and in this case compounding changes introduced by
commit c2e0fe3f5aae ("cifs: make rmdir() use compounding")
caused us to send 8 bytes (padded length) instead of 1 byte
(the size of the structure).  See MS-FSCC section 2.4.11.

Fixing this when we send a SET_INFO command for delete file
disposition, then ends up as an iov of a single byte but this
causes problems with SMB3 and encryption.

To avoid this, instead of creating a one byte iov for the disposition value
and then appending an additional iov with a 7 byte padding we now handle
this as a single 8 byte iov containing both the disposition byte as well as
the padding in one single buffer.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French 
Acked-by: Paulo Alcantara

CIFS: Avoid returning EBUSY to upper layer VFS

2018-12-07T06:59:23+00:00

EBUSY is not handled by VFS, and will be passed to user-mode. This is not
correct as we need to wait for more credits.

This patch also fixes a bug where rsize or wsize is used uninitialized when
the call to server->ops->wait_mtu_credits() fails.

Reported-by: Dan Carpenter 
Signed-off-by: Long Li 
Signed-off-by: Steve French 
Reviewed-by: Pavel Shilovsky

cifs: Fix separator when building path from dentry

2018-12-06T08:20:17+00:00

Make sure to use the CIFS_DIR_SEP(cifs_sb) as path separator for
prefixpath too. Fixes a bug with smb1 UNIX extensions.

Fixes: a6b5058fafdf ("fs/cifs: make share unaccessible at root level mountable")
Signed-off-by: Paulo Alcantara 
Reviewed-by: Aurelien Aptel 
Signed-off-by: Steve French 
CC: Stable

cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs)

2018-12-06T08:20:14+00:00

Missing a dependency.  Shouldn't show cifs posix extensions
in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1
protocol) is disabled.

Signed-off-by: Steve French 
Reviewed-by: Pavel Shilovsky

cifs: fix signed/unsigned mismatch on aio_read patch

2018-11-02T19:09:42+00:00

The patch "CIFS: Add support for direct I/O read" had
a signed/unsigned mismatch (ssize_t vs. size_t) in the
return from one function.  Similar trivial change
in aio_write

Signed-off-by: Long Li 
Signed-off-by: Steve French 
Reported-by: Julia Lawall

cifs: don't dereference smb_file_target before null check

2018-11-02T19:09:42+00:00

There is a null check on dst_file->private data which suggests
it can be potentially null. However, before this check, pointer
smb_file_target is derived from dst_file->private and dereferenced
in the call to tlink_tcon, hence there is a potential null pointer
deference.

Fix this by assigning smb_file_target and target_tcon after the
null pointer sanity checks.

Detected by CoverityScan, CID#1475302 ("Dereference before null check")

Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
Signed-off-by: Colin Ian King 
Signed-off-by: Steve French

CIFS: Add direct I/O functions to file_operations

2018-11-02T19:09:42+00:00

With direct read/write functions implemented, add them to file_operations.

Dircet I/O is used under two conditions:
1. When mounting with "cache=none", CIFS uses direct I/O for all user file
data transfer.
2. When opening a file with O_DIRECT, CIFS uses direct I/O for all data
transfer on this file.

Signed-off-by: Long Li 
Signed-off-by: Steve French 
Reviewed-by: Ronnie Sahlberg

CIFS: Add support for direct I/O write

2018-11-02T19:09:42+00:00

With direct I/O write, user supplied buffers are pinned to the memory and data
are transferred directly from user buffers to the transport layer.

Change in v3: add support for kernel AIO

Change in v4:
Refactor common write code to __cifs_writev for direct and non-direct I/O.
Retry on direct I/O failure.

Signed-off-by: Long Li 
Signed-off-by: Steve French

CIFS: Add support for direct I/O read

2018-11-02T19:09:41+00:00

With direct I/O read, we transfer the data directly from transport layer to
the user data buffer.

Change in v3: add support for kernel AIO

Change in v4:
Refactor common read code to __cifs_readv for direct and non-direct I/O.
Retry on direct I/O failure.

Signed-off-by: Long Li 
Signed-off-by: Steve French

smb3: missing defines and structs for reparse point handling

2018-11-02T19:09:41+00:00

We were missing some structs from MS-FSCC relating to
reparse point handling.  Add them to protocol defines
in smb2pdu.h

Signed-off-by: Steve French 
Reviewed-by: Aurelien Aptel