linux.git/fs/cifs/dfs_cache.c, branch v5.13

cifs: constify get_normalized_path() properly

2021-04-25T21:28:23+00:00

As it is, it takes const char * and, in some cases, stores it in
caller's variable that is plain char *.  Fortunately, none of the
callers actually proceeded to modify the string via now-non-const
alias, but that's trouble waiting to happen.

It's easy to do properly, anyway...

Signed-off-by: Al Viro 
Signed-off-by: Steve French

cifs: don't cargo-cult strndup()

2021-04-25T21:28:23+00:00

strndup(s, strlen(s)) is a highly unidiomatic way to spell strdup(s);
it's *NOT* safer in any way, since strlen() is just as sensitive to
NUL-termination as strdup() is.

strndup() is for situations when you need a copy of a known-sized
substring, not a magic security juju to drive the bad spirits away.

Signed-off-by: Al Viro 
Signed-off-by: Steve French

cifs: introduce helper for finding referral server to improve DFS target resolution

2021-02-25T18:19:15+00:00

Some servers seem to mistakenly report different values for
capabilities and share flags, so we can't always rely on those values
to decide whether the resolved target can handle any new DFS
referrals.

Add a new helper is_referral_server() to check if all resolved targets
can handle new DFS referrals by directly looking at the
GET_DFS_REFERRAL.ReferralHeaderFlags value as specified in MS-DFSC
2.2.4 RESP_GET_DFS_REFERRAL in addition to is_tcon_dfs().

Signed-off-by: Paulo Alcantara (SUSE) 
Cc: stable@vger.kernel.org # 5.11
Signed-off-by: Steve French

cifs: fix dfs domain referrals

2021-01-29T03:40:43+00:00

The new mount API requires additional changes to how DFS
is handled. Additional testing of DFS uncovered problems
with domain based DFS referrals (a follow on patch addresses
DFS links) which this patch addresses.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Paulo Alcantara (SUSE) 
Signed-off-by: Steve French

cifs: check pointer before freeing

2021-01-13T18:55:29+00:00

clang static analysis reports this problem

dfs_cache.c:591:2: warning: Argument to kfree() is a constant address
  (18446744073709551614), which is not memory allocated by malloc()
        kfree(vi);
        ^~~~~~~~~

In dfs_cache_del_vol() the volume info pointer 'vi' being freed
is the return of a call to find_vol().  The large constant address
is find_vol() returning an error.

Add an error check to dfs_cache_del_vol() similar to the one done
in dfs_cache_update_vol().

Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines")
Signed-off-by: Tom Rix 
Reviewed-by: Nathan Chancellor 
CC:  # v5.0+
Signed-off-by: Steve French

cifs: move cifs_cleanup_volume_info[_content] to fs_context.c

2020-12-14T15:26:30+00:00

and rename it to smb3_cleanup_fs_context[_content]

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: remove the devname argument to cifs_compose_mount_options

2020-12-14T01:12:07+00:00

none of the callers use this argument any more.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: switch to new mount api

2020-12-14T01:12:07+00:00

See Documentation/filesystems/mount_api.rst for details on new mount API

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: rename dup_vol to smb3_fs_context_dup and move it into fs_context.c

2020-12-14T01:12:07+00:00

Continue restructuring needed for support of new mount API

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

cifs: rename smb_vol as smb3_fs_context and move it to fs_context.h

2020-12-14T01:12:07+00:00

Harmonize and change all such variables to 'ctx', where possible.
No changes to actual logic.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French