linux.git/fs/ceph, branch v4.6-rc2

ceph: use kmem_cache_zalloc

2016-03-25T17:51:56+00:00

Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.

Signed-off-by: Geliang Tang 
Signed-off-by: Ilya Dryomov

ceph: use lookup request to revalidate dentry

2016-03-25T17:51:56+00:00

If dentry has no lease, ceph_d_revalidate() previously return 0.
This causes VFS to invalidate the dentry and create a new dentry
for later lookup. Invalidating a dentry also detach any underneath
mount points. So mount point inside cephfs can disapear mystically
(even the mount point is not modified by other hosts).

The fix is using lookup request to revalidate dentry without lease.
This can partly solve the mount points disapear issue (as long as
the mount point is not modified by other hosts)

Signed-off-by: Yan, Zheng

ceph: kill ceph_get_dentry_parent_inode()

2016-03-25T17:51:55+00:00

use vfs helper dget_parent() instead

Signed-off-by: Yan, Zheng

ceph: fix security xattr deadlock

2016-03-25T17:51:55+00:00

When security is enabled, security module can call filesystem's
getxattr/setxattr callbacks during d_instantiate(). For cephfs,
d_instantiate() is usually called by MDS' dispatch thread, while
handling MDS reply. If the MDS reply does not include xattrs and
corresponding caps, getxattr/setxattr need to send a new request
to MDS and waits for the reply. This makes MDS' dispatch sleep,
nobody handles later MDS replies.

The fix is make sure lookup/atomic_open reply include xattrs and
corresponding caps. So getxattr can be handled by cached xattrs.
This requires some modification to both MDS and request message.
(Client tells MDS what caps it wants; MDS encodes proper caps in
the reply)

Smack security module may call setxattr during d_instantiate().
Unlike getxattr, we can't force MDS to issue CEPH_CAP_XATTR_EXCL
to us. So just make setxattr return error when called by MDS'
dispatch thread.

Signed-off-by: Yan, Zheng

ceph: don't request vxattrs from MDS

2016-03-25T17:51:55+00:00

It's uselese because MDS reply does not carry any vxattr.

Signed-off-by: Yan, Zheng

ceph: fix mounting same fs multiple times

2016-03-25T17:51:54+00:00

Now __ceph_open_session() only accepts closed client. An opened
client will tigger BUG_ON().

Signed-off-by: Yan, Zheng

ceph: remove unnecessary NULL check

2016-03-25T17:51:54+00:00

If page->mapping is NULL, releasepage() callback does not get called.
Remove the unnecessary NULL check to make static code analysis tool
happy

Signed-off-by: Yan, Zheng

ceph: avoid updating directory inode's i_size accidentally

2016-03-25T17:51:53+00:00

Directory inode's i_size is used by readdir cache.

Signed-off-by: Yan, Zheng

ceph: fix race during filling readdir cache

2016-03-25T17:51:53+00:00

Readdir cache uses page cache to save dentry pointers. When adding
dentry pointers to middle of a page, we need to make sure the page
already exists. Otherwise the beginning part of the page will be
invalid pointers.

Signed-off-by: Yan, Zheng

ceph: kill ceph_empty_snapc

2016-03-25T17:51:52+00:00

ceph_empty_snapc->num_snaps == 0 at all times.  Passing such a snapc to
ceph_osdc_alloc_request() (possibly through ceph_osdc_new_request()) is
equivalent to passing NULL, as ceph_osdc_alloc_request() uses it only
for sizing the request message.

Further, in all four cases the subsequent ceph_osdc_build_request() is
passed NULL for snapc, meaning that 0 is encoded for seq and num_snaps
and making ceph_empty_snapc entirely useless.  The two cases where it
actually mattered were removed in commits 860560904962 ("ceph: avoid
sending unnessesary FLUSHSNAP message") and 23078637e054 ("ceph: fix
queuing inode to mdsdir's snaprealm").

Signed-off-by: Ilya Dryomov 
Reviewed-by:  Yan, Zheng