linux.git/fs/ceph, branch v4.13

ceph: fix readpage from fscache

2017-08-31T22:04:26+00:00

ceph_readpage() unlocks page prematurely prematurely in the case
that page is reading from fscache. Caller of readpage expects that
page is uptodate when it get unlocked. So page shoule get locked
by completion callback of fscache_read_or_alloc_pages()

Cc: stable@vger.kernel.org # 4.1+, needs backporting for < 4.7
Signed-off-by: "Yan, Zheng" 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: fix race in concurrent readdir

2017-07-17T12:54:59+00:00

For a large directory, program needs to issue multiple readdir
syscalls to get all dentries. When there are multiple programs
read the directory concurrently. Following sequence of events
can happen.

 - program calls readdir with pos = 2. ceph sends readdir request
   to mds. The reply contains N1 entries. ceph adds these N1 entries
   to readdir cache.
 - program calls readdir with pos = N1+2. The readdir is satisfied
   by the readdir cache, N2 entries are returned. (Other program
   calls readdir in the middle, which fills the cache)
 - program calls readdir with pos = N1+N2+2. ceph sends readdir
   request to mds. The reply contains N3 entries and it reaches
   directory end. ceph adds these N3 entries to the readdir cache
   and marks directory complete.

The second readdir call does not update fi->readdir_cache_idx.
ceph add the last N3 entries to wrong places.

Cc: stable@vger.kernel.org # v4.3+
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: update ceph_dentry_info::lease_session when necessary

2017-07-07T15:25:14+00:00

Current code does not update ceph_dentry_info::lease_session once
it is set. If auth mds of corresponding dentry changes, dentry lease
keeps in an invalid state.

Signed-off-by: "Yan, Zheng" 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: new mount option that specifies fscache uniquifier

2017-07-07T15:25:14+00:00

Current ceph uses FSID as primary index key of fscache data. This
allows ceph to retain cached data across remount. But this causes
problem (kernel opps, fscache does not support sharing data) when
a filesystem get mounted several times (with fscache enabled, with
different mount options).

The fix is adding a new mount option, which specifies uniquifier
for fscache.

Signed-off-by: "Yan, Zheng" 
Acked-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: avoid accessing freeing inode in ceph_check_delayed_caps()

2017-07-07T15:25:13+00:00

Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: avoid invalid memory dereference in the middle of umount

2017-07-07T15:25:13+00:00

extra_mon_dispatch() and debugfs' foo_show functions dereference
fsc->mdsc. we should clean up fsc->client->extra_mon_dispatch
and debugfs before destroying fsc->mds.

Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: getattr before read on ceph.* xattrs

2017-07-07T15:25:13+00:00

Previously we were returning values for quota, layout
xattrs without any kind of update -- the user just got
whatever happened to be in our cache.

Clearly this extra round trip has a cost, but reads of
these xattrs are fairly rare, happening on admin
intervention rather than in normal operation.

Link: http://tracker.ceph.com/issues/17939
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: don't re-send interrupted flock request

2017-07-07T15:25:13+00:00

Don't re-send interrupted flock request in cases of mds failover
and receiving request forward. Because corresponding 'lock intr'
request may have been finished, it won't get re-sent.

Link: http://tracker.ceph.com/issues/20170
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: cleanup writepage_nounlock()

2017-07-07T15:25:13+00:00

Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: redirty page when writepage_nounlock() skips unwritable page

2017-07-07T15:25:13+00:00

Ceph needs to flush dirty page in the order in which in which snap
context they belong to. Dirty pages belong to older snap context
should be flushed earlier. if writepage_nounlock() can not flush a
page, it should redirty the page.

Reported-by: Dan Carpenter 
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov